From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B485ACE79A9 for ; Tue, 19 Sep 2023 17:23:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=U1B7/PSXaXwi/QdCx9hFmcEEtUhPMoPgJZlsbPDRZec=; b=QjCAr1BdwgymSZ Le3QuSEp/vGRjZ4Z4TJIDH0DU+uTd/RdHnVC3wdStBDa+kPq3kH7/bNnG8ERJtgAOsWf2C0g8krqg rc31j6FVoo/TmE37+pO1isc1sRY0I25X6vLvQVAsZRq/C50xv1Py8EeTM11JtxBebGhE8XwVqDT8f Gq1GGlBqG0pzR87rX5xakBWzWL6DO1cZYHWGKB6G2vLJiwAOvRFW8hoeB8BRbbVmEfQ5L2eedM53M ZMEDilMNHIpDR3u9slMclKQEeRkdn54ViJzSYTCzolscL5zjKapsenGoZctF9aI6iFa6vD9jclNv1 wbgvcRdP94KLvMfgZ2Jg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qieQq-000vfZ-2J; Tue, 19 Sep 2023 17:22:40 +0000 Received: from mail-ed1-x533.google.com ([2a00:1450:4864:20::533]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qieQn-000veY-3B for linux-arm-kernel@lists.infradead.org; Tue, 19 Sep 2023 17:22:39 +0000 Received: by mail-ed1-x533.google.com with SMTP id 4fb4d7f45d1cf-530c9980556so4212981a12.2 for ; Tue, 19 Sep 2023 10:22:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695144153; x=1695748953; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7cGNNyLACgJb4AD5nR+SBP4DdztAWfhiNOuK7PDwoIw=; b=Y7Y63xmoxp1G8zMniH1Y72g0Tzs/ZbngHQncnT8qNOdb2NSEQHEWDkI55HQ0TSRcrA W3aeVfbYC/9BDsKnCd+CDNKupZqzLng4lquhNjGYCKXFsGIselTJ4W2dyFXMqipvW3kh vSPPPnQqSbjibGyzOoVhxnYC58I5TheDL/hKvr5m+bVVQoCv5GKVyJI00ogUJjTRdbc7 kJvPUVAlQ4z9TjfeNxwdbnZa0FHUIXpF4609lyeHcrBnwtwPnRrsv2jB14DaX1HELF9h 24gkyCXUlpkHz3bQK5IMOJd7K006DnKYE2JNSCSb43LEqKDV3jvvLGxYGqVXhH7AOpMx qXfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695144153; x=1695748953; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7cGNNyLACgJb4AD5nR+SBP4DdztAWfhiNOuK7PDwoIw=; b=FhJ2vTHJdVW2q/bToxBtCZ87Id0yTwfiAqmizYVHWS7p6JJJH5cDmyWTZ2yjLZBBNP sMXnfIQgNok5za6cf7mWDiGIGAQ+kPYt+W/hmivHESKSsOMUTBpqjsrinMCrY8EpuFU4 6xHWdKyhb17+FxxusPo1Pi9G2Q+4tBOOj0S/quzvAl69T6DVMNurKeknmNpPBjRS/deO r0j9NqF6UZ417Sc6zI58z91OCSFL8x/KCOjsYngE/GQQvjiJNCszX48dNTYS8dMsfSUP VOtpVNqP/5d2W6FbLNsE/POfRTyv3RaDPLbkRa4zEVpXPz678ms7PTC8PffVZmf+CJ2K wKnw== X-Gm-Message-State: AOJu0YzjlGc7WB330l32ztU7YTVupknPZUe+8/NDVyfBwddwvP+7PxNu 1XhAUhmSsZ0TlpurJNEuuzM= X-Google-Smtp-Source: AGHT+IFv8smAnvNFarSKEjNvCp7t+rF8X2hnJd77OUxGbDfg7ce42ijsLqP+RJ7vT0FdhbTF+1rjDg== X-Received: by 2002:a17:906:5dcc:b0:99e:39d:4fa7 with SMTP id p12-20020a1709065dcc00b0099e039d4fa7mr37618ejv.22.1695144153180; Tue, 19 Sep 2023 10:22:33 -0700 (PDT) Received: from jernej-laptop.localnet (82-149-12-148.dynamic.telemach.net. [82.149.12.148]) by smtp.gmail.com with ESMTPSA id rp15-20020a170906d96f00b009a1b857e3a5sm8086138ejb.54.2023.09.19.10.22.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Sep 2023 10:22:32 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Uwe =?ISO-8859-1?Q?Kleine=2DK=F6nig?= Cc: Chen-Yu Tsai , Samuel Holland , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, kernel@pengutronix.de Subject: Re: [PATCH net-next 04/54] net: ethernet: allwinner: Convert to platform remove callback returning void Date: Tue, 19 Sep 2023 19:22:31 +0200 Message-ID: <3254669.aeNJFYEL58@jernej-laptop> In-Reply-To: <20230918204227.1316886-5-u.kleine-koenig@pengutronix.de> References: <20230918204227.1316886-1-u.kleine-koenig@pengutronix.de> <20230918204227.1316886-5-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230919_102238_024139_12EC581F X-CRM114-Status: GOOD ( 22.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Dne ponedeljek, 18. september 2023 ob 22:41:36 CEST je Uwe Kleine-K=F6nig = napisal(a): > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is ignored (apart > from emitting a warning) and this typically results in resource leaks. > To improve here there is a quest to make the remove callback return > void. In the first step of this quest all drivers are converted to > .remove_new() which already returns void. Eventually after all drivers > are converted, .remove_new() is renamed to .remove(). > = > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > = > Signed-off-by: Uwe Kleine-K=F6nig Acked-by: Jernej Skrabec Best regards, Jernej > --- > drivers/net/ethernet/allwinner/sun4i-emac.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > = > diff --git a/drivers/net/ethernet/allwinner/sun4i-emac.c > b/drivers/net/ethernet/allwinner/sun4i-emac.c index > a94c62956eed..d761c08fe5c1 100644 > --- a/drivers/net/ethernet/allwinner/sun4i-emac.c > +++ b/drivers/net/ethernet/allwinner/sun4i-emac.c > @@ -1083,7 +1083,7 @@ static int emac_probe(struct platform_device *pdev) > return ret; > } > = > -static int emac_remove(struct platform_device *pdev) > +static void emac_remove(struct platform_device *pdev) > { > struct net_device *ndev =3D platform_get_drvdata(pdev); > struct emac_board_info *db =3D netdev_priv(ndev); > @@ -1101,7 +1101,6 @@ static int emac_remove(struct platform_device *pdev) > free_netdev(ndev); > = > dev_dbg(&pdev->dev, "released and freed device\n"); > - return 0; > } > = > static int emac_suspend(struct platform_device *dev, pm_message_t state) > @@ -1143,7 +1142,7 @@ static struct platform_driver emac_driver =3D { > .of_match_table =3D emac_of_match, > }, > .probe =3D emac_probe, > - .remove =3D emac_remove, > + .remove_new =3D emac_remove, > .suspend =3D emac_suspend, > .resume =3D emac_resume, > }; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel