From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 61C74CDB47E for ; Fri, 13 Oct 2023 18:46:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=BNZfrxWtdtuiiiDLXQmU0XeJJV7l52V4h1lYG+x+tiY=; b=1EUq91fvRV9+U3 mW1xQtyRqb2LGXGpqOiDRKWUmnTsgQbvpgoWJvOdrdzAMZn0CcbEDc/1pI+3Iy1ZKx81pdXOR9r5C 5BWmj6Sxk40JelJq12suqT+6Y/VNE8vtXD+5zjsTVTQTo6rFtODC9w8E1MvpA88dVtce4b5E6BZtP qpLpXry2EotJA+TrHxLOhLqkoyFtCo7at/p5MdherP7GG1iFIQQib6UXjxbfQDNSPf2CPW+gxIBXY TBI8I8gsE1g5i1G/7o5tQ9SQFz/81IlVaDecpYaf4Lk8nvs9F/BKATsyjH/OadXSUPi3UtyMMUzN+ 2M7twnPEC/aLNbr+mqbw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qrNAS-0044uH-2N; Fri, 13 Oct 2023 18:45:48 +0000 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qrNAP-0044sn-2A for linux-arm-kernel@lists.infradead.org; Fri, 13 Oct 2023 18:45:47 +0000 Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-4054f790190so27632295e9.2 for ; Fri, 13 Oct 2023 11:45:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697222742; x=1697827542; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=nS/B/9nUlLmw6S4KsFUi4nqKiJBJFKciQh4FDxh+L/s=; b=lHjWH7MuOu3hFA+Z9JKs+RSla8rTIM2nAnP51P16lvUL2Y6BU8fwCM8XuwFOUV1JMe AyNKOQ7lP9fc5gE0ylnnK6MQLZZ3P3ZPvLGNlmWoiRBeZ1tVRg68API3I0/f3lfZLuC0 H4SGdGusJhWZamVZzP6KhWrzOP8QU1cWpWK655+H/NN5OmtqXsV72UOpieKiOeer0ReE kIS6wbGPcXvz93QX+3xWGJsoGlzYWaVTOLRyytnvcYdYjZUSDxzksnJae7Rq3/ymwqWz CxnfEv7oRCfkNaYuX76Ly0RF3J8teytOCWOsZSjru2H0y7bZv7qqet4MmhWlJbCgYYJM 42Fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697222742; x=1697827542; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nS/B/9nUlLmw6S4KsFUi4nqKiJBJFKciQh4FDxh+L/s=; b=kl5OczYYWewraKEEDMIXWjj2q0/idoZB95d2hAFkwu2xC8ceP7j4YDai/VwSrY0a0z tgXZhKxMxb6zT/UAy8539ZImWcTUWv35DXDqnYokkGLHkPTpnDsbMM+2JlNXRFVzgbKT yWHjwpkYVovDawobRfeY9Ely3zDJIyJSwHDZ5ge6s/tNlks+fGMboOLXbDlOyTGr89wl 8zD8GhsnC2qFZdMke5nxw6bJGXJzQTbhnF+uJQ9rJgShY8Ndg3ZD0xDfloDBxh7Pgizd VwGSUjHgZ0KFCCknYidOhovDrU2O6e3mMGWd8DpcTBcrQbtJZDU3RHLyJKKTFYah6W6a VBog== X-Gm-Message-State: AOJu0YxCJgAmvgp5nCmbW2qDUo252MG1cznZ7TkcRlewMpGYc0zu6KJy MuRGqCJTJ6dcn+CSJkKauVs= X-Google-Smtp-Source: AGHT+IHcbqPBjzX48zCFbc2YsOP+a2i9HmTRCmgyTQhV4W9XaKQNyEHu+7HzI1xt2rz8SXlqw5MDaQ== X-Received: by 2002:a7b:cb8c:0:b0:406:517f:ac71 with SMTP id m12-20020a7bcb8c000000b00406517fac71mr24094789wmi.29.1697222741548; Fri, 13 Oct 2023 11:45:41 -0700 (PDT) Received: from jernej-laptop.localnet ([188.159.248.16]) by smtp.gmail.com with ESMTPSA id e16-20020a05600c4e5000b004068495910csm840969wmq.23.2023.10.13.11.45.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Oct 2023 11:45:40 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Andre Przywara , Chukun Pan Cc: Samuel Holland , Chen-Yu Tsai , Rob Herring , Conor Dooley , Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Chukun Pan Subject: Re: [PATCH 2/2] arm64: dts: allwinner: h616: update emac properties for Orange Pi Zero 3 Date: Fri, 13 Oct 2023 20:45:38 +0200 Message-ID: <3254946.aeNJFYEL58@jernej-laptop> In-Reply-To: <20231010153812.2869633-2-amadeus@jmu.edu.cn> References: <20231010153812.2869633-1-amadeus@jmu.edu.cn> <20231010153812.2869633-2-amadeus@jmu.edu.cn> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231013_114545_709491_B02CC2E0 X-CRM114-Status: GOOD ( 18.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi! Dne torek, 10. oktober 2023 ob 17:38:12 CEST je Chukun Pan napisal(a): > Add the correct delay value to emac. Also add missing mdio > properties for the YT8531 PHY (clock output required). > With these changes, Ethernet now looks stable. This is also a fix, so it would also deserve Fixes tag. In fact, please merge previous and this patch into one. After all, you are fixing only one thing - ethernet on OrangePi Zero 3 board. Can you also explain how did you figure out that additional PHY properties are needed? At first glance, based on description of motorcomm,keep-pll-enabled, it's not immediately clear why it should be needed. Same goes for second property. 1800 ps delay basically means that rgmii is not correct type and rgmii-rxid should be used instead. Indeed, schematic confirms that's the case. With that, allwinner,rx-delay-ps can be 0 and thus ommited from DT file. Since there is many differences, I suggest that you remove whole emac0 node from common DTSI file and put specific ones to each board. It will be less confusing that way. Best regards, Jernej > > Signed-off-by: Chukun Pan > --- > arch/arm64/boot/dts/allwinner/sun50i-h618-orangepi-zero3.dts | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h618-orangepi-zero3.dts b/arch/arm64/boot/dts/allwinner/sun50i-h618-orangepi-zero3.dts > index 00fe28caac93..02c7836b624a 100644 > --- a/arch/arm64/boot/dts/allwinner/sun50i-h618-orangepi-zero3.dts > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h618-orangepi-zero3.dts > @@ -13,10 +13,14 @@ / { > }; > > &emac0 { > + allwinner,rx-delay-ps = <1800>; > + allwinner,tx-delay-ps = <700>; > phy-supply = <®_dldo1>; > }; > > &ext_rgmii_phy { > + motorcomm,keep-pll-enabled; > + motorcomm,auto-sleep-disabled; > motorcomm,clk-out-frequency-hz = <125000000>; > }; > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel