From: richard@nod.at (Richard Weinberger)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] mtd: stm32-quadspi: replace "%p" with "%pK"
Date: Fri, 06 Jul 2018 16:44:44 +0200 [thread overview]
Message-ID: <32602293.7BQn8HeLUA@blindfold> (raw)
In-Reply-To: <20180706130525.22223-1-benjamin.gaignard@st.com>
Am Freitag, 6. Juli 2018, 15:05:25 CEST schrieb Benjamin Gaignard:
> The format specifier "%p" can leak kernel addresses.
> Use "%pK" instead.
Does %pK really make sense for dev_dbg()?
When the driver is being debugged "leaking" is on purpose. :)
Thanks,
//richard
> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com>
> ---
> drivers/mtd/spi-nor/stm32-quadspi.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/mtd/spi-nor/stm32-quadspi.c b/drivers/mtd/spi-nor/stm32-quadspi.c
> index 72553506a00b..13e9fc961d3b 100644
> --- a/drivers/mtd/spi-nor/stm32-quadspi.c
> +++ b/drivers/mtd/spi-nor/stm32-quadspi.c
> @@ -355,7 +355,7 @@ static int stm32_qspi_read_reg(struct spi_nor *nor,
> struct device *dev = flash->qspi->dev;
> struct stm32_qspi_cmd cmd;
>
> - dev_dbg(dev, "read_reg: cmd:%#.2x buf:%p len:%#x\n", opcode, buf, len);
> + dev_dbg(dev, "read_reg: cmd:%#.2x buf:%pK len:%#x\n", opcode, buf, len);
>
> memset(&cmd, 0, sizeof(cmd));
> cmd.opcode = opcode;
> @@ -376,7 +376,7 @@ static int stm32_qspi_write_reg(struct spi_nor *nor, u8 opcode,
> struct device *dev = flash->qspi->dev;
> struct stm32_qspi_cmd cmd;
>
> - dev_dbg(dev, "write_reg: cmd:%#.2x buf:%p len:%#x\n", opcode, buf, len);
> + dev_dbg(dev, "write_reg: cmd:%#.2x buf:%pK len:%#x\n", opcode, buf, len);
>
> memset(&cmd, 0, sizeof(cmd));
> cmd.opcode = opcode;
> @@ -398,7 +398,7 @@ static ssize_t stm32_qspi_read(struct spi_nor *nor, loff_t from, size_t len,
> struct stm32_qspi_cmd cmd;
> int err;
>
> - dev_dbg(qspi->dev, "read(%#.2x): buf:%p from:%#.8x len:%#zx\n",
> + dev_dbg(qspi->dev, "read(%#.2x): buf:%pK from:%#.8x len:%#zx\n",
> nor->read_opcode, buf, (u32)from, len);
>
> memset(&cmd, 0, sizeof(cmd));
>
next prev parent reply other threads:[~2018-07-06 14:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-06 13:05 [PATCH] mtd: stm32-quadspi: replace "%p" with "%pK" Benjamin Gaignard
2018-07-06 14:44 ` Richard Weinberger [this message]
2018-07-06 14:47 ` Boris Brezillon
2018-07-06 14:49 ` Richard Weinberger
2018-07-07 10:09 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32602293.7BQn8HeLUA@blindfold \
--to=richard@nod.at \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox