From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 754F4C4332F for ; Wed, 13 Dec 2023 20:10:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WAapFtNmIwG/MgzQethjazwu+3c7lRpcTGPFkeC+VNc=; b=ZauduDhaoZ84NF iQ9xJjVSK/akguJjMvV91IhYNDAzURUbiARfJyScB7FdjGXfoiUKXZG0S8HnB0gy1ciw0jDB5Gp+N zNxWnRWvaBQ9Z2gfTk87nc7aFiyHW0M0Quko0FkE6uVaz+XQrz7zJwgz2m4CaNiD1yfbvDzecJ8CW l/hfAxL1Y1+T1SSsNeELfL9PpJGQAxcFlQ5NVP/9rSQjx7KJyHeUL7HEjwi4GypcQxE3apOBNeJjj UlaNSLhY8Hc0hZmmHjt6dsBSEA8qkl8ydYUTm/mI5+LZLSIM54dPE0I6xqD3ZuS4u9CDI4NPLATbO IJwSypaFvLdDpFXA4W6g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rDVY2-00FwAS-1R; Wed, 13 Dec 2023 20:09:38 +0000 Received: from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rDVY0-00FwA5-0o for linux-arm-kernel@lists.infradead.org; Wed, 13 Dec 2023 20:09:37 +0000 Received: by mail-wm1-x32a.google.com with SMTP id 5b1f17b1804b1-40c3f68b649so50091725e9.0 for ; Wed, 13 Dec 2023 12:09:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702498175; x=1703102975; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=E1E00I7csYet+h6d3hCBs5SooYMP4Ja6qAuEnzWpbHw=; b=W5qzfgJPQJnLVgJfgVdx284qaBM0tgZvSTFIw+p+yMRXhicz8fBWAyGIP64yjN+S6U c7g4xc7D9MuliVP2qz0bT5LJsUujek45Mjmr96s1c6XOiR3NWccp8w+oCYBDHQM0P98r S/YECxY+NjceKSey4P/GVkowd5ptARPQCeSWtsdEeec9W3urfoZESHo4U/+uJyRhJ5EZ 2aqqIh5lVsiShf9WEP1vwS/rITrOXTbWsPJtQavDCa1f7Ln5+nHFPM7BeeymWfEDSTuk x2UUybBZBv6/EipWP5wqmXpTAB423fp3hSHXxBqgaPXwAcjsP4DMwRE7gVTnaV4EyQ7N E/gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702498175; x=1703102975; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=E1E00I7csYet+h6d3hCBs5SooYMP4Ja6qAuEnzWpbHw=; b=jHAiYxeqDy9YMZ8g4aLHh64sZQdFZQ2065Z0ek6rFYaKnUJDhB6NRDhvsjK0Wx8b7s jXFXT2Hd3JBfZCO8G+kMsEvfMlmNzpqvbH2lPdGxQYJhd4vrdio6zEm/5opjw8T1xqzg uish9qRaclW46GzprLXTgVxfEwhLsbcUrAp/0XkZ8N5dDsdXhXXubqL4B7LdkIU+QlHD 2PcJ5PjsbAAjt6zDu2xHXgS0PwNA1t8NWgS5ovXzfXtSjsWmDQ6SwpxJZrURtQ3PHt7T 6DV6j/SthEoJUhcZik2r3aja02B+c+ihmO1U+fqywKnEbATnzZtzI1b0+9JcpfGPAQev Vm8g== X-Gm-Message-State: AOJu0YyssEkPfKB5WN7rjf/QNZpl/4fZguEwzwkDQRSY56nPSXvX5N4v HuBiUrHmgexIrz97tyPEHdBs8Mqk0+8= X-Google-Smtp-Source: AGHT+IGgnj9gSAhJ/otmBIdrNYjW6wgF/y7XkF5VoE4tuaeCabEiVYTrQgIZsnFDgtnuMk+zMFilUw== X-Received: by 2002:a7b:c419:0:b0:40b:2a3e:4c9b with SMTP id k25-20020a7bc419000000b0040b2a3e4c9bmr3183581wmi.29.1702498174346; Wed, 13 Dec 2023 12:09:34 -0800 (PST) Received: from archlinux.localnet (82-149-12-148.dynamic.telemach.net. [82.149.12.148]) by smtp.gmail.com with ESMTPSA id p8-20020a05600c468800b0040c488e4fb5sm11794611wmo.40.2023.12.13.12.09.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Dec 2023 12:09:34 -0800 (PST) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, Paul Kocialkowski Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Samuel Holland , Maxime Ripard , Laurent Pinchart , Michael Turquette , Stephen Boyd , Paul Kocialkowski Subject: Re: [PATCH v7 4/7] ARM: dts: sun8i: v3s: Add support for the ISP Date: Wed, 13 Dec 2023 21:09:32 +0100 Message-ID: <3267480.aeNJFYEL58@archlinux> In-Reply-To: <20231122141426.329694-5-paul.kocialkowski@bootlin.com> References: <20231122141426.329694-1-paul.kocialkowski@bootlin.com> <20231122141426.329694-5-paul.kocialkowski@bootlin.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231213_120936_289754_1B1DCA28 X-CRM114-Status: GOOD ( 21.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wednesday, November 22, 2023 3:14:22 PM CET Paul Kocialkowski wrote: > The V3s (and related platforms) come with an instance of the A31 ISP. > Even though it is very close to the A31 ISP, it is not exactly > register-compatible and a dedicated compatible only is used as a > result. > > Just like most other blocks of the camera pipeline, the ISP uses > the common CSI bus, module and ram clock as well as reset. > > A port connection to the ISP is added to CSI0 for convenience since > CSI0 serves for MIPI CSI-2 interface support, which is likely to > receive raw data that will need to be processed by the ISP to produce > a final image. > > The interconnects property is used to inherit the proper DMA offset. > > Signed-off-by: Paul Kocialkowski > --- > arch/arm/boot/dts/allwinner/sun8i-v3s.dtsi | 35 ++++++++++++++++++++++ > 1 file changed, 35 insertions(+) > > diff --git a/arch/arm/boot/dts/allwinner/sun8i-v3s.dtsi b/arch/arm/boot/dts/allwinner/sun8i-v3s.dtsi > index d57612023aa4..1a1dcd36cba4 100644 > --- a/arch/arm/boot/dts/allwinner/sun8i-v3s.dtsi > +++ b/arch/arm/boot/dts/allwinner/sun8i-v3s.dtsi > @@ -645,6 +645,14 @@ csi0_in_mipi_csi2: endpoint { > remote-endpoint = <&mipi_csi2_out_csi0>; > }; > }; > + > + port@2 { > + reg = <2>; > + > + csi0_out_isp: endpoint { > + remote-endpoint = <&isp_in_csi0>; > + }; > + }; > }; > }; > > @@ -703,5 +711,32 @@ csi1: camera@1cb4000 { > resets = <&ccu RST_BUS_CSI>; > status = "disabled"; > }; > + > + isp: isp@1cb8000 { > + compatible = "allwinner,sun8i-v3s-isp"; > + reg = <0x01cb8000 0x1000>; > + interrupts = ; > + clocks = <&ccu CLK_BUS_CSI>, > + <&ccu CLK_CSI1_SCLK>, > + <&ccu CLK_DRAM_CSI>; > + clock-names = "bus", "mod", "ram"; > + resets = <&ccu RST_BUS_CSI>; > + interconnects = <&mbus 5>; > + interconnect-names = "dma-mem"; Same as in previous patch, interconnects properties are not described in bindings, please update. Best regards, Jernej > + status = "disabled"; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + > + isp_in_csi0: endpoint { > + remote-endpoint = <&csi0_out_isp>; > + }; > + }; > + }; > + }; > }; > }; > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel