From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] logfs: clarify MTD dependency
Date: Fri, 27 Nov 2015 15:30:12 +0100 [thread overview]
Message-ID: <3269089.8XYbbcUOLH@wuerfel> (raw)
In-Reply-To: <20151127141406.GA29886@sepie.suse.cz>
On Friday 27 November 2015 15:14:06 Michal Marek wrote:
>
> Hi Arnd,
>
> I hit this as well and was about to submit a slightly different fix. Can
> you try the logfs portion of the below patch? Proper changelog is to be
> done, but the gist of the patch is that IS_REACHABLE(CONFIG_FOO)
> evaluates to 1 if CONFIG_FOO=y or we are building a module and
> CONFIG_FOO=m.
>
I thought about doing it that way, and I'm sure that also worked.
The possible behaviors are basically:
a) before your original patch, building logfs with CONFIG_MTD=m would
silently leave out MTD support, which was rather confusing.
b) with my patch, it becomes impossible to have logfs as the built-in
root file system on a block device while also using CONFIG_MTD=m,
and that may be slightly annoying
c) your patch restores a), but makes it work in the case where both
logfs and mtd are loadable modules, which is an improvement but
may still confuse users.
My preference is still version b) as I sent, but I don't really mind
your version either.
Arnd
next prev parent reply other threads:[~2015-11-27 14:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-27 13:54 [PATCH] logfs: clarify MTD dependency Arnd Bergmann
2015-11-27 14:14 ` Michal Marek
2015-11-27 14:30 ` Arnd Bergmann [this message]
2015-11-27 14:50 ` Michal Marek
-- strict thread matches above, loose matches on Subject: below --
2016-01-13 13:25 Arnd Bergmann
2016-01-13 20:39 ` Andrew Morton
2016-01-13 20:45 ` Arnd Bergmann
2016-01-13 21:31 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3269089.8XYbbcUOLH@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).