* [PATCH] ARM: dts: qcom: msm8974pro-samsung-klte: Add pstore node
@ 2024-07-15 8:32 Bingwu Zhang
2024-07-15 8:57 ` Krzysztof Kozlowski
0 siblings, 1 reply; 4+ messages in thread
From: Bingwu Zhang @ 2024-07-15 8:32 UTC (permalink / raw)
To: Tony Luck, Guilherme G. Piccoli, Bjorn Andersson, Konrad Dybcio,
Rob Herring, Krzysztof Kozlowski
Cc: Bingwu Zhang, Rong Zhang, Daniele Debernardi, Luca Weiss,
linux-arm-msm, linux-arm-kernel, linux-kernel, devicetree,
linux-hardening, ~xtex/staging
From: Bingwu Zhang <xtexchooser@duck.com>
Add pstore node to allow for retrieving crash logs.
Tested-by: Bingwu Zhang <xtexchooser@duck.com> # on SM-G9008W (samsung-kltechn)
Signed-off-by: Bingwu Zhang <xtexchooser@duck.com>
---
.../qcom-msm8974pro-samsung-klte-common.dtsi | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/arch/arm/boot/dts/qcom/qcom-msm8974pro-samsung-klte-common.dtsi b/arch/arm/boot/dts/qcom/qcom-msm8974pro-samsung-klte-common.dtsi
index b5443fd5b425..ff98b9362b0d 100644
--- a/arch/arm/boot/dts/qcom/qcom-msm8974pro-samsung-klte-common.dtsi
+++ b/arch/arm/boot/dts/qcom/qcom-msm8974pro-samsung-klte-common.dtsi
@@ -126,6 +126,23 @@ led@3 {
};
};
+ reserved-memory {
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges;
+
+ ramoops@3e8e0000 {
+ compatible = "ramoops";
+ reg = <0x3e8e0000 0x200000>;
+
+ console-size = <0x100000>;
+ record-size = <0x10000>;
+ ftrace-size = <0x10000>;
+ pmsg-size = <0x80000>;
+ ecc-size = <8>;
+ };
+ };
+
vreg_wlan: wlan-regulator {
compatible = "regulator-fixed";
base-commit: 6fd4da15c334831a865d4700ceb3ff5a917163e3
--
2.45.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: dts: qcom: msm8974pro-samsung-klte: Add pstore node
2024-07-15 8:32 [PATCH] ARM: dts: qcom: msm8974pro-samsung-klte: Add pstore node Bingwu Zhang
@ 2024-07-15 8:57 ` Krzysztof Kozlowski
2024-07-15 9:22 ` Bingwu Zhang
2024-07-15 9:23 ` Bingwu Zhang
0 siblings, 2 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2024-07-15 8:57 UTC (permalink / raw)
To: Bingwu Zhang, Tony Luck, Guilherme G. Piccoli, Bjorn Andersson,
Konrad Dybcio, Rob Herring, Krzysztof Kozlowski
Cc: Bingwu Zhang, Rong Zhang, Daniele Debernardi, Luca Weiss,
linux-arm-msm, linux-arm-kernel, linux-kernel, devicetree,
linux-hardening, ~xtex/staging
On 15/07/2024 10:32, Bingwu Zhang wrote:
> From: Bingwu Zhang <xtexchooser@duck.com>
>
> Add pstore node to allow for retrieving crash logs.
>
> Tested-by: Bingwu Zhang <xtexchooser@duck.com> # on SM-G9008W (samsung-kltechn)
Tested-by tags are provided by others, not by yourself. It's expected
that you test youro own patches. Drop the tag.
> Signed-off-by: Bingwu Zhang <xtexchooser@duck.com>
> ---
> .../qcom-msm8974pro-samsung-klte-common.dtsi | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
>
> diff --git a/arch/arm/boot/dts/qcom/qcom-msm8974pro-samsung-klte-common.dtsi b/arch/arm/boot/dts/qcom/qcom-msm8974pro-samsung-klte-common.dtsi
> index b5443fd5b425..ff98b9362b0d 100644
> --- a/arch/arm/boot/dts/qcom/qcom-msm8974pro-samsung-klte-common.dtsi
> +++ b/arch/arm/boot/dts/qcom/qcom-msm8974pro-samsung-klte-common.dtsi
> @@ -126,6 +126,23 @@ led@3 {
> };
> };
>
> + reserved-memory {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges;
Don't duplicate the nodes, but rather extend via phandle/label. Or at
least drop duplicated properties.
> +
> + ramoops@3e8e0000 {
> + compatible = "ramoops";
> + reg = <0x3e8e0000 0x200000>;
> +
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: dts: qcom: msm8974pro-samsung-klte: Add pstore node
2024-07-15 8:57 ` Krzysztof Kozlowski
@ 2024-07-15 9:22 ` Bingwu Zhang
2024-07-15 9:23 ` Bingwu Zhang
1 sibling, 0 replies; 4+ messages in thread
From: Bingwu Zhang @ 2024-07-15 9:22 UTC (permalink / raw)
To: Krzysztof Kozlowski, Krzysztof Kozlowski, linux-arm-msm
Cc: linux-arm-kernel, linux-kernel, devicetree, linux-hardening,
~xtex/staging
On Monday, July 15, 2024 4:57:54 PM GMT+8 Krzysztof Kozlowski wrote:
> Don't duplicate the nodes, but rather extend via phandle/label. Or at
> least drop duplicated properties.
I was referencing other qualcomm devices with ramoops enabled,
such as qcom-msm8974-sony-xperia-rhine.dtsi & qcom-apq8064-asus-nexus7-flo.dts.
They seem to have the same issue. Should I make another patch to change those?
Best regards,
--
xtex / Bingwu Zhang @ Mon Jul 15 09:19:42 AM UTC 2024
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: dts: qcom: msm8974pro-samsung-klte: Add pstore node
2024-07-15 8:57 ` Krzysztof Kozlowski
2024-07-15 9:22 ` Bingwu Zhang
@ 2024-07-15 9:23 ` Bingwu Zhang
1 sibling, 0 replies; 4+ messages in thread
From: Bingwu Zhang @ 2024-07-15 9:23 UTC (permalink / raw)
To: Krzysztof Kozlowski, Krzysztof Kozlowski, linux-arm-msm
Cc: linux-arm-kernel, linux-kernel, devicetree, linux-hardening,
~xtex/staging
On Monday, July 15, 2024 4:57:54 PM GMT+8 Krzysztof Kozlowski wrote:
> Don't duplicate the nodes, but rather extend via phandle/label. Or at
> least drop duplicated properties.
I was referencing other qualcomm devices with ramoops enabled,
such as qcom-msm8974-sony-xperia-rhine.dtsi & qcom-apq8064-asus-nexus7-flo.dts.
They seem to have the same issue. Should I make another patch to change those?
Best regards,
--
xtex / Bingwu Zhang @ Mon Jul 15 09:19:42 AM UTC 2024
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-07-15 9:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-15 8:32 [PATCH] ARM: dts: qcom: msm8974pro-samsung-klte: Add pstore node Bingwu Zhang
2024-07-15 8:57 ` Krzysztof Kozlowski
2024-07-15 9:22 ` Bingwu Zhang
2024-07-15 9:23 ` Bingwu Zhang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).