From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CF016C4167B for ; Thu, 7 Dec 2023 11:10:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=P/2Frzd2LkZ/9xhfoF504An3Eg+4b5WOKgayn7wlnnk=; b=HfdW7Jjv008+Ur uXskUkuVLKxv9jYjBTrWyKDAtH4eqasnc0lDMaXxf9UM0va4ZuUiFXK3ZJ0BJw3W9oN52rfh6QUQ/ zCUX1njT8tdreNNhcKiJkNGP6Nfd+kYpZAmNMqR+/UA2pjjIw9SlKs9lk9Cv6ODJ8qH7xz9kQyP/f 16CBk1rFk27yf9klA0Lg2dkC4/ofddq58dkF5ZsOTDAr8dLP5LZj4yt7CCdcST/HgTqR8RgAcfy7H mIt5QBWUrXaBwywGIkNIdYDxzZFmHLdrxhKFTSbJKvuxiB2n2mv0NCo+ON/tAm1eCJxrhTNlrVy8z QhA+EFUmnI9cCK+c5g5w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rBCGU-00CXLr-2q; Thu, 07 Dec 2023 11:09:58 +0000 Received: from mx1.tq-group.com ([93.104.207.81]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rBCGR-00CXKY-1j for linux-arm-kernel@lists.infradead.org; Thu, 07 Dec 2023 11:09:57 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1701947395; x=1733483395; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=QOhb5G2GcwS7djpDTCaIRKb88TJ9zbH94YYmNY6THIw=; b=FpeqAfRyBKhViJMLrsHguC2WaghngXaPJCWxKZhkdvj++JwLcDcAKydD qHp+JDc4aUzlogV4GYw8ZIu0NrJVdivw4VL8qKpcvXGl57bENTFqbHDzU xs+74gK4MUPj1RE3HNmxXYsW33TUOXnighIYK5apqks1mBk4eINl0Bpqi 2Uu/ggjR+UYuwvIRI5GMPQzBktBKkazVLfc615n8iE9fBdcGUqD26mY41 IPHMX7nQlYaLKVMEMDibHHmqPz/i9qX1gqk+FaXD9ukB0XklOHKaN083O +xdhPEGQkTSmvcEGSkXiIcrAnnDSRyMFDpf3dWt+etPBD+gFqClghGegs A==; X-IronPort-AV: E=Sophos;i="6.04,256,1695679200"; d="scan'208";a="34381314" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 07 Dec 2023 12:09:53 +0100 Received: from steina-w.localnet (steina-w.tq-net.de [10.123.53.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by vtuxmail01.tq-net.de (Postfix) with ESMTPSA id BC8E6280075; Thu, 7 Dec 2023 12:09:53 +0100 (CET) From: Alexander Stein To: Laurent Pinchart Cc: Mauro Carvalho Chehab , Shawn Guo , Sascha Hauer , Fabio Estevam , Pengutronix Kernel Team , NXP Linux Team , linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/1] media: nxp: imx8-isi-debug: Add missing registers to debugfs output Date: Thu, 07 Dec 2023 12:09:53 +0100 Message-ID: <3272819.44csPzL39Z@steina-w> Organization: TQ-Systems GmbH In-Reply-To: <20231207101400.GB3681@pendragon.ideasonboard.com> References: <20231206094401.491100-1-alexander.stein@ew.tq-group.com> <2915417.e9J7NaK4W3@steina-w> <20231207101400.GB3681@pendragon.ideasonboard.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231207_030955_873638_FA425FD6 X-CRM114-Status: GOOD ( 26.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Laurent, Am Donnerstag, 7. Dezember 2023, 11:14:00 CET schrieb Laurent Pinchart: > Hi Alexander, > = > On Thu, Dec 07, 2023 at 08:52:46AM +0100, Alexander Stein wrote: > > Am Mittwoch, 6. Dezember 2023, 23:36:36 CET schrieb Laurent Pinchart: > > > On Wed, Dec 06, 2023 at 10:44:01AM +0100, Alexander Stein wrote: > > > > The extended address registers are missing in the debug output > > > > register > > > > list. Add them. > > > > = > > > > Signed-off-by: Alexander Stein > > > > --- > > > > = > > > > drivers/media/platform/nxp/imx8-isi/imx8-isi-debug.c | 7 +++++++ > > > > 1 file changed, 7 insertions(+) > > > > = > > > > diff --git a/drivers/media/platform/nxp/imx8-isi/imx8-isi-debug.c > > > > b/drivers/media/platform/nxp/imx8-isi/imx8-isi-debug.c index > > > > 6709ab7ea1f3..3ac5685d6cc1 100644 > > > > --- a/drivers/media/platform/nxp/imx8-isi/imx8-isi-debug.c > > > > +++ b/drivers/media/platform/nxp/imx8-isi/imx8-isi-debug.c > > > > @@ -66,6 +66,13 @@ static int mxc_isi_debug_dump_regs_show(struct > > > > seq_file *m, void *p)> > > = > > > > MXC_ISI_DEBUG_REG(CHNL_OUT_BUF2_ADDR_V), > > > > MXC_ISI_DEBUG_REG(CHNL_SCL_IMG_CFG), > > > > MXC_ISI_DEBUG_REG(CHNL_FLOW_CTRL), > > > > = > > > > + MXC_ISI_DEBUG_REG(CHNL_Y_BUF1_XTND_ADDR), > > > > + MXC_ISI_DEBUG_REG(CHNL_U_BUF1_XTND_ADDR), > > > > + MXC_ISI_DEBUG_REG(CHNL_V_BUF1_XTND_ADDR), > > > > + MXC_ISI_DEBUG_REG(CHNL_Y_BUF2_XTND_ADDR), > > > > + MXC_ISI_DEBUG_REG(CHNL_U_BUF2_XTND_ADDR), > > > > + MXC_ISI_DEBUG_REG(CHNL_V_BUF2_XTND_ADDR), > > > > + MXC_ISI_DEBUG_REG(CHNL_IN_BUF_XTND_ADDR), > > > = > > > Those registers only exist in the i.MX8MP. The i.MX8MN referenece man= ual > > > lists them as reserved and indicates they read as 0's, so it should be > > > safe. The i.MX93 reference manual, however, doesn't list those > > > registers at all, so accessing them may lead to issues. > > > = > > > How what platform(s) have you tested this patch ? > > = > > Ah, you are right. That's something I didn't take into account. Up until > > now I only tested this on i.MX8MP. I hope I can test this on i.MX8MN and > > i.MX93 soon. > > Otherwise dumping these registers can depend on pdata->has_36bit_dma ju= st > > to be safe. > = > That sounds like a good solution to me. Will you do so in a v2 ? Yep, yep just sent it. Best regards Alexander > = > > > > }; > > > > = > > > > struct mxc_isi_pipe *pipe =3D m->private; -- = TQ-Systems GmbH | M=FChlstra=DFe 2, Gut Delling | 82229 Seefeld, Germany Amtsgericht M=FCnchen, HRB 105018 Gesch=E4ftsf=FChrer: Detlef Schneider, R=FCdiger Stahl, Stefan Schneider http://www.tq-group.com/ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel