From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D5E0CC3DA4A for ; Tue, 20 Aug 2024 11:43:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:Cc:From:References:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=JPTMNYO+ekauN1x+J36qP0OMg1LrAEGhasEw+JcZ9lw=; b=jV40QY8SI8QxR/TWdrcIDsK2Gv 2Yuvwi9oK3UFlT9eXTuuKW/brMnFvWcKNX9AzCHcXNmy6GfNATtjunPDWtTpWGFqLzAcD8kjB1S8U pr+tM3ALzp5fLF4SxVFsL2f/NA5NX8TR882l4xZhy3TIxdVyh29lrm99vXelm/v+zrU+EycrThw3d Um1xz2LLO5TYcM8f7BCDX/oIdeiDJ+lG9WFbw000Sk48g+1gwaPXfMkVz/gVNPHElv0TEwerES0Be xWZDpeqx7V8IeivCGPVECHhmQgUny45Per6OpIQABlNBMTCPJ14tIF8glFidYUM032PRCe+qXoaTr Xf15XMVg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sgNH1-000000053LF-3RId; Tue, 20 Aug 2024 11:43:40 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sgNG0-0000000537L-0r8P for linux-arm-kernel@lists.infradead.org; Tue, 20 Aug 2024 11:42:37 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4D56AFEC; Tue, 20 Aug 2024 04:43:01 -0700 (PDT) Received: from [10.57.70.240] (unknown [10.57.70.240]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 94FC43F73B; Tue, 20 Aug 2024 04:42:27 -0700 (PDT) Message-ID: <32a3bb02-59b2-432d-a75b-d7951971cda6@arm.com> Date: Tue, 20 Aug 2024 13:42:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/3] arm64: Prepare to switch to generic entry To: Jinjie Ruan References: <20240629085601.470241-1-ruanjinjie@huawei.com> <20240629085601.470241-3-ruanjinjie@huawei.com> Content-Language: en-GB From: Kevin Brodsky Cc: catalin.marinas@arm.com, will@kernel.org, oleg@redhat.com, tglx@linutronix.de, peterz@infradead.org, luto@kernel.org, kees@kernel.org, wad@chromium.org, rostedt@goodmis.org, arnd@arndb.de, ardb@kernel.org, broonie@kernel.org, mark.rutland@arm.com, rick.p.edgecombe@intel.com, leobras@redhat.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org In-Reply-To: <20240629085601.470241-3-ruanjinjie@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240820_044236_335626_94831D92 X-CRM114-Status: UNSURE ( 6.61 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 29/06/2024 10:56, Jinjie Ruan wrote: > -#define on_thread_stack() (on_task_stack(current, current_stack_pointer, 1)) > +static __always_inline bool on_thread_stack(void) > +{ > + return on_task_stack(current, current_stack_pointer, 1); > +} This looks reasonable but I wonder why this change is required (as the commit message suggests)? Kevin