linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Tim Chen <tim.c.chen@linux.intel.com>
To: Barry Song <21cnbao@gmail.com>,
	bp@alien8.de, catalin.marinas@arm.com, dietmar.eggemann@arm.com,
	gregkh@linuxfoundation.org, hpa@zytor.com, juri.lelli@redhat.com,
	bristot@redhat.com, lenb@kernel.org, mgorman@suse.de,
	mingo@redhat.com, peterz@infradead.org, rjw@rjwysocki.net,
	sudeep.holla@arm.com, tglx@linutronix.de
Cc: aubrey.li@linux.intel.com, bsegall@google.com,
	guodong.xu@linaro.org, jonathan.cameron@huawei.com,
	liguozhu@hisilicon.com, linux-acpi@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, mark.rutland@arm.com,
	msys.mizuma@gmail.com, prime.zeng@hisilicon.com,
	rostedt@goodmis.org, valentin.schneider@arm.com,
	vincent.guittot@linaro.org, will@kernel.org, x86@kernel.org,
	xuwei5@huawei.com, yangyicong@huawei.com, linuxarm@huawei.com,
	Barry Song <song.bao.hua@hisilicon.com>
Subject: Re: [PATCH 3/3] scheduler: Add cluster scheduler level for x86
Date: Mon, 23 Aug 2021 10:49:33 -0700	[thread overview]
Message-ID: <32bcec89-57d5-65e3-970b-affcf4f41667@linux.intel.com> (raw)
In-Reply-To: <20210820013008.12881-4-21cnbao@gmail.com>



On 8/19/21 6:30 PM, Barry Song wrote:
> From: Tim Chen <tim.c.chen@linux.intel.com>
> 
> There are x86 CPU architectures (e.g. Jacobsville) where L2 cahce is
> shared among a cluster of cores instead of being exclusive to one
> single core.
> To prevent oversubscription of L2 cache, load should be balanced
> between such L2 clusters, especially for tasks with no shared data.
> On benchmark such as SPECrate mcf test, this change provides a
> boost to performance especially on medium load system on Jacobsville.
> on a Jacobsville that has 24 Atom cores, arranged into 6 clusters
> of 4 cores each, the benchmark number is as follow:
> 
>  Improvement over baseline kernel for mcf_r
>  copies		run time	base rate
>  1		-0.1%		-0.2%
>  6		25.1%		25.1%
>  12		18.8%		19.0%
>  24		0.3%		0.3%
> 
> So this looks pretty good. In terms of the system's task distribution,
> some pretty bad clumping can be seen for the vanilla kernel without
> the L2 cluster domain for the 6 and 12 copies case. With the extra
> domain for cluster, the load does get evened out between the clusters.
> 
> Note this patch isn't an universal win as spreading isn't necessarily
> a win, particually for those workload who can benefit from packing.

I have another patch set to make cluster scheduling selectable at run
time and boot time.  Will like to see people's feed back on this patch
set first before sending that out.

Thanks.

Tim

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

      reply	other threads:[~2021-08-23 17:53 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-20  1:30 [PATCH 0/3] Represent cluster topology and enable load balance between clusters Barry Song
2021-08-20  1:30 ` [PATCH 1/3] topology: Represent clusters of CPUs within a die Barry Song
2022-05-06 20:24   ` [BUG] " Jeremy Linton
2022-05-09 10:15     ` Jonathan Cameron
2022-05-10 19:17       ` Darren Hart
2021-08-20  1:30 ` [PATCH 2/3] scheduler: Add cluster scheduler level in core and related Kconfig for ARM64 Barry Song
2021-08-20  1:30 ` [PATCH 3/3] scheduler: Add cluster scheduler level for x86 Barry Song
2021-08-23 17:49   ` Tim Chen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=32bcec89-57d5-65e3-970b-affcf4f41667@linux.intel.com \
    --to=tim.c.chen@linux.intel.com \
    --cc=21cnbao@gmail.com \
    --cc=aubrey.li@linux.intel.com \
    --cc=bp@alien8.de \
    --cc=bristot@redhat.com \
    --cc=bsegall@google.com \
    --cc=catalin.marinas@arm.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=guodong.xu@linaro.org \
    --cc=hpa@zytor.com \
    --cc=jonathan.cameron@huawei.com \
    --cc=juri.lelli@redhat.com \
    --cc=lenb@kernel.org \
    --cc=liguozhu@hisilicon.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxarm@huawei.com \
    --cc=mark.rutland@arm.com \
    --cc=mgorman@suse.de \
    --cc=mingo@redhat.com \
    --cc=msys.mizuma@gmail.com \
    --cc=peterz@infradead.org \
    --cc=prime.zeng@hisilicon.com \
    --cc=rjw@rjwysocki.net \
    --cc=rostedt@goodmis.org \
    --cc=song.bao.hua@hisilicon.com \
    --cc=sudeep.holla@arm.com \
    --cc=tglx@linutronix.de \
    --cc=valentin.schneider@arm.com \
    --cc=vincent.guittot@linaro.org \
    --cc=will@kernel.org \
    --cc=x86@kernel.org \
    --cc=xuwei5@huawei.com \
    --cc=yangyicong@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).