From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 65233CD6E4A for ; Thu, 4 Jun 2026 15:28:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=HILwUaJZg8rlDuhDvgpPr3lxwU8aF3skhizGmb68snY=; b=2VjZSxhoBpChmwiMnMYe6SiR/H 6vUpLRfq7Y0j85pYEefDtQu0l1SQTnrxNHwBGoXsUsVHS5uHlFkOFfmSl5dbxj3vPOuu2wANN2JgG OOFljbvVqXVbb+rWuKN4W5rwmHSY4cxvzR9tqcWI8cj2YCyQU7MiQHiF3B+unomxyfw0ai39f9WqM D5O8YipP0vAsQqJuPQURjoQtvy+cFWQn0J8/7oRPd2go6nZ8gjWj35gqXJSbrX5aXotIelmhOAwij iVjyX+BRzl1EZl2wETnjL7tLAxygXRLAMcMSMlPgTnv2JJIrt2eN45HAqcRXWAVhvdqXE16qMhQKn b69/e73g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wV9zN-0000000Gzm4-3uwk; Thu, 04 Jun 2026 15:28:09 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wV9zL-0000000GzlV-094g for linux-arm-kernel@lists.infradead.org; Thu, 04 Jun 2026 15:28:08 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D87E21516; Thu, 4 Jun 2026 08:28:00 -0700 (PDT) Received: from [10.1.34.54] (e122027.cambridge.arm.com [10.1.34.54]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 911F13F86F; Thu, 4 Jun 2026 08:28:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1780586885; bh=YtOWVl5eZxf9L/IZyd+Bnj2EBe0YqnfeeGynsWBEQwU=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=PvUdJ+L8EOCycYtjS/iYCTUrdqQzDKtRaPg5V+u08Q6l+KjZtgLeU/SzxEj+tKvEf tWjuM3eClZ5UZE5+WeJrBDZfgsgbuAD1A3FaxmK3PeM9p8i2TWL16zOGy5Lp86qsgl v4fHcEpSPP0jam2x+R+38YVPf1FbB4Jc+eExQnoI= Message-ID: <32d691c2-edfd-408c-bb49-7eba623bec11@arm.com> Date: Thu, 4 Jun 2026 16:27:57 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v14 13/44] arm64: RMI: Define the user ABI To: Wei-Lin Chang , kvm@vger.kernel.org, kvmarm@lists.linux.dev Cc: Catalin Marinas , Marc Zyngier , Will Deacon , James Morse , Oliver Upton , Suzuki K Poulose , Zenghui Yu , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Joey Gouly , Alexandru Elisei , Christoffer Dall , Fuad Tabba , linux-coco@lists.linux.dev, Ganapatrao Kulkarni , Gavin Shan , Shanker Donthineni , Alper Gun , "Aneesh Kumar K . V" , Emi Kisanuki , Vishal Annapurve , Lorenzo.Pieralisi2@arm.com References: <20260513131757.116630-1-steven.price@arm.com> <20260513131757.116630-14-steven.price@arm.com> From: Steven Price Content-Language: en-GB In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260604_082807_173402_38F83FB1 X-CRM114-Status: GOOD ( 27.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 26/05/2026 23:17, Wei-Lin Chang wrote: > On Wed, May 13, 2026 at 02:17:21PM +0100, Steven Price wrote: >> There is one CAP which identified the presence of CCA, and one ioctl. >> The ioctl is used to populate memory during creation of the realm as >> this requires the RMM to copy data from an unprotected address to the >> protected memory - CCA does not support memory conversion where the >> memory contents is preserved as this is incompatible with memory >> encryption. > > Nit: > I believe spelling out the CAP and ioctl names can improve the commit > message. Also "memory conversion" is a little vague, maybe > > ... CCA does not support shared <-> private memory conversion where ... > > would make this clearer? Thanks for the suggestions - yes I agree that would make it clearer. Thanks, Steve > Thanks, > Wei-Lin Chang > >> >> Signed-off-by: Steven Price >> --- >> Changes since v13: >> * KVM_ARM_VCPU_RMI_PSCI_COMPLETE removed. >> * KVM_ARM_RMI_POPULATE documentation updated to reflect that the >> structure is written by the kernel. >> * CAP number bumped. >> Changes since v12: >> * Change KVM_ARM_RMI_POPULATE to update the structure with the amount >> that has been progressed rather than return the number of bytes >> populated. >> * Describe the flag KVM_ARM_RMI_POPULATE_FLAGS_MEASURE. >> * CAP number is bumped. >> * NOTE: The PSCI ioctl may be removed in a future spec release. >> Changes since v11: >> * Completely reworked to be more implicit. Rather than having explicit >> CAP operations to progress the realm construction these operations >> are done when needed (on populating and on first vCPU run). >> * Populate and PSCI complete are promoted to proper ioctls. >> Changes since v10: >> * Rename symbols from RME to RMI. >> Changes since v9: >> * Improvements to documentation. >> * Bump the magic number for KVM_CAP_ARM_RME to avoid conflicts. >> Changes since v8: >> * Minor improvements to documentation following review. >> * Bump the magic numbers to avoid conflicts. >> Changes since v7: >> * Add documentation of new ioctls >> * Bump the magic numbers to avoid conflicts >> Changes since v6: >> * Rename some of the symbols to make their usage clearer and avoid >> repetition. >> Changes from v5: >> * Actually expose the new VCPU capability (KVM_ARM_VCPU_REC) by bumping >> KVM_VCPU_MAX_FEATURES - note this also exposes KVM_ARM_VCPU_HAS_EL2! >> --- >> Documentation/virt/kvm/api.rst | 40 ++++++++++++++++++++++++++++++++++ >> include/uapi/linux/kvm.h | 13 +++++++++++ >> 2 files changed, 53 insertions(+) >> >> diff --git a/Documentation/virt/kvm/api.rst b/Documentation/virt/kvm/api.rst >> index 52bbbb553ce1..ca68aae7faa2 100644 >> --- a/Documentation/virt/kvm/api.rst >> +++ b/Documentation/virt/kvm/api.rst >> @@ -6553,6 +6553,37 @@ KVM_S390_KEYOP_SSKE >> Sets the storage key for the guest address ``guest_addr`` to the key >> specified in ``key``, returning the previous value in ``key``. >> >> +4.145 KVM_ARM_RMI_POPULATE >> +-------------------------- >> + >> +:Capability: KVM_CAP_ARM_RMI >> +:Architectures: arm64 >> +:Type: vm ioctl >> +:Parameters: struct kvm_arm_rmi_populate (in/out) >> +:Returns: 0 on success, < 0 on error >> + >> +:: >> + >> + struct kvm_arm_rmi_populate { >> + __u64 base; >> + __u64 size; >> + __u64 source_uaddr; >> + __u32 flags; >> + __u32 reserved; >> + }; >> + >> +Populate a region of protected address space by copying the data from the >> +(non-protected) user space pointer provided into a protected region (backed by >> +guestmem_fd). It implicitly sets the destination region to RIPAS RAM. This is >> +only valid before any VCPUs have been run. The ioctl might not populate the >> +entire region and in this case the kernel updates the fields `base`, `size` and >> +`source_uaddr`. User space may have to repeatedly call it until `size` is 0 to >> +populate the entire region. >> + >> +`flags` can be set to `KVM_ARM_RMI_POPULATE_FLAGS_MEASURE` to request that the >> +populated data is hashed and added to the guest's Realm Initial Measurement >> +(RIM). >> + >> .. _kvm_run: >> >> 5. The kvm_run structure >> @@ -8904,6 +8935,15 @@ helpful if user space wants to emulate instructions which are not >> This capability can be enabled dynamically even if VCPUs were already >> created and are running. >> >> +7.47 KVM_CAP_ARM_RMI >> +-------------------- >> + >> +:Architectures: arm64 >> +:Target: VM >> +:Parameters: None >> + >> +This capability indicates that support for CCA realms is available. >> + >> 8. Other capabilities. >> ====================== >> >> diff --git a/include/uapi/linux/kvm.h b/include/uapi/linux/kvm.h >> index 6c8afa2047bf..b8cff0938041 100644 >> --- a/include/uapi/linux/kvm.h >> +++ b/include/uapi/linux/kvm.h >> @@ -996,6 +996,7 @@ struct kvm_enable_cap { >> #define KVM_CAP_S390_USER_OPEREXEC 246 >> #define KVM_CAP_S390_KEYOP 247 >> #define KVM_CAP_S390_VSIE_ESAMODE 248 >> +#define KVM_CAP_ARM_RMI 249 >> >> struct kvm_irq_routing_irqchip { >> __u32 irqchip; >> @@ -1669,4 +1670,16 @@ struct kvm_pre_fault_memory { >> __u64 padding[5]; >> }; >> >> +/* Available with KVM_CAP_ARM_RMI, only for VMs with KVM_VM_TYPE_ARM_REALM */ >> +#define KVM_ARM_RMI_POPULATE _IOWR(KVMIO, 0xd7, struct kvm_arm_rmi_populate) >> +#define KVM_ARM_RMI_POPULATE_FLAGS_MEASURE (1 << 0) >> + >> +struct kvm_arm_rmi_populate { >> + __u64 base; >> + __u64 size; >> + __u64 source_uaddr; >> + __u32 flags; >> + __u32 reserved; >> +}; >> + >> #endif /* __LINUX_KVM_H */ >> -- >> 2.43.0 >>