* [PATCH] ARM: fix bug in vdsomunge swab32 macro
@ 2015-10-28 15:10 H. Nikolaus Schaller
2015-10-30 12:54 ` Arnd Bergmann
0 siblings, 1 reply; 3+ messages in thread
From: H. Nikolaus Schaller @ 2015-10-28 15:10 UTC (permalink / raw)
To: linux-arm-kernel
Commit Commit 8a603f91cc48 ("ARM: 8445/1: fix vdsomunge not to depend on glibc specific byteswap.h")
unfortunately introduced a bug created but not found during
discussion and patch simplification.
Reported-by: Efraim Yawitz <efraim.yawitz@gmail.com>
Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
---
arch/arm/vdso/vdsomunge.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/vdso/vdsomunge.c b/arch/arm/vdso/vdsomunge.c
index 0cebd98..f645527 100644
--- a/arch/arm/vdso/vdsomunge.c
+++ b/arch/arm/vdso/vdsomunge.c
@@ -66,7 +66,7 @@
((((x) & 0x000000ff) << 24) | \
(((x) & 0x0000ff00) << 8) | \
(((x) & 0x00ff0000) >> 8) | \
- (((x) & 0xff000000) << 24))
+ (((x) & 0xff000000) >> 24))
#if __BYTE_ORDER__ == __ORDER_LITTLE_ENDIAN__
#define HOST_ORDER ELFDATA2LSB
--
2.5.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* [PATCH] ARM: fix bug in vdsomunge swab32 macro 2015-10-28 15:10 [PATCH] ARM: fix bug in vdsomunge swab32 macro H. Nikolaus Schaller @ 2015-10-30 12:54 ` Arnd Bergmann 2015-10-30 13:04 ` Russell King - ARM Linux 0 siblings, 1 reply; 3+ messages in thread From: Arnd Bergmann @ 2015-10-30 12:54 UTC (permalink / raw) To: linux-arm-kernel On Wednesday 28 October 2015 16:10:48 H. Nikolaus Schaller wrote: > Commit Commit 8a603f91cc48 ("ARM: 8445/1: fix vdsomunge not to depend on glibc specific byteswap.h") > > unfortunately introduced a bug created but not found during > discussion and patch simplification. > > Reported-by: Efraim Yawitz <efraim.yawitz@gmail.com> > Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com> > --- > Reviewed-by: Arnd Bergmann <arnd@arndb.de> Please add it to Russell's patch tracker at http://www.arm.linux.org.uk/developer/patches/ Arnd ^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] ARM: fix bug in vdsomunge swab32 macro 2015-10-30 12:54 ` Arnd Bergmann @ 2015-10-30 13:04 ` Russell King - ARM Linux 0 siblings, 0 replies; 3+ messages in thread From: Russell King - ARM Linux @ 2015-10-30 13:04 UTC (permalink / raw) To: linux-arm-kernel On Fri, Oct 30, 2015 at 01:54:55PM +0100, Arnd Bergmann wrote: > On Wednesday 28 October 2015 16:10:48 H. Nikolaus Schaller wrote: > > Commit Commit 8a603f91cc48 ("ARM: 8445/1: fix vdsomunge not to depend on glibc specific byteswap.h") > > > > unfortunately introduced a bug created but not found during > > discussion and patch simplification. > > > > Reported-by: Efraim Yawitz <efraim.yawitz@gmail.com> > > Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com> > > --- > > > > Reviewed-by: Arnd Bergmann <arnd@arndb.de> > > Please add it to Russell's patch tracker at > http://www.arm.linux.org.uk/developer/patches/ A patch very similar to this has already been merged (probably this patch but submitted by Nathan.) -- FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net. ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-10-30 13:04 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2015-10-28 15:10 [PATCH] ARM: fix bug in vdsomunge swab32 macro H. Nikolaus Schaller 2015-10-30 12:54 ` Arnd Bergmann 2015-10-30 13:04 ` Russell King - ARM Linux
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).