From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RFC] Add cpufreq support
Date: Fri, 05 Feb 2016 23:24:35 +0100 [thread overview]
Message-ID: <3308645.nrPBoahQ2V@wuerfel> (raw)
In-Reply-To: <56B4D4BE.2040008@free.fr>
On Friday 05 February 2016 17:58:38 Mason wrote:
> I'm throwing this out there to ask:
> Is this the right way to enable cpufreq on my platform?
> ---
> @@ -23,6 +24,11 @@ static void tango_l2c_write(unsigned long val, unsigned int reg)
> tango_set_l2_control(val);
> }
>
> +static void __init tango_init_late(void)
> +{
> + platform_device_register_simple("cpufreq-dt", -1, NULL, 0);
> +}
> +
> static const char *const tango_dt_compat[] = { "sigma,tango4", NULL };
>
> DT_MACHINE_START(TANGO_DT, "Sigma Tango DT")
> @@ -30,4 +36,5 @@ DT_MACHINE_START(TANGO_DT, "Sigma Tango DT")
> .l2c_aux_mask = ~0,
> .l2c_write_sec = tango_l2c_write,
> .map_io = tango_map_io,
> + .init_late = tango_init_late,
> MACHINE_END
>
We no longer call platform_device_register_simple() from platform code, at least
for new platforms, and we should probably remove the code from the existing
platforms that still do it. I forget what the replacement was, but I'm not
going to take this version. Viresh should be able to help you do it the right
way.
Arnd
next prev parent reply other threads:[~2016-02-05 22:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-05 16:58 [PATCH RFC] Add cpufreq support Mason
2016-02-05 22:24 ` Arnd Bergmann [this message]
2016-02-07 12:22 ` Viresh Kumar
2016-02-08 12:24 ` Arnd Bergmann
2016-02-08 12:31 ` Viresh Kumar
2016-02-08 12:34 ` Arnd Bergmann
2016-02-08 12:41 ` Viresh Kumar
2016-02-08 13:10 ` Arnd Bergmann
2016-02-08 13:16 ` Viresh Kumar
2016-02-08 13:45 ` Arnd Bergmann
2016-02-09 10:17 ` Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3308645.nrPBoahQ2V@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox