From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5AC73C433DF for ; Wed, 29 Jul 2020 16:25:21 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 295472075D for ; Wed, 29 Jul 2020 16:25:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="2TTgtZUB"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=z3ntu.xyz header.i=@z3ntu.xyz header.b="VTmVKLTt"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=z3ntu.xyz header.i=@z3ntu.xyz header.b="WLpTBGH8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 295472075D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=z3ntu.xyz Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=F3ztBsv7MZk7dUv00pWPEQHV89P/prLLD5WFWOkwKEU=; b=2TTgtZUBz6CpL6CB1+5vpQShk yMvmUu2CDbyd0bp13Pt7aMAdB/VgWyT+wwmwbqq4ESYSkwXZ1hJGhWCAudg4euPKW0qfMUtbMPcOO dc1BF8TxOE0L6go2Y+XpJM6EAqTdm9KZGM0THq6jwF+KxP+3ewNgimNBcIaG3C2nJ1IM+VMxusEBU 1pLPiIJece1eK2P6e5ADn2u6l9SwwfUcPDwx+/Ayn9vQF4P/L/vGDlo9rfL7NdJhoKlYwrK/n73+x 3I+PHOzYYhHUw6GR/4FwOsDAbv6PJDIl9Dfqbr7Exvq2qXZODmr7bbzRuYcBjde85BsGeoRsFDfGN PH6EHyBHA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k0orr-00015R-Ec; Wed, 29 Jul 2020 16:23:47 +0000 Received: from mail.z3ntu.xyz ([128.199.32.197]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k0orn-00014L-75 for linux-arm-kernel@lists.infradead.org; Wed, 29 Jul 2020 16:23:45 +0000 Received: by mail.z3ntu.xyz (Postfix, from userid 182) id 260B4C8E9C; Wed, 29 Jul 2020 16:23:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=z3ntu.xyz; s=z3ntu; t=1596039818; bh=7px2oC8Rr1ovpP9dzxfQC/kDXj9f9FD7M6s/6OxDAF8=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=VTmVKLTtQuSzZiMG41xjbrUWBLAFFtJ6/sPrdatRfxVTKms2PyciE8cjIlw3D3zqG +JuZqBL0MNrtnDcISgKRPfsxETA1NRBWbSkY4WXrv/ksmkdSwSbymZW54x8Ibbjhs9 dA9qSWhh+DEl3XHHlaGKI69s8SIW7TjuHq+81XwQ= Received: from g550jk.localnet (80-110-125-173.cgn.dynamic.surfer.at [80.110.125.173]) by mail.z3ntu.xyz (Postfix) with ESMTPSA id AC2D5C8E45; Wed, 29 Jul 2020 16:23:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=z3ntu.xyz; s=z3ntu; t=1596039811; bh=7px2oC8Rr1ovpP9dzxfQC/kDXj9f9FD7M6s/6OxDAF8=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=WLpTBGH8HDIK79bA+Cbo4CzRFnaK1y3w4vMvd1mrN9fWSfsQZfl27xFef573kx7xZ Xz8kFd+bTHK1HZ34RGr34bBgaattlbOTsYCA0ipmxAJ4+2PobvkEwgNHY4ylqc/Bmk fn+QDnpdNUFB+Ii2LogswFM7B1sU3lAir6oF4Upc= From: Luca Weiss To: Maxime Ripard Subject: Re: [PATCH] arm64: dts: sun50i-pinephone: add led flash Date: Wed, 29 Jul 2020 18:23:30 +0200 Message-ID: <3310810.lkFDjMPtvk@g550jk> In-Reply-To: <20200729123444.5t5cv47umhwu7jnd@gilmour.lan> References: <20200725110812.199529-1-luca@z3ntu.xyz> <20200729123444.5t5cv47umhwu7jnd@gilmour.lan> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200729_122343_387088_C41D5190 X-CRM114-Status: GOOD ( 19.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Chen-Yu Tsai , Rob Herring , ~postmarketos/upstreaming@lists.sr.ht, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Maxime, On Mittwoch, 29. Juli 2020 14:34:44 CEST Maxime Ripard wrote: > Hi! > > On Sat, Jul 25, 2020 at 01:08:12PM +0200, Luca Weiss wrote: > > All revisions of the PinePhone have an SGM3140 LED flash. The gpios were > > swapped on v1.0 of the board but this was fixed in later revisions. > > > > Signed-off-by: Luca Weiss > > --- > > > > .../boot/dts/allwinner/sun50i-a64-pinephone-1.0.dts | 5 +++++ > > .../boot/dts/allwinner/sun50i-a64-pinephone-1.1.dts | 5 +++++ > > .../boot/dts/allwinner/sun50i-a64-pinephone-1.2.dts | 5 +++++ > > .../boot/dts/allwinner/sun50i-a64-pinephone.dtsi | 11 +++++++++++ > > 4 files changed, 26 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.0.dts > > b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.0.dts index > > 0c42272106afa..b579b03d4e026 100644 > > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.0.dts > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.0.dts > > @@ -9,3 +9,8 @@ / { > > > > model = "Pine64 PinePhone Developer Batch (1.0)"; > > compatible = "pine64,pinephone-1.0", "allwinner,sun50i-a64"; > > > > }; > > > > + > > +&sgm3140 { > > + flash-gpios = <&pio 3 24 GPIO_ACTIVE_HIGH>; /* PD24 */ > > + enable-gpios = <&pio 2 3 GPIO_ACTIVE_HIGH>; /* PC3 */ > > +}; > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.1.dts > > b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.1.dts index > > 3e99a87e9ce52..8552587aac248 100644 > > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.1.dts > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.1.dts > > @@ -28,3 +28,8 @@ &backlight { > > > > num-interpolated-steps = <50>; > > default-brightness-level = <400>; > > > > }; > > > > + > > +&sgm3140 { > > + flash-gpios = <&pio 2 3 GPIO_ACTIVE_HIGH>; /* PC3 */ > > + enable-gpios = <&pio 3 24 GPIO_ACTIVE_HIGH>; /* PD24 */ > > +}; > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.2.dts > > b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.2.dts index > > a9f5b670c9b82..ec77715ba4a2a 100644 > > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.2.dts > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.2.dts > > @@ -38,3 +38,8 @@ &lis3mdl { > > > > interrupt-parent = <&pio>; > > interrupts = <1 1 IRQ_TYPE_EDGE_RISING>; /* PB1 */ > > > > }; > > > > + > > +&sgm3140 { > > + flash-gpios = <&pio 2 3 GPIO_ACTIVE_HIGH>; /* PC3 */ > > + enable-gpios = <&pio 3 24 GPIO_ACTIVE_HIGH>; /* PD24 */ > > +}; > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi > > b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi index > > 25150aba749dc..e0bc1bcc1c1f3 100644 > > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi > > @@ -60,6 +60,17 @@ vibrator { > > > > enable-gpios = <&pio 3 2 GPIO_ACTIVE_HIGH>; /* PD2 */ > > vcc-supply = <®_dcdc1>; > > > > }; > > > > + > > + sgm3140: led-controller { > > The nodes should be ordered by node-name here Will update the patch, forgot about that. > > + compatible = "sgmicro,sgm3140"; > > + vin-supply = <®_dcdc1>; > > + > > + sgm3140_flash: led { > > What do you need the label for? The label will be used for connecting the flash to the rear camera (which hasn't been upstreamed yet) using: flash-leds = <&sgm3140_flash>; Hope that clears it up. > > Thanks! > Maxime Regards Luca _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel