From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EFBEDC71144 for ; Fri, 18 Aug 2023 03:29:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Nu8lXWrDcqmRddft66qQjwkl51TT0sSFhHugCU2BJzE=; b=VWNKjlHStP0yBR tiAkGrLkCVjMSN8/tG89pEACHWpws2sXrHcgSFRREA9I0k3NN7L7Q6yLiX/YxnB07vtVSZZJw3nt2 wMWDzfue76CFAIB6nq7+Aul7lBpOaHK18D//CtsP+LZuiyXC5cmnnOb7MbNTTti0KQhbXy1/x4KG4 PFnxBQMxSYEwHTFyDawnojnsx3vIcy6zw1qii+X7JP7+lcNLLZTWfo5ATWL8SA2KCpTU/I0bx8rDa BcnTwMNo4eEZvLOpzXvLrmqWJl0p6ycXyIBSSpJ4D3XR/49mKUrrlmKKUaaD6+JB8OHmsaoROVjRK rP9R3Be/jSuw4ncKvzxw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qWqB3-007buM-0H; Fri, 18 Aug 2023 03:29:33 +0000 Received: from omta038.useast.a.cloudfilter.net ([44.202.169.37]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qWqB0-007btj-0a for linux-arm-kernel@lists.infradead.org; Fri, 18 Aug 2023 03:29:31 +0000 Received: from eig-obgw-6006a.ext.cloudfilter.net ([10.0.30.182]) by cmsmtp with ESMTP id We1nqXag7WU1cWqAyqUqaS; Fri, 18 Aug 2023 03:29:28 +0000 Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with ESMTPS id WqAxqbzZX234eWqAyqONkT; Fri, 18 Aug 2023 03:29:28 +0000 X-Authority-Analysis: v=2.4 cv=cPzzD3SN c=1 sm=1 tr=0 ts=64dee598 a=1YbLdUo/zbTtOZ3uB5T3HA==:117 a=WzbPXH4gqzPVN0x6HrNMNA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=IkcTkHD0fZMA:10 a=UttIx32zK-AA:10 a=wYkD_t78qR0A:10 a=NEAV23lmAAAA:8 a=VwQbUJbxAAAA:8 a=i0EeH86SAAAA:8 a=ag1SF4gXAAAA:8 a=pGLkceISAAAA:8 a=KKAkSRfTAAAA:8 a=cm27Pg_UAAAA:8 a=HvF037n1xESchLcPDVoA:9 a=QEXdDO2ut3YA:10 a=AjGcO6oz07-iQ99wixmX:22 a=Yupwre4RP9_Eg_Bd0iYG:22 a=cvBusfyB2V15izCimMoJ:22 a=xmb-EsYY8bH0VWELuYED:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=embeddedor.com; s=default; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=xjbvOG8NauNugvpOqj5VzY/ZF7EzjNHNjmP6B/aOxVs=; b=GktlTe+To9HeV2kO5WDru79R4Z iPt3hR2DTvbJTAbpAJdiGBR1tHjoxbh2D7yvTwDADE8m7GgshWFJODYMp5erxnU3CLd82EIABjG7H xhyfGfuBMtuTE0dy4NfU3vbLW/Csg9i925fkn76j5Hld2++LwTepnkCwsV2xzyP38l32sknEXMwC4 UgkIZOhlae1+upzO11Jy5u5gRF0eUjjRb97JZ0wdVIj0dvRdL3EHPA6C913q6IsuGjWVzdFtj/+ed SeBHJgNlftyRqD2rnEOWLaV69sY+BL7JTFvbjiZG8nAu4kqCS2hi/09lvgwW3+tVlsjyL1WIdePXl CW5F0a5g==; Received: from 187-162-21-192.static.axtel.net ([187.162.21.192]:41860 helo=[192.168.15.8]) by gator4166.hostgator.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1qWp2c-001FrW-21; Thu, 17 Aug 2023 21:16:46 -0500 Message-ID: <33143205-00db-9ba5-34df-03dbedef3eb8@embeddedor.com> Date: Thu, 17 Aug 2023 20:17:45 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 21/21] dmaengine: usb-dmac: Annotate struct usb_dmac_desc with __counted_by Content-Language: en-US To: Kees Cook , Vinod Koul Cc: Yu Kuai , Greg Kroah-Hartman , Jordy Zomer , Jernej Skrabec , Tudor Ambarus , dmaengine@vger.kernel.org, Hector Martin , Sven Peter , Alyssa Rosenzweig , Ludovic Desroches , Lars-Peter Clausen , Zhou Wang , Jie Hai , Andy Gross , Bjorn Andersson , Konrad Dybcio , Green Wan , Orson Zhai , Baolin Wang , Chunyan Zhang , Patrice Chotard , Maxime Coquelin , Alexandre Torgue , Laxman Dewangan , Jon Hunter , Thierry Reding , Peter Ujfalusi , Kunihiko Hayashi , Masami Hiramatsu , Nathan Chancellor , Nick Desaulniers , Tom Rix , linux-kernel@vger.kernel.org, asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-tegra@vger.kernel.org, llvm@lists.linux.dev, linux-hardening@vger.kernel.org References: <20230817235428.never.111-kees@kernel.org> <20230817235859.49846-21-keescook@chromium.org> From: "Gustavo A. R. Silva" In-Reply-To: <20230817235859.49846-21-keescook@chromium.org> X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - lists.infradead.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 187.162.21.192 X-Source-L: No X-Exim-ID: 1qWp2c-001FrW-21 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 187-162-21-192.static.axtel.net ([192.168.15.8]) [187.162.21.192]:41860 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 0 X-Org: HG=hgshared;ORG=hostgator; X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfF4bc3TvWciwrJzuUpPQtwZF3UHIv2pXBaBJzF620SaZ+vmbT0imX21DfgvCpehkmRPN22eib5BKIplwu1kUNJ6M4zAUyI8KzsrnnvenfE3Cljqq5fnD F2sOYgvegX6BV+0E7Xv5GxfcSJFQPbB36tRcROFnrrC1cAzOgUhEw8hZD8CVfpuagqurxAVIsArvCxKH19Y7dO7A2Ks2g6DzEZvKWHudjeEbVpMfoHvH7Xou X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230817_202930_286428_F33D8B39 X-CRM114-Status: GOOD ( 13.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 8/17/23 17:58, Kees Cook wrote: > Prepare for the coming implementation by GCC and Clang of the __counted_by > attribute. Flexible array members annotated with __counted_by can have > their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS > (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family > functions). > > As found with Coccinelle[1], add __counted_by for struct usb_dmac_desc. > > [1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci > > Cc: Vinod Koul > Cc: Yu Kuai > Cc: Greg Kroah-Hartman > Cc: Jordy Zomer > Cc: Jernej Skrabec > Cc: Tudor Ambarus > Cc: dmaengine@vger.kernel.org > Signed-off-by: Kees Cook Reviewed-by: Gustavo A. R. Silva Thanks -- Gustavo > --- > drivers/dma/sh/usb-dmac.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/dma/sh/usb-dmac.c b/drivers/dma/sh/usb-dmac.c > index b14cf350b669..4cfcd23e3268 100644 > --- a/drivers/dma/sh/usb-dmac.c > +++ b/drivers/dma/sh/usb-dmac.c > @@ -57,7 +57,7 @@ struct usb_dmac_desc { > u32 residue; > struct list_head node; > dma_cookie_t done_cookie; > - struct usb_dmac_sg sg[]; > + struct usb_dmac_sg sg[] __counted_by(sg_allocated_len); > }; > > #define to_usb_dmac_desc(vd) container_of(vd, struct usb_dmac_desc, vd) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel