linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] dt-bindings: phy: imx8mq-usb: correct reference to usb-switch.yaml
@ 2024-11-19 10:50 Xu Yang
  2024-11-21 21:39 ` Rob Herring (Arm)
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Xu Yang @ 2024-11-19 10:50 UTC (permalink / raw)
  To: vkoul, kishon, robh, krzk+dt, conor+dt, shawnguo, s.hauer, kernel,
	festevam, gregkh, jun.li, alexander.stein
  Cc: linux-phy, devicetree, imx, linux-arm-kernel, linux-usb

The i.MX95 usb-phy can work with or without orientation-switch. With
current setting, if usb-phy works without orientation-switch, the
dt-schema check will show below error:

phy@4c1f0040: 'oneOf' conditional failed, one must be fixed:
        'port' is a required property
        'ports' is a required property
        from schema $id: http://devicetree.org/schemas/phy/fsl,imx8mq-usb-phy.yaml#

This will correct the behavior of referring to usb-switch.yaml.

Signed-off-by: Xu Yang <xu.yang_2@nxp.com>

---
v2: remake patch and subject
---
 .../devicetree/bindings/phy/fsl,imx8mq-usb-phy.yaml        | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/Documentation/devicetree/bindings/phy/fsl,imx8mq-usb-phy.yaml b/Documentation/devicetree/bindings/phy/fsl,imx8mq-usb-phy.yaml
index 6d6d211883ae..daee0c0fc915 100644
--- a/Documentation/devicetree/bindings/phy/fsl,imx8mq-usb-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/fsl,imx8mq-usb-phy.yaml
@@ -113,11 +113,8 @@ allOf:
           maxItems: 1
 
   - if:
-      properties:
-        compatible:
-          contains:
-            enum:
-              - fsl,imx95-usb-phy
+      required:
+        - orientation-switch
     then:
       $ref: /schemas/usb/usb-switch.yaml#
 
-- 
2.34.1



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] dt-bindings: phy: imx8mq-usb: correct reference to usb-switch.yaml
  2024-11-19 10:50 [PATCH v2] dt-bindings: phy: imx8mq-usb: correct reference to usb-switch.yaml Xu Yang
@ 2024-11-21 21:39 ` Rob Herring (Arm)
  2024-12-06 10:51 ` Alexander Stein
  2024-12-08 17:02 ` Vinod Koul
  2 siblings, 0 replies; 4+ messages in thread
From: Rob Herring (Arm) @ 2024-11-21 21:39 UTC (permalink / raw)
  To: Xu Yang
  Cc: linux-arm-kernel, festevam, vkoul, alexander.stein, linux-usb,
	jun.li, conor+dt, krzk+dt, kishon, s.hauer, kernel, devicetree,
	imx, linux-phy, gregkh, shawnguo


On Tue, 19 Nov 2024 18:50:17 +0800, Xu Yang wrote:
> The i.MX95 usb-phy can work with or without orientation-switch. With
> current setting, if usb-phy works without orientation-switch, the
> dt-schema check will show below error:
> 
> phy@4c1f0040: 'oneOf' conditional failed, one must be fixed:
>         'port' is a required property
>         'ports' is a required property
>         from schema $id: http://devicetree.org/schemas/phy/fsl,imx8mq-usb-phy.yaml#
> 
> This will correct the behavior of referring to usb-switch.yaml.
> 
> Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
> 
> ---
> v2: remake patch and subject
> ---
>  .../devicetree/bindings/phy/fsl,imx8mq-usb-phy.yaml        | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
> 

Acked-by: Rob Herring (Arm) <robh@kernel.org>



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] dt-bindings: phy: imx8mq-usb: correct reference to usb-switch.yaml
  2024-11-19 10:50 [PATCH v2] dt-bindings: phy: imx8mq-usb: correct reference to usb-switch.yaml Xu Yang
  2024-11-21 21:39 ` Rob Herring (Arm)
@ 2024-12-06 10:51 ` Alexander Stein
  2024-12-08 17:02 ` Vinod Koul
  2 siblings, 0 replies; 4+ messages in thread
From: Alexander Stein @ 2024-12-06 10:51 UTC (permalink / raw)
  To: vkoul, kishon, robh, krzk+dt, conor+dt, shawnguo, s.hauer, kernel,
	festevam, gregkh, jun.li, Xu Yang
  Cc: linux-phy, devicetree, imx, linux-arm-kernel, linux-usb

Am Dienstag, 19. November 2024, 11:50:17 CET schrieb Xu Yang:
> The i.MX95 usb-phy can work with or without orientation-switch. With
> current setting, if usb-phy works without orientation-switch, the
> dt-schema check will show below error:
> 
> phy@4c1f0040: 'oneOf' conditional failed, one must be fixed:
>         'port' is a required property
>         'ports' is a required property
>         from schema $id: http://devicetree.org/schemas/phy/fsl,imx8mq-usb-phy.yaml#
> 
> This will correct the behavior of referring to usb-switch.yaml.
> 
> Signed-off-by: Xu Yang <xu.yang_2@nxp.com>

Acked-by: Alexander Stein <alexander.stein@ew.tq-group.com>

-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/




^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] dt-bindings: phy: imx8mq-usb: correct reference to usb-switch.yaml
  2024-11-19 10:50 [PATCH v2] dt-bindings: phy: imx8mq-usb: correct reference to usb-switch.yaml Xu Yang
  2024-11-21 21:39 ` Rob Herring (Arm)
  2024-12-06 10:51 ` Alexander Stein
@ 2024-12-08 17:02 ` Vinod Koul
  2 siblings, 0 replies; 4+ messages in thread
From: Vinod Koul @ 2024-12-08 17:02 UTC (permalink / raw)
  To: kishon, robh, krzk+dt, conor+dt, shawnguo, s.hauer, kernel,
	festevam, gregkh, jun.li, alexander.stein, Xu Yang
  Cc: linux-phy, devicetree, imx, linux-arm-kernel, linux-usb


On Tue, 19 Nov 2024 18:50:17 +0800, Xu Yang wrote:
> The i.MX95 usb-phy can work with or without orientation-switch. With
> current setting, if usb-phy works without orientation-switch, the
> dt-schema check will show below error:
> 
> phy@4c1f0040: 'oneOf' conditional failed, one must be fixed:
>         'port' is a required property
>         'ports' is a required property
>         from schema $id: http://devicetree.org/schemas/phy/fsl,imx8mq-usb-phy.yaml#
> 
> [...]

Applied, thanks!

[1/1] dt-bindings: phy: imx8mq-usb: correct reference to usb-switch.yaml
      commit: 2318ca5994599bb4d287e9e00ae87e0855cba712

Best regards,
-- 
~Vinod




^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2024-12-08 17:05 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-11-19 10:50 [PATCH v2] dt-bindings: phy: imx8mq-usb: correct reference to usb-switch.yaml Xu Yang
2024-11-21 21:39 ` Rob Herring (Arm)
2024-12-06 10:51 ` Alexander Stein
2024-12-08 17:02 ` Vinod Koul

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).