From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 316B9C27C50 for ; Tue, 4 Jun 2024 01:31:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:Message-ID:In-Reply-To: Subject:cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=hf4bUgSzsQdwSE2OOHhXiDGQb8jQdbgl6RUBa71k7eQ=; b=1HRY8sCRHdRkoTrvIWJyp3oIhA Tysq1qYxrbCfbbMTIK4bOe/1MzH0tPVmDyab2DqIfgiquv0lv4OvNqVj8cWEaRNkVmoVmhMQXQDV+ 85uBULdV+SAECrSi8BZwQxoAOcv85tqWwMZ0wDz8RQZ90sVudSsSKmY3LM7EfYT+reVZennZ+NYvp YLoJayOY0sQUwvZ4TKfhqxKUmWtOMKiA9MFbFledccpSlly2dihMbgl/tHAYtzN6OTVJ+d/T4IbYI 1YL8S0oTNBeQhAEfdV+6Ox4MKPa/4FTk5OJ4rE9DvolFJw58VQNBLtk1UYB6NSSoktNZqmKJOSORg qLo12/Yw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sEJ1C-00000000ovv-1wa5; Tue, 04 Jun 2024 01:31:18 +0000 Received: from gentwo.org ([62.72.0.81]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sEHqc-00000000hZc-465u for linux-arm-kernel@lists.infradead.org; Tue, 04 Jun 2024 00:16:23 +0000 Received: by gentwo.org (Postfix, from userid 1003) id 17FEC40250; Mon, 3 Jun 2024 17:16:13 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by gentwo.org (Postfix) with ESMTP id 16EBC401EF; Mon, 3 Jun 2024 17:16:13 -0700 (PDT) Date: Mon, 3 Jun 2024 17:16:13 -0700 (PDT) From: "Christoph Lameter (Ampere)" To: Matthew Wilcox cc: Shubhang Kaushik OS , "ampere-linux-kernel@lists.amperecomputing.com" , Andrew Morton , Uladzislau Rezki , Christoph Hellwig , Lorenzo Stoakes , "linux-mm@kvack.org" , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2] vmalloc: Modify the alloc_vmap_area() error message for better diagnostics In-Reply-To: Message-ID: <3329c844-509b-8769-01b6-a191b60bee35@linux.com> References: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240603_171619_293984_EABBF4BA X-CRM114-Status: GOOD ( 14.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 4 Jun 2024, Matthew Wilcox wrote: > On Mon, Jun 03, 2024 at 09:30:54PM +0000, Shubhang Kaushik OS wrote: >> 'vmap allocation for size %lu failed: use vmalloc= to increase size' >> The above warning is seen in the kernel functionality for allocation of >> the restricted virtual memory range till exhaustion. >> >> This message is misleading because 'vmalloc=' is not a valid kernel >> parameter on a number of platforms, in particular it is not supported >> on arm64. With the update, the output gets modified to include the function > > Why not fix arm64? Arm64 does not need vmalloc= tuning and the problem is not related to being out of vmalloc space in general. This occurs if the virtual range during a vmalloc was restricted and is not available (f.e. if one wants a module to be loaded in optimal branch distance to the kernel text segment and we loaded too many modules). The error message needs to indicate the virtual memory restriction which helps the developer/user to debug the situation and not create a wild goose chase for a kernel parmaeter that does not exist. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel