From: David Hildenbrand <david@redhat.com>
To: Dev Jain <dev.jain@arm.com>, catalin.marinas@arm.com, will@kernel.org
Cc: ryan.roberts@arm.com, anshuman.khandual@arm.com,
mark.rutland@arm.com, yang@os.amperecomputing.com,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, stable@vger.kernel.org
Subject: Re: [PATCH] arm64: Check pxd_leaf() instead of !pxd_table() while tearing down page tables
Date: Thu, 15 May 2025 10:13:31 +0200 [thread overview]
Message-ID: <332ecda7-14c4-4dc3-aeff-26801b74ca04@redhat.com> (raw)
In-Reply-To: <20250515063450.86629-1-dev.jain@arm.com>
On 15.05.25 08:34, Dev Jain wrote:
> Commit 9c006972c3fe removes the pxd_present() checks because the caller
> checks pxd_present(). But, in case of vmap_try_huge_pud(), the caller only
> checks pud_present(); pud_free_pmd_page() recurses on each pmd through
> pmd_free_pte_page(), wherein the pmd may be none.
The commit states: "The core code already has a check for pXd_none()",
so I assume that assumption was not true in all cases?
Should that one problematic caller then check for pmd_none() instead?
If you were able to trigger this WARN, it's always a good idea to
include the splat in the commit.
--
Cheers,
David / dhildenb
next prev parent reply other threads:[~2025-05-15 8:23 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-15 6:34 [PATCH] arm64: Check pxd_leaf() instead of !pxd_table() while tearing down page tables Dev Jain
2025-05-15 8:13 ` David Hildenbrand [this message]
2025-05-15 8:22 ` Dev Jain
2025-05-15 8:36 ` David Hildenbrand
2025-05-15 8:40 ` Dev Jain
2025-05-15 8:49 ` David Hildenbrand
2025-05-15 8:47 ` Dev Jain
2025-05-15 8:53 ` David Hildenbrand
2025-05-15 9:27 ` Dev Jain
2025-05-15 9:32 ` David Hildenbrand
2025-05-15 12:56 ` Will Deacon
2025-05-15 13:04 ` David Hildenbrand
2025-05-15 13:21 ` Will Deacon
2025-05-15 10:07 ` Ryan Roberts
2025-05-15 13:01 ` David Hildenbrand
2025-05-15 13:14 ` Ryan Roberts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=332ecda7-14c4-4dc3-aeff-26801b74ca04@redhat.com \
--to=david@redhat.com \
--cc=anshuman.khandual@arm.com \
--cc=catalin.marinas@arm.com \
--cc=dev.jain@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=ryan.roberts@arm.com \
--cc=stable@vger.kernel.org \
--cc=will@kernel.org \
--cc=yang@os.amperecomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).