From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [GIT PULL] Broadcom SoC changes for 4.2
Date: Wed, 20 May 2015 22:59:12 +0200 [thread overview]
Message-ID: <3339528.zIO9EH4AJz@wuerfel> (raw)
In-Reply-To: <1431556453-11633-3-git-send-email-f.fainelli@gmail.com>
On Wednesday 13 May 2015 15:34:13 Florian Fainelli wrote:
> arch/arm/include/asm/vfp.h | 9 ++
> arch/arm/mach-bcm/Makefile | 7 +-
> arch/arm/mach-bcm/bcm63xx_headsmp.S | 23 ++++
> arch/arm/mach-bcm/bcm63xx_pmb.c | 221 ++++++++++++++++++++++++++++++++++++
> arch/arm/mach-bcm/bcm63xx_smp.c | 170 +++++++++++++++++++++++++++
> arch/arm/mach-bcm/bcm63xx_smp.h | 9 ++
> arch/arm/vfp/vfpmodule.c | 13 +++
> include/linux/bcm63xx_pmb.h | 76 +++++++++++++
>
And taken out again, sorry.
I got a build error in include/linux/bcm63xx_pmb.h and that triggered me to take
a closer look. I tried to fix up the trivial error first, but then noticed
several other things wrong with bcm63xx_pmb.h:
- it is in include/linux/ where it clearly does not belong, as no other component
should be including it. Even the function documentation in there mentions that
one must hold the pmb_lock before calling it, and that is defined statically
arch/arm/mach-bcm/bcm63xx_pmb.c, so it's impossible for other code to use.
Just move it all into bcm63xx_pmb.c.
- the code uses __raw_readl/__raw_writel for MMIO register access, which is
broken on big-endian machines. You need to use readl_relaxed()/write_relaxed()
or readl()/writel() instead. If you use the latter, you can also avoid
introducing extra barriers.
- finally, a heads-up for the "[PATCH] ARM: v7 setup function should invalidate
L1 cache" patch that Russell submitted. I think your bcm63xx_headsmp.S
function is completely fine for now, but with his patch applied, it will
no longer be needed and you should follow up with a patch to replace it
with a direct branch to secondary_startup.
Arnd
next prev parent reply other threads:[~2015-05-20 20:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-13 22:34 [GIT PULL] Broadcom Device Tree changes for 4.2 Florian Fainelli
2015-05-13 22:34 ` [GIT PULL] Broadcom MAINTAINERS file update " Florian Fainelli
2015-05-20 15:44 ` Arnd Bergmann
2015-05-13 22:34 ` [GIT PULL] Broadcom SoC changes " Florian Fainelli
2015-05-20 15:42 ` Arnd Bergmann
2015-05-20 15:43 ` Arnd Bergmann
2015-05-20 20:59 ` Arnd Bergmann [this message]
2015-05-20 21:05 ` Florian Fainelli
2015-05-20 21:22 ` Arnd Bergmann
2015-05-20 21:50 ` Florian Fainelli
2015-05-20 22:02 ` Arnd Bergmann
2015-05-15 15:18 ` [GIT PULL] Broadcom Device Tree " Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3339528.zIO9EH4AJz@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox