From: Krzysztof Kozlowski <krzk@kernel.org>
To: Peter Chen <peter.chen@cixtech.com>,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de
Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, cix-kernel-upstream@cixtech.com,
marcin@juszkiewicz.com.pl, Fugang Duan <fugang.duan@cixtech.com>
Subject: Re: [PATCH v2 6/6] arm64: dts: cix: add initial CIX P1(SKY1) dts support
Date: Wed, 26 Feb 2025 08:05:29 +0100 [thread overview]
Message-ID: <33504452-6326-4403-95e1-fef40f3fb49e@kernel.org> (raw)
In-Reply-To: <20250226012136.854614-7-peter.chen@cixtech.com>
On 26/02/2025 02:21, Peter Chen wrote:
> + core7 {
> + cpu = <&cpu7>;
> + };
> + core8 {
> + cpu = <&cpu8>;
> + };
> + core9 {
> + cpu = <&cpu9>;
> + };
> + core10 {
> + cpu = <&cpu10>;
> + };
> + core11 {
> + cpu = <&cpu11>;
> + };
> + };
> + };
> +
Stray blank line
> + };
> +
> + pmu-a520 {
> + compatible = "arm,cortex-a520-pmu";
> + interrupts = <GIC_PPI 7 IRQ_TYPE_LEVEL_LOW>;
> + };
> +
> + pmu-a720 {
> + compatible = "arm,cortex-a720-pmu";
> + interrupts = <GIC_PPI 7 IRQ_TYPE_LEVEL_LOW>;
> + };
> +
> + pmu-spe {
> + compatible = "arm,statistical-profiling-extension-v1";
> + interrupts = <GIC_PPI 5 IRQ_TYPE_LEVEL_LOW>;
> + };
> +
> + psci {
> + compatible = "arm,psci-1.0";
> + method = "smc";
> + };
> +
> + soc@0 {
> + compatible = "simple-bus";
> + #address-cells = <2>;
> + #size-cells = <2>;
> + ranges = <0 0 0 0 0x20 0>;
Ranges is like reg, so after compatible. See DTS coding style.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-02-26 7:13 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-26 1:21 [PATCH v2 0/6] arm64: Introduce CIX P1 (SKY1) SoC Peter Chen
2025-02-26 1:21 ` [PATCH v2 1/6] dt-bindings: vendor-prefixes: Add CIX Technology Group Co., Ltd Peter Chen
2025-02-26 7:02 ` Krzysztof Kozlowski
2025-02-26 10:31 ` Krzysztof Kozlowski
2025-02-26 1:21 ` [PATCH v2 2/6] dt-bindings: arm: add CIX P1 (SKY1) SoC Peter Chen
2025-02-26 7:02 ` Krzysztof Kozlowski
2025-02-26 8:09 ` Peter Chen
2025-02-26 8:40 ` Krzysztof Kozlowski
2025-02-26 10:26 ` Peter Chen
2025-02-26 10:30 ` Krzysztof Kozlowski
2025-02-26 12:59 ` Peter Chen
2025-02-26 1:21 ` [PATCH v2 3/6] MAINTAINERS: Add CIX SoC maintainer entry Peter Chen
2025-02-26 1:21 ` [PATCH v2 4/6] arm64: Kconfig: add ARCH_CIX for cix silicons Peter Chen
2025-02-26 1:21 ` [PATCH v2 5/6] arm64: defconfig: Enable CIX SoC Peter Chen
2025-02-26 1:21 ` [PATCH v2 6/6] arm64: dts: cix: add initial CIX P1(SKY1) dts support Peter Chen
2025-02-26 7:05 ` Krzysztof Kozlowski [this message]
2025-02-27 4:52 ` [PATCH v2 0/6] arm64: Introduce CIX P1 (SKY1) SoC Jianfeng Liu
2025-02-27 8:02 ` Peter Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33504452-6326-4403-95e1-fef40f3fb49e@kernel.org \
--to=krzk@kernel.org \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=cix-kernel-upstream@cixtech.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fugang.duan@cixtech.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcin@juszkiewicz.com.pl \
--cc=peter.chen@cixtech.com \
--cc=robh@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).