From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E6E4BC433EF for ; Tue, 10 May 2022 14:09:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9m3feFYQykX8ZwCYy1JgE2N27iIspXj/eRi0bXsvSFA=; b=xNNCjf0YE+pvTq Ep0NFJ5HqJha4PBp8ZWGnacNLL/pNvuNOka8F9HXvO5v5eGAtU7k0R8Iehjd6N57KpCRAl50wKwKx TESErewSk7CS1Dt2/PSjZdE3EhXyVl62OT6z+AY2e/mZwdUtltuJLoHi0bVosnYta2VijUTJ9FYku n6hNmeafy+LPVujMcHEWh2LQrHf6fsvZDHBneqGsMwOHpBB27SiHXFJokppVI4c7+VAyuAhoSntaz FLGJ/+cqQx92cYmJe+B0G/Qz+MwcAxHIG0JPSO3eZM73Qzh5nrSYXfyQeDVNqV9rQiJv+ldbigl05 tOznhpog32nJLGoUrmbA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1noQX9-002Qjw-UQ; Tue, 10 May 2022 14:08:16 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1noQX5-002QhY-KS; Tue, 10 May 2022 14:08:12 +0000 Received: from ip5b412258.dynamic.kabel-deutschland.de ([91.65.34.88] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1noQWz-00057J-J3; Tue, 10 May 2022 16:08:05 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: dri-devel@lists.freedesktop.org, Sascha Hauer Cc: linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, kernel@pengutronix.de, Andy Yan , Benjamin Gaignard , Michael Riesch , Sandy Huang , Peter Geis , Sascha Hauer , krzk+dt@kernel.org, robh+dt@kernel.org Subject: Re: [PATCH 1/3] dt-bindings: display: rockchip: make reg-names mandatory for VOP2 Date: Tue, 10 May 2022 16:08:02 +0200 Message-ID: <3353209.QJadu78ljV@diego> In-Reply-To: <20220510070914.2346011-2-s.hauer@pengutronix.de> References: <20220510070914.2346011-1-s.hauer@pengutronix.de> <20220510070914.2346011-2-s.hauer@pengutronix.de> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220510_070811_678762_270A002A X-CRM114-Status: GOOD ( 19.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Sascha, Am Dienstag, 10. Mai 2022, 09:09:12 CEST schrieb Sascha Hauer: > The VOP2 driver relies on reg-names properties, but these are not > documented. Add the missing documentation, make reg-names mandatory > and increase minItems to 2 as always both register spaces are needed. > > Signed-off-by: Sascha Hauer I'm not sure how the DT-people work - if they only track the devicetree list or their x+dt@kernel.org accounts or some mixture, but the patch was missing the maintainer email addresses - I've added them here now :-) . The change looks good to me and as I merged the original binding into drm-misc only some days ago, we also don't have a backwards- compat issue yet, so hopefully DT-people will think similarly . Heiko > --- > .../bindings/display/rockchip/rockchip-vop2.yaml | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml > index 655d9b327f7d3..7238cdec9eb8a 100644 > --- a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml > +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml > @@ -22,7 +22,7 @@ properties: > - rockchip,rk3568-vop > > reg: > - minItems: 1 > + minItems: 2 > items: > - description: > Must contain one entry corresponding to the base address and length > @@ -31,6 +31,11 @@ properties: > Can optionally contain a second entry corresponding to > the CRTC gamma LUT address. > > + reg-names: > + items: > + - const: vop > + - const: gamma-lut > + > interrupts: > maxItems: 1 > description: > @@ -86,6 +91,7 @@ properties: > required: > - compatible > - reg > + - reg-names > - interrupts > - clocks > - clock-names > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel