From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: mm: cpu_fa526_do_idle: remove WFI
Date: Mon, 17 Jun 2013 17:01:47 +0200 [thread overview]
Message-ID: <3363106.HfAWgJLKER@wuerfel> (raw)
In-Reply-To: <CACmBeS3_aqf42sCKeO9TNJSkOPYwvyAXOvYKjrU8_jV6yAKQ-g@mail.gmail.com>
On Monday 17 June 2013 16:58:14 Jonas Jensen wrote:
> On 17 June 2013 16:30, Russell King - ARM Linux <linux@arm.linux.org.uk> wrote:
> > It replaces the WFI and return with a pure nop, so we will fall through
> > to cpu_fa526_dcache_clean_area(). Do we really want to clean a random
> > D cache entry depending on what r0 happened to hold at this point? I
> > think not...
>
> I'm sorry for making the assumption that I know even the most basic
> ARM assembler...
>
> This is not the sort of thing I deal with (and probably shouldn't) on
> a daily basis.
>
> Can I make a guess, remove only mcr and replace it with nop?
No need for the nop, just remove the mcr instruction.
Arnd
next prev parent reply other threads:[~2013-06-17 15:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-17 13:39 [PATCH] ARM: mm: cpu_fa526_do_idle: remove WFI Jonas Jensen
2013-06-17 14:14 ` Arnd Bergmann
2013-06-17 14:30 ` Russell King - ARM Linux
2013-06-17 14:58 ` Jonas Jensen
2013-06-17 15:01 ` Arnd Bergmann [this message]
2013-06-17 15:07 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3363106.HfAWgJLKER@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox