From: Jens Axboe <axboe@kernel.dk>
To: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>,
linux-block@vger.kernel.org, linux-nvme@lists.infradead.org,
Keith Busch <kbusch@kernel.org>,
Christoph Hellwig <hch@infradead.org>,
Sagi Grimberg <sagi@grimberg.me>,
Alan Adamson <alan.adamson@oracle.com>
Cc: virtualization@lists.linux.dev, asahi@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
"Hannes Reinecke" <hare@suse.de>,
"Michael S . Tsirkin" <mst@redhat.com>,
"Jason Wang" <jasowang@redhat.com>,
"Xuan Zhuo" <xuanzhuo@linux.alibaba.com>,
"Eugenio Pérez" <eperezma@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Sven Peter" <sven@svenpeter.dev>, "Janne Grunau" <j@jannau.net>,
"Alyssa Rosenzweig" <alyssa@rosenzweig.io>
Subject: Re: [PATCH v2 0/2] block: nvme: fix blktests nvme/039 failure
Date: Tue, 11 Mar 2025 07:49:25 -0600 [thread overview]
Message-ID: <3369329c-13ac-4b18-9923-1a24e1243035@kernel.dk> (raw)
In-Reply-To: <20250311104359.1767728-1-shinichiro.kawasaki@wdc.com>
On 3/11/25 4:43 AM, Shin'ichiro Kawasaki wrote:
> Commit 1f47ed294a2b ("block: cleanup and fix batch completion adding
> conditions") in the kernel tag v6.14-rc3 triggered blktests nvme/039
> failure [1].
>
> The test case injects errors to the NVMe driver and confirms the errors
> are logged. The first half of the test checks it for non-passthrough
> requests, and the second half checks for passthrough requests. The
> commit made both halves fail.
>
> This series addresses the test case failure. The first patch covers the
> passthrough requests, and the second patch covers the non-passthrough
> requests.
Looks good to me, and better than the quick fix-up for the problem.
Thanks for taking the time to do it right!
--
Jens Axboe
next prev parent reply other threads:[~2025-03-11 13:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-11 10:43 [PATCH v2 0/2] block: nvme: fix blktests nvme/039 failure Shin'ichiro Kawasaki
2025-03-11 10:43 ` [PATCH v2 1/2] nvme: move error logging from nvme_end_req() to __nvme_end_req() Shin'ichiro Kawasaki
2025-03-11 10:43 ` [PATCH v2 2/2] block: change blk_mq_add_to_batch() third argument type to bool Shin'ichiro Kawasaki
2025-03-12 5:59 ` Christoph Hellwig
2025-03-12 7:20 ` Shinichiro Kawasaki
2025-03-11 13:49 ` Jens Axboe [this message]
2025-03-11 13:50 ` [PATCH v2 0/2] block: nvme: fix blktests nvme/039 failure Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3369329c-13ac-4b18-9923-1a24e1243035@kernel.dk \
--to=axboe@kernel.dk \
--cc=alan.adamson@oracle.com \
--cc=alyssa@rosenzweig.io \
--cc=asahi@lists.linux.dev \
--cc=eperezma@redhat.com \
--cc=hare@suse.de \
--cc=hch@infradead.org \
--cc=j@jannau.net \
--cc=jasowang@redhat.com \
--cc=kbusch@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=sagi@grimberg.me \
--cc=shinichiro.kawasaki@wdc.com \
--cc=stefanha@redhat.com \
--cc=sven@svenpeter.dev \
--cc=virtualization@lists.linux.dev \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox