From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A9AE9C54EDA for ; Wed, 28 Aug 2024 11:22:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:CC:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=xzFWpXX3dL3DQntr9YWxkl8GFz7PXCpjFoJgnAfZVXU=; b=oUp/xKksK+H4uRSuguO4Nyj6on Yl5wxoRPnvL//3grwP7BF+CLTpsv/3u1TQcvLe910YRmd0k7AV58PQXTTx6T94N/VNRhDtFLavhZd bHFzkvt4uZkCN+yonkJIlKXirG7UTvmhjfUcTXWO0KoGu0Wdli6dbdLXErCY6HTgg0bDhskfLv5AO 0AMKMHwT/XNyzdo4+3hCNkLd7IokhuSqbe0ZA3B2JaylRFtZ6X+hlGpNJhsNVAmw88MggyxUFxGXf ayzGPblNvV+F1MbJ2RbpyOz1Gu3M/I4S34PWzE+lll1ejC4zV+W0MEER9i8YRcatqO2lZL+8TIwDl fEmIBSnA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sjGkv-0000000F7jB-0FFd; Wed, 28 Aug 2024 11:22:29 +0000 Received: from lelv0142.ext.ti.com ([198.47.23.249]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sjGk4-0000000F7Sa-0Jn0 for linux-arm-kernel@lists.infradead.org; Wed, 28 Aug 2024 11:21:37 +0000 Received: from lelv0265.itg.ti.com ([10.180.67.224]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id 47SBLURm062818; Wed, 28 Aug 2024 06:21:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1724844090; bh=xzFWpXX3dL3DQntr9YWxkl8GFz7PXCpjFoJgnAfZVXU=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=MQPKftsU9t6HWD5rreAwsuetRBbRfeuoG05LSQZhRZ+yRLTZNaBGXBQUpNuckmULv v7n6NDhy1P6YrWq0YI71kCFcpN6QMZaTqwgpPa+EaAVVVCHH7mURIcnuxKH0QDxpet 0XgrT8xOdwRRtdCPQhiuJQRcpjX4hldPTlu/JSn8= Received: from DFLE115.ent.ti.com (dfle115.ent.ti.com [10.64.6.36]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 47SBLU0i004569 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 28 Aug 2024 06:21:30 -0500 Received: from DFLE101.ent.ti.com (10.64.6.22) by DFLE115.ent.ti.com (10.64.6.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Wed, 28 Aug 2024 06:21:30 -0500 Received: from lelvsmtp6.itg.ti.com (10.180.75.249) by DFLE101.ent.ti.com (10.64.6.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Wed, 28 Aug 2024 06:21:30 -0500 Received: from [172.24.227.241] (santhoshkumark.dhcp.ti.com [172.24.227.241]) by lelvsmtp6.itg.ti.com (8.15.2/8.15.2) with ESMTP id 47SBLQqX129508; Wed, 28 Aug 2024 06:21:27 -0500 Message-ID: <336c415f-eeff-4220-86e0-e7a8043d6530@ti.com> Date: Wed, 28 Aug 2024 16:51:25 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/4] arm64: dts: ti: k3-am65: Include entire FSS region in ranges To: Andrew Davis , Nishanth Menon , Vignesh Raghavendra , Tero Kristo , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jonathan Humphreys CC: , , References: <20240801174941.41002-1-afd@ti.com> <20240801174941.41002-2-afd@ti.com> Content-Language: en-US From: Santhosh Kumar K In-Reply-To: <20240801174941.41002-2-afd@ti.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240828_042136_239380_955D3463 X-CRM114-Status: GOOD ( 17.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Andrew, Thanks for the series! On 01/08/24 23:19, Andrew Davis wrote: > Add FSS regions at 0x50000000, 0x400000000, and 0x600000000. Although > not used currently by the Linux FSS driver, these regions belong to > the FSS and should be included in the ranges mapping. > > While here, a couple of these numbers had missing zeros which was > hidden by odd alignments, fix both these issues. > > Signed-off-by: Andrew Davis > --- > arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi | 8 ++++---- > arch/arm64/boot/dts/ti/k3-am65.dtsi | 13 ++++++------- > 2 files changed, 10 insertions(+), 11 deletions(-) > > diff --git a/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi b/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi > index 43c6118d2bf0f..5948ab3b50fc2 100644 > --- a/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi > @@ -292,13 +292,13 @@ fss: bus@47000000 { > ranges = <0x0 0x47000000 0x0 0x47000000 0x0 0x100>, /* FSS Control */ > <0x0 0x47040000 0x0 0x47040000 0x0 0x100>, /* OSPI0 Control */ > <0x0 0x47050000 0x0 0x47050000 0x0 0x100>, /* OSPI1 Control */ > - <0x5 0x00000000 0x5 0x00000000 0x1 0x0000000>, /* OSPI0 Memory */ > - <0x7 0x00000000 0x7 0x00000000 0x1 0x0000000>; /* OSPI1 Memory */ > + <0x0 0x50000000 0x0 0x50000000 0x0 0x10000000>, /* OSPI0/1 Memory 1 */ > + <0x4 0x00000000 0x4 0x00000000 0x4 0x00000000>; /* OSPI0/1 Memory 0/3 */ > > ospi0: spi@47040000 { > compatible = "ti,am654-ospi", "cdns,qspi-nor"; > reg = <0x0 0x47040000 0x0 0x100>, > - <0x5 0x00000000 0x1 0x0000000>; > + <0x5 0x00000000 0x1 0x00000000>; > interrupts = ; > cdns,fifo-depth = <256>; > cdns,fifo-width = <4>; > @@ -316,7 +316,7 @@ ospi0: spi@47040000 { > ospi1: spi@47050000 { > compatible = "ti,am654-ospi", "cdns,qspi-nor"; > reg = <0x0 0x47050000 0x0 0x100>, > - <0x7 0x00000000 0x1 0x00000000>; > + <0x7 0x00000000 0x1 0x00000000>; > interrupts = ; > cdns,fifo-depth = <256>; > cdns,fifo-width = <4>; > diff --git a/arch/arm64/boot/dts/ti/k3-am65.dtsi b/arch/arm64/boot/dts/ti/k3-am65.dtsi > index c59baebc5a25b..5b8cbdd6942e7 100644 > --- a/arch/arm64/boot/dts/ti/k3-am65.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-am65.dtsi > @@ -69,11 +69,11 @@ cbass_main: bus@100000 { > <0x00 0x45100000 0x00 0x45100000 0x00 0x00c24000>, > <0x00 0x46000000 0x00 0x46000000 0x00 0x00200000>, > <0x00 0x47000000 0x00 0x47000000 0x00 0x00068400>, > - <0x00 0x50000000 0x00 0x50000000 0x00 0x8000000>, > + <0x00 0x50000000 0x00 0x50000000 0x00 0x10000000>, > <0x00 0x6f000000 0x00 0x6f000000 0x00 0x00310000>, /* A53 PERIPHBASE */ > - <0x00 0x70000000 0x00 0x70000000 0x00 0x200000>, > - <0x05 0x00000000 0x05 0x00000000 0x01 0x0000000>, > - <0x07 0x00000000 0x07 0x00000000 0x01 0x0000000>; > + <0x00 0x70000000 0x00 0x70000000 0x00 0x00200000>, > + <0x05 0x00000000 0x05 0x00000000 0x01 0x00000000>, > + <0x07 0x00000000 0x07 0x00000000 0x01 0x00000000>; The changes you made to merge the 'FSS Data Region' range in 'cbass_mcu' node is not reflected here. Can you please add those changes here, so that the ranges looks consistent throughout. Apart from this, the series LGTM! Reviewed-by: Santhosh Kumar K > > cbass_mcu: bus@28380000 { > compatible = "simple-bus"; > @@ -89,9 +89,8 @@ cbass_mcu: bus@28380000 { > <0x00 0x45100000 0x00 0x45100000 0x00 0x00c24000>, /* MMRs, remaining NAVSS */ > <0x00 0x46000000 0x00 0x46000000 0x00 0x00200000>, /* CPSW */ > <0x00 0x47000000 0x00 0x47000000 0x00 0x00068400>, /* OSPI space 1 */ > - <0x00 0x50000000 0x00 0x50000000 0x00 0x8000000>, /* FSS OSPI0 data region 1 */ > - <0x05 0x00000000 0x05 0x00000000 0x01 0x0000000>, /* FSS OSPI0 data region 3*/ > - <0x07 0x00000000 0x07 0x00000000 0x01 0x0000000>; /* FSS OSPI1 data region 3*/ > + <0x00 0x50000000 0x00 0x50000000 0x00 0x10000000>, /* FSS Data Region 1 */ > + <0x04 0x00000000 0x04 0x00000000 0x04 0x00000000>; /* FSS Data Region 0/3 */ > > cbass_wakeup: bus@42040000 { > compatible = "simple-bus";