From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 39F10C47DAF for ; Mon, 22 Jan 2024 13:10:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/hBfbqwlIzKVBKxirVztIjKHibcQCM7iCigdYNVI2y4=; b=ilBoWJR2c9Dli4 xUpwJq8143ANiALEfOJ+4nbu+KebG+P9W74IgkUYyyI6dLkLZ79/BRNFL93jTkeRN/ln3XmeCKuPN 0kIh2rJb+q1mXF99GIdCFxG1auhnuk9X4YGi9nNvVvAmx90n4AtfOdH3z2xrGHaJrOqlIXjEW8IcI KabTa4NZeWjjMiDE24PSLrmxi+ZWdHVADT6lQR9RSqwmbwtVcS6KeHUWOG8FURH9bygJqW9rYebGD nXmL+wJefDJha7OQBaaibo17wxyAAh6pdQssvi2cXoJM0Z9bCJJHXewDjSi65g9l7b4l0H5/Gauv1 BcWi3kLLVSufGOeAKLJw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rRu3i-00CEVh-21; Mon, 22 Jan 2024 13:09:50 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rRu3e-00CETd-2W; Mon, 22 Jan 2024 13:09:49 +0000 Received: from i53875b8c.versanet.de ([83.135.91.140] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rRu3Z-00053L-9z; Mon, 22 Jan 2024 14:09:41 +0100 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" , "conor+dt@kernel.org" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-rockchip@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Iskander Amara Cc: Quentin Schulz Subject: Re: [PATCH v2] arm64: dts: rockchip: add missing definition of pmu io domains 1 and 2 on ringneck Date: Mon, 22 Jan 2024 14:09:40 +0100 Message-ID: <3388688.6M6d0yLqnL@diego> In-Reply-To: References: <20240103164734.1151290-1-iskander.amara@theobroma-systems.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240122_050946_817448_086766FF X-CRM114-Status: GOOD ( 22.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Iskander, Am Montag, 22. Januar 2024, 13:17:50 CET schrieb Iskander Amara: > Dear Ladies and Gentlemen, > Is there any feedback about the patch below that you would like to share? no feedback, change looks good. I was mainly waiting for the merge-window to close, so that I can get a nice 6.8-rc1 as base :-) Heiko > ________________________________ > From: Iskander Amara > Sent: Wednesday, January 3, 2024 5:47 PM > To: robh+dt@kernel.org ; krzysztof.kozlowski+dt@linaro.org ; conor+dt@kernel.org ; heiko@sntech.de ; devicetree@vger.kernel.org ; linux-arm-kernel@lists.infradead.org ; linux-rockchip@lists.infradead.org ; linux-kernel@vger.kernel.org > Cc: Quentin Schulz ; Iskander Amara > Subject: [PATCH v2] arm64: dts: rockchip: add missing definition of pmu io domains 1 and 2 on ringneck > > Two pmuio domains on ringneck are not defined: > 1- PMUIO1: supplied by vcc_3v3 regulator(PMIC RK809) > 2- PMUIO2: supplied by vcc_3v3 regulator(PMIC RK809) > > The reason why no functional effect was observed is because of that > the above mentionned PMUIO domains were supplied by a regulator > which is always on. > > So let's add their definition in the dtsi. > > Signed-off-by: Iskander Amara > --- > v2: > - Fix indentation > arch/arm64/boot/dts/rockchip/px30-ringneck.dtsi | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/arch/arm64/boot/dts/rockchip/px30-ringneck.dtsi b/arch/arm64/boot/dts/rockchip/px30-ringneck.dtsi > index 12397755830b..bb1aea82e666 100644 > --- a/arch/arm64/boot/dts/rockchip/px30-ringneck.dtsi > +++ b/arch/arm64/boot/dts/rockchip/px30-ringneck.dtsi > @@ -347,6 +347,12 @@ pmic_int: pmic-int { > }; > }; > > +&pmu_io_domains { > + pmuio1-supply = <&vcc_3v3>; > + pmuio2-supply = <&vcc_3v3>; > + status = "okay"; > +}; > + > &saradc { > vref-supply = <&vcc_1v8>; > status = "okay"; > -- > 2.34.1 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel