From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C3966C48BF6 for ; Mon, 4 Mar 2024 11:12:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Subject:Cc:To:From:Date:References: In-Reply-To:Message-Id:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TYTuJam3e0Fe084ePmms/1JRLmAHw9rovWewnG2zSPA=; b=FmvJNu9UaVnX68 hTtZpF4B2pYpu1RzSrCq7noY1kxInRKPkhrSyOtYyIp+iSczTpBnu6MOeSFRulF5LxcxahwvhhFtP 7IbojDB85O4o772yMWonBdW+ZUb5Y7VscIlMBMR72aFw0KZY5HqFU5swDmcnkwoTm4jlI29iazWbU AnXxV3s1K3AQmUTNje+9wgcgweNBxetcogrwMwF4dVffMFkpqqs3/ngzXKzJhNnzg8qxGSmsA9iEb PtamNDmNCUk90uFm3Qvuhtnj9Y/8JuVLrmKtenP6fWFDqR799OjieaaXep5g3CVR9yryqPU1BXYtN bqbdbci2TsENHayLH30Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rh6Es-00000008lVW-0CQk; Mon, 04 Mar 2024 11:12:10 +0000 Received: from wfhigh1-smtp.messagingengine.com ([64.147.123.152]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rh6Eo-00000008lSA-3VZw for linux-arm-kernel@lists.infradead.org; Mon, 04 Mar 2024 11:12:09 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailfhigh.west.internal (Postfix) with ESMTP id E81031800071; Mon, 4 Mar 2024 06:11:58 -0500 (EST) Received: from imap51 ([10.202.2.101]) by compute5.internal (MEProxy); Mon, 04 Mar 2024 06:12:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm3; t=1709550718; x=1709637118; bh=EdyAyreUFv IgIM6ctI+YdhHOhoypCpmrpuxvB1wsxPs=; b=yvc3lv5Wisgl69XprFcP5LoTvy xOnR8ClrH2/ISMMCpe99Rj5lDH/mge/sdO8Q75eVh6ydyXO57A8YdnKv0uzyNUpx 7PG4TgXn9G9Me+kcKeAg/kPyZr20lkoE8Ge2PDZ0m0vvsssQX1uqCDBCVnQs4W3N +wgnEzVauN3lLU7jf3CzxfNawof7guszJvZe02DYntMXlHpJG/yx1gvxsW0MT+bi pFCPkfYc/KicROYhNZTnDHnP0uSUmy0/PfwLLpfzUh7P2YlatkXUsXudhqlkpChJ NJjNqcyyoT6eqOCj46xFzfMY95lfa2hGbbCYGgVdNFVwICTdfRAsOEXX3fow== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1709550718; x=1709637118; bh=EdyAyreUFvIgIM6ctI+YdhHOhoyp CpmrpuxvB1wsxPs=; b=MGCCBcZGWn6rAsXfzV4j1gaxH0Y2kffQfmDiJk8KF2GP EoRo+xLTsXklU/QyL43TRHXVU3SdQGqau0Rw5/qC119H4DCDVvVHLYeAd2gXEYLR XrJ067icxcSWRPBom4IlHWcjm0D5NawrA6H95J7ayq2qt/IK0YGlIMhvAaZhEmvL zH2SsDruheTp8pljRm3f5HlFGH2k+U/Ah83zjcr6TA/mTqfE4wAMl+K3gjLf5Qo8 Jjdn9wlSnOZnr4M4Nr2lwIPZV4uOzRYDpvz/AbTEHtD1q0Unu6kzTPS4Q+bnc29k +C4K8CTyxFoPau/lJun7a4c9COVbpR7XBoxJUJWQkQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrheejgddvgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefofgggkfgjfhffhffvvefutgesthdtredtreertdenucfhrhhomhepfdetrhhn ugcuuegvrhhgmhgrnhhnfdcuoegrrhhnugesrghrnhgusgdruggvqeenucggtffrrghtth gvrhhnpeffheeugeetiefhgeethfejgfdtuefggeejleehjeeutefhfeeggefhkedtkeet ffenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrrh hnugesrghrnhgusgdruggv X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 1DB36B6008D; Mon, 4 Mar 2024 06:11:58 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.11.0-alpha0-205-g4dbcac4545-fm-20240301.001-g4dbcac45 MIME-Version: 1.0 Message-Id: <338c89bb-a70b-4f35-b71b-f974e90e3383@app.fastmail.com> In-Reply-To: References: Date: Mon, 04 Mar 2024 12:11:36 +0100 From: "Arnd Bergmann" To: "Naresh Kamboju" , "open list" , "Linux ARM" , linux-sunxi@lists.linux.dev, dri-devel@lists.freedesktop.org, lkft-triage@lists.linaro.org Cc: "Maxime Ripard" , "Dave Airlie" , "Dan Carpenter" , "Ard Biesheuvel" Subject: Re: arm: ERROR: modpost: "__aeabi_uldivmod" [drivers/gpu/drm/sun4i/sun4i-drm-hdmi.ko] undefined! X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240304_031206_964292_1818BA11 X-CRM114-Status: UNSURE ( 8.22 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Mar 4, 2024, at 09:07, Naresh Kamboju wrote: > The arm defconfig builds failed on today's Linux next tag next-20240304. > > Build log: > --------- > ERROR: modpost: "__aeabi_uldivmod" > [drivers/gpu/drm/sun4i/sun4i-drm-hdmi.ko] undefined! > Apparently caused by the 64-bit division in 358e76fd613a ("drm/sun4i: hdmi: Consolidate atomic_check and mode_valid"): +static enum drm_mode_status +sun4i_hdmi_connector_clock_valid(const struct drm_connector *connector, + const struct drm_display_mode *mode, + unsigned long long clock) { - struct sun4i_hdmi *hdmi = drm_encoder_to_sun4i_hdmi(encoder); - unsigned long rate = mode->clock * 1000; - unsigned long diff = rate / 200; /* +-0.5% allowed by HDMI spec */ + const struct sun4i_hdmi *hdmi = drm_connector_to_sun4i_hdmi(connector); + unsigned long diff = clock / 200; /* +-0.5% allowed by HDMI spec */ long rounded_rate; This used to be a 32-bit division. If the rate is never more than 4.2GHz, clock could be turned back into 'unsigned long' to avoid the expensive div_u64(). Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel