From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,T_DKIMWL_WL_HIGH,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA2BBC28D1E for ; Thu, 6 Jun 2019 10:44:42 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A39382083E for ; Thu, 6 Jun 2019 10:44:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="PTqU6edB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A39382083E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sntech.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6oyHs6KigREJZCu4kLPO/tlVuvUPAyXwE0rbM+0U4k4=; b=PTqU6edB+yUmTv vCwFYN/HTZ5XrAA5wRB3iLUc8AEYRlGC4AQAusOyfWkU4Ktf+e/bD0AtAkffC+XC7PqOFBTPeOI9H F+wEZDrRjmyiE+PhHbAHEx1aTF2s3tnebUznQohh9VppEbtZZ4yFyxMJm9Y4rcwJ50xpGzo0IL3Rw 3z12LKl4qK0jQSxkHz9YZ8S70bWWFk/nHBpEEN81aOkbcbUPOLEB7xmI91uYZjSm3OJ1uJqU0Zr+n UayLV/cKA4FnhofQkVNq1up3FXwil0Jl118QgC/rbBedONSwNqHwwYCGCtBc7YgPjRUFs01Cyw9B+ UU8r4xif6knBdOOUrJTA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hYpsu-0005sH-VW; Thu, 06 Jun 2019 10:44:40 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hYpss-0005rs-6p; Thu, 06 Jun 2019 10:44:39 +0000 Received: from we0305.dip.tu-dresden.de ([141.76.177.49] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hYpsp-0003i8-AI; Thu, 06 Jun 2019 12:44:35 +0200 From: Heiko Stuebner To: Matthias Kaehlcke Subject: Re: [PATCH 1/2] ARM: dts: rockchip: Split GPIO keys for veyron into multiple devices Date: Thu, 06 Jun 2019 12:44:34 +0200 Message-ID: <3394571.LkITImzWxP@phil> In-Reply-To: <20190605204320.22343-1-mka@chromium.org> References: <20190605204320.22343-1-mka@chromium.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190606_034438_390899_E9830A8E X-CRM114-Status: GOOD ( 14.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Brian Norris , linux-kernel@vger.kernel.org, Douglas Anderson , linux-rockchip@lists.infradead.org, Rob Herring , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am Mittwoch, 5. Juni 2019, 22:43:19 CEST schrieb Matthias Kaehlcke: > With a single device DT overrides can become messy, especially when > keys are added or removed. Multiple devices also allow to > enable/disable wakeup per key/group. > > Signed-off-by: Matthias Kaehlcke applied for 5.3 with 2 minor changes, detailed below. > --- > .../boot/dts/rk3288-veyron-chromebook.dtsi | 26 +++++++------ > arch/arm/boot/dts/rk3288-veyron-minnie.dts | 38 ++++++++++--------- > arch/arm/boot/dts/rk3288-veyron-pinky.dts | 2 +- > arch/arm/boot/dts/rk3288-veyron.dtsi | 4 +- > 4 files changed, 37 insertions(+), 33 deletions(-) > > diff --git a/arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi b/arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi > index fbef34578100..c5f71af84a40 100644 > --- a/arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi > +++ b/arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi > @@ -70,6 +70,20 @@ > pinctrl-0 = <&ac_present_ap>; > }; > > + lid_switch: lid-switch { > + compatible = "gpio-keys"; > + pinctrl-names = "default"; > + pinctrl-0 = <&ap_lid_int_l>; added a blank line here > + lid { > + label = "Lid"; > + gpios = <&gpio0 RK_PA6 GPIO_ACTIVE_LOW>; > + wakeup-source; > + linux,code = <0>; /* SW_LID */ > + linux,input-type = <5>; /* EV_SW */ actually used the constants in the properties, we have the keycodes as dt-binding header nowadays. Heiko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel