From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3C093C43334 for ; Thu, 7 Jul 2022 15:02:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=eJK3o8AYy8t1jKqMNdl/24y/RvbzMBnD5GJLUllsCe8=; b=1V0HvWFatfd0PR E/ofi19hEFrj3wLmXchRaS5J0rZe9qYlITH+mO/dJeyKGzPuWZEFpBH8YpmW4BFFLl/pQUK3uTuV+ 8RsJaxsFfbaHkroqZTO+cNCvz2UiiQ7yFZQ4GNGvVNs+8RrwP3i6Yq7CIdLo1XaGFCatwZ6P3oxpj pDL9uhf3zhrAeE3eMeI1C7FSR9mxPZ/KhmQoDDYlYhnzoIciKigccr/vcSy4mEfn9wsR5WJcgl5kc ek0yT3UxmNffy2UdivAUOEyVoWIMCaH/hJ9vJW+YZrsv/qepbXa8v0T6UpzdOmdawawmsz1gyWx0f 52Mxp99Ag2gj5PdEss2Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o9Szt-00Gfea-Qh; Thu, 07 Jul 2022 15:00:53 +0000 Received: from mail-pg1-x532.google.com ([2607:f8b0:4864:20::532]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o9Szq-00Gfd5-Ey for linux-arm-kernel@lists.infradead.org; Thu, 07 Jul 2022 15:00:52 +0000 Received: by mail-pg1-x532.google.com with SMTP id s206so19019354pgs.3 for ; Thu, 07 Jul 2022 08:00:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=2hZBVUu6vtCkIAAa0XFWh1kR5HWXI7azprojIq7FcUc=; b=ISRo2QpRA1s7r0DFMGm1vMBzRptkuXUFhDKyTg9XJXKn5b3BIcUQSXQzNlLISAyqDL GkMsA6qoleUzq5R8y+9dJyZvk35TdEn8rkdVR7SBnAkNkAf8a5bWlVs99ZuzBOx8GGeA TX7WUScz8cUmHw9jOXQ99Tqa1b7XAOB7uXdS4cOI5d3G6iQxMK+063EyqojL1BM+jagj /VaxrGZg/1Q1B+OlOhpM/0vS2a5h8TyuSQbO2znrgo4yyCq6iN4luc7BWujCd+rmW8LO CD2xW4Ssr/LRJk/pRsFYJAL/jQmKYvPKvf6RdcSoSIa/EVwWgimNQGXcfySH8Mv2KE4A y7ZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=2hZBVUu6vtCkIAAa0XFWh1kR5HWXI7azprojIq7FcUc=; b=qcDV181jUY/q9wlpZPqxaPYdwfXfPbq//C4AnUqNGg2UryLsvVD7ZtUX9ex7bHQByV T710qbEY0gDWtzW7XGhjgESX/TegASfDKFWd10V7+8b8jtbq8m8hzcyN2O/YyH9dXJ6o lr1GbJWQbyeXl1ntrOkVeyRHs1mzsGr/uN3Ja3pR8X8ReZx9DuICcdU+xPncivbRa8Ml AZnllEg4VkhoREZw1SKMQVbp9sQad6Arw/NYeSI/D7aChpMcELDLsNlA7COJmZrS/9bi 4eKteAJtxegGvwOesRQZMvaMhb9ooe2yCKVGgOakIIXiEwTOsdtT/ZJqvgNLhp4T6Qpd BMQg== X-Gm-Message-State: AJIora/ZO4Zg1ZoxuHMV86Gm9MhBKnAnsOaeR7+jymlEY9s5p0eTopKS 69bkkCmi3G73sTIupQ70fmnXFw== X-Google-Smtp-Source: AGRyM1vCvOBb8PRO1bSS1k7cYd5WxX9hvQhGM19KUKgd4qc7ZqLCHBICNZWzJnX41+KKSzo2ZuduiA== X-Received: by 2002:a17:902:ec8f:b0:16a:5327:467a with SMTP id x15-20020a170902ec8f00b0016a5327467amr53059445plg.40.1657206046159; Thu, 07 Jul 2022 08:00:46 -0700 (PDT) Received: from [10.4.255.21] ([139.177.225.235]) by smtp.gmail.com with ESMTPSA id h14-20020a170902f7ce00b0016be0d5483asm9622923plw.252.2022.07.07.08.00.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 Jul 2022 08:00:45 -0700 (PDT) Message-ID: <33a63e76-fb71-2b9e-3b3c-cc6f7a675cf3@bytedance.com> Date: Thu, 7 Jul 2022 23:00:37 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.0 Subject: Re: [RFC PATCH 2/2] arm64: support HAVE_IRQ_EXIT_ON_IRQ_STACK Content-Language: en-US To: Arnd Bergmann Cc: Catalin Marinas , Will Deacon , Linux ARM , Linux Kernel Mailing List References: <20220707110511.52129-1-zhengqi.arch@bytedance.com> <20220707110511.52129-3-zhengqi.arch@bytedance.com> <42bfd82c-b3fb-c942-d6f2-ae5adec90a26@bytedance.com> From: Qi Zheng In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220707_080050_745094_9D433C14 X-CRM114-Status: GOOD ( 20.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2022/7/7 22:41, Arnd Bergmann wrote: > On Thu, Jul 7, 2022 at 3:38 PM Qi Zheng wrote: >> On 2022/7/7 20:49, Arnd Bergmann wrote: >>> On Thu, Jul 7, 2022 at 1:05 PM Qi Zheng wrote: >> * Restore the SP from the FP, and restore the FP and LR from >> the frame >> * record. >> */ >> - mov sp, x29 >> +999: mov sp, x29 >> ldp x29, x30, [sp], #16 >> #ifdef CONFIG_SHADOW_CALL_STACK >> ldp scs_sp, xzr, [sp], #16 >> >> But this also requires a new parameter in do_interrupt_handler. >> >> I also considered implementing call_on_irq_stack() for nmi and irq >> separately, but later think it's unnecessary. > > What I had in mind was something along the lines of > > diff --git a/arch/arm64/kernel/entry-common.c b/arch/arm64/kernel/entry-common.c > index 56cefd33eb8e..432042b91588 100644 > --- a/arch/arm64/kernel/entry-common.c > +++ b/arch/arm64/kernel/entry-common.c > @@ -270,10 +270,7 @@ static void do_interrupt_handler(struct pt_regs *regs, > { > struct pt_regs *old_regs = set_irq_regs(regs); > > - if (on_thread_stack()) > - call_on_irq_stack(regs, handler); > - else > - handler(regs); > + handler(regs); > > set_irq_regs(old_regs); > } > @@ -473,16 +470,31 @@ static void noinstr el1_interrupt(struct pt_regs *regs, > __el1_irq(regs, handler); > } > > -asmlinkage void noinstr el1h_64_irq_handler(struct pt_regs *regs) > +static void noinstr el1_irq(struct pt_regs *regs) > { > el1_interrupt(regs, handle_arch_irq); > } > > -asmlinkage void noinstr el1h_64_fiq_handler(struct pt_regs *regs) > +asmlinkage void noinstr el1h_64_irq_handler(struct pt_regs *regs) > +{ > + if (on_thread_stack()) > + call_on_irq_stack(regs, el1_irq); IMO, this can't work. Because el1_interrupt() will invoke arm64_preempt_schedule_irq(), which will cause scheduling on the IRQ stack. Thanks, Qi > + else > + el1_irq(regs); > +} > + > +static void noinstr el1_fiq(struct pt_regs *regs) > { > el1_interrupt(regs, handle_arch_fiq); > } > > +asmlinkage void noinstr el1h_64_fiq_handler(struct pt_regs *regs) > +{ > + if (on_thread_stack()) > + call_on_irq_stack(regs, el1_fiq); > + else > + el1_fiq(regs); > +} > + > asmlinkage void noinstr el1h_64_error_handler(struct pt_regs *regs) > { > unsigned long esr = read_sysreg(esr_el1); > @@ -713,7 +731,7 @@ static void noinstr > __el0_irq_handler_common(struct pt_regs *regs) > > asmlinkage void noinstr el0t_64_irq_handler(struct pt_regs *regs) > { > - __el0_irq_handler_common(regs); > + call_on_irq_stack(regs, __el0_irq_handler_common); > } > > static void noinstr __el0_fiq_handler_common(struct pt_regs *regs) > @@ -723,7 +741,7 @@ static void noinstr > __el0_fiq_handler_common(struct pt_regs *regs) > > asmlinkage void noinstr el0t_64_fiq_handler(struct pt_regs *regs) > { > - __el0_fiq_handler_common(regs); > + call_on_irq_stack(regs, __el0_fiq_handler_common); > } > > static void noinstr __el0_error_handler_common(struct pt_regs *regs) > @@ -807,12 +825,12 @@ asmlinkage void noinstr > el0t_32_sync_handler(struct pt_regs *regs) > > asmlinkage void noinstr el0t_32_irq_handler(struct pt_regs *regs) > { > - __el0_irq_handler_common(regs); > + call_on_irq_stack(regs, __el0_irq_handler_common); > } > > asmlinkage void noinstr el0t_32_fiq_handler(struct pt_regs *regs) > { > - __el0_fiq_handler_common(regs); > + call_on_irq_stack(regs, __el0_fiq_handler_common); > } > > asmlinkage void noinstr el0t_32_error_handler(struct pt_regs *regs) > > Not sure if that works. > > Arnd -- Thanks, Qi _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel