From: Krzysztof Kozlowski <krzk@kernel.org>
To: Hui-Ping Chen <hpchen0nvt@gmail.com>,
miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
sumit.semwal@linaro.org, christian.koenig@amd.com,
esben@geanix.com
Cc: linux-arm-kernel@lists.infradead.org,
linux-mtd@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org
Subject: Re: [PATCH 2/2] mtd: rawnand: nuvoton: add new driver for the Nuvoton MA35 SoC
Date: Mon, 12 Aug 2024 11:13:47 +0200 [thread overview]
Message-ID: <33ae3c93-81cb-491c-a5b3-239c7c413eb3@kernel.org> (raw)
In-Reply-To: <3b7b629e-0085-4821-932c-e89faad15c1a@gmail.com>
On 12/08/2024 11:10, Hui-Ping Chen wrote:
>>> +
>>> +/* NAND-type Flash BCH Error Data Registers */
>>> +#define MA35_NFI_REG_NANDECCED0 (0x960)
>>> +#define MA35_NFI_REG_NANDECCED1 (0x964)
>>> +#define MA35_NFI_REG_NANDECCED2 (0x968)
>>> +#define MA35_NFI_REG_NANDECCED3 (0x96C)
>>> +#define MA35_NFI_REG_NANDECCED4 (0x970)
>>> +#define MA35_NFI_REG_NANDECCED5 (0x974)
>>> +
>>> +/* NAND-type Flash Redundant Area Registers */
>>> +#define MA35_NFI_REG_NANDRA0 (0xA00)
>>> +#define MA35_NFI_REG_NANDRA1 (0xA04)
>>> +
>>> +#define SKIP_SPARE_BYTES 4
>>> +
>>> +/* BCH algorithm related constants and variables */
>>> +enum {
>>> + eBCH_NONE = 0,
>>> + eBCH_T8,
>>> + eBCH_T12,
>>> + eBCH_T24,
>>> + eBCH_CNT
>>> +} E_BCHALGORITHM;
>>> +
>>> +static const int g_i32BCHAlgoIdx[eBCH_CNT] = {BCH_T8, BCH_T8, BCH_T12, BCH_T24};
>>> +static struct nand_ecclayout_user ma35_nand_oob;
>> Why this is file-scope?
>
> I will remove the `static`.
No, why this cannot be instance dependent? Quick looks says it could.
And should.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-08-12 9:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-12 3:00 [PATCH 0/2] Add support for nuvoton ma35 nand controller Hui-Ping Chen
2024-08-12 3:00 ` [PATCH 1/2] dt-bindings: mtd: nuvoton,ma35d1-nand: add new bindings Hui-Ping Chen
2024-08-12 6:25 ` Krzysztof Kozlowski
2024-08-12 9:02 ` Hui-Ping Chen
2024-08-12 9:12 ` Krzysztof Kozlowski
2024-08-12 9:39 ` Hui-Ping Chen
2024-08-12 3:00 ` [PATCH 2/2] mtd: rawnand: nuvoton: add new driver for the Nuvoton MA35 SoC Hui-Ping Chen
2024-08-12 6:30 ` Krzysztof Kozlowski
2024-08-12 9:10 ` Hui-Ping Chen
2024-08-12 9:13 ` Krzysztof Kozlowski [this message]
2024-08-12 9:46 ` Hui-Ping Chen
2024-08-12 12:52 ` kernel test robot
2024-08-13 21:59 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33ae3c93-81cb-491c-a5b3-239c7c413eb3@kernel.org \
--to=krzk@kernel.org \
--cc=christian.koenig@amd.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=esben@geanix.com \
--cc=hpchen0nvt@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=robh@kernel.org \
--cc=sumit.semwal@linaro.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).