From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CE24AC54EAA for ; Fri, 27 Jan 2023 15:09:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=h7mgcI+lVVbiUq6udvx4C2W1SnFXvGlhytIQYm5kgS8=; b=TTrQpr7T3tMLz7 w6cvkkzMtoWFWsxvZiZKGaVTvMABmV9COCQFg805TJkJIF2dSlFh5bnnoP5aj3UHv9Il3lEvSIP8Y TX0NFgBvTBhIRaey6hKB+8Yx2ajRj30fKTikLe4+rm0xYS1LoJwkSdTXB2/TBQcALlZd4nCcOeubK hb6LfH02v7qBCFlB9XUBVFt2xjB0Nz1FQqF3a1zZAcOBP2OYml/A/EvelwdWMaKbcfbGcYRUuiXro 3gHELpi47y2ADI+hOBD0e4TAZ+eB0nmJQ/GBHAfnmg04NnyagBj2+75Qr/UIXsyL5CdV2tFiVhjeh 5tFGT6khPhZsUMGUTHtA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pLQKw-00FP2X-UE; Fri, 27 Jan 2023 15:08:19 +0000 Received: from mail-wm1-x331.google.com ([2a00:1450:4864:20::331]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pLQKu-00FP1G-18 for linux-arm-kernel@lists.infradead.org; Fri, 27 Jan 2023 15:08:17 +0000 Received: by mail-wm1-x331.google.com with SMTP id f19-20020a1c6a13000000b003db0ef4dedcso5605779wmc.4 for ; Fri, 27 Jan 2023 07:08:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=AW2pWXTyUHGTvF3vRsrjdCAjX1GGIv4T9LN8Vukc73Y=; b=tTz9+hqJ7Jy1km5Dced/EYS/TFgBjlN4MHTuOxRHugbLWpQK/LCF0b6aDaIRqSma4I +kWw5+19yGWEq3zkw8Y5rUu/v5zT9lkQKC2ARFeEt+OWwBha93eynpgSDWb5/E/6ZAc8 9n9JYPTmtLf9TpekqJpz6sRI7ODTBxq2VAFfmTO4zrTqRGJUDjvcs/rbSg4AyCOObFwJ J+r8/nTY7PWU3akKOc3L9vUpEGlHcZ7SnsdMllrHEOVVqmSxsIJubhGIZAzevXNzCwwO M2g98zO0kZsrqGHZPM+x/l8yez9sVj1+NoJAeC39o+CIefB+O/nLs0oUPD+PVnCGKwC2 iZ9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=AW2pWXTyUHGTvF3vRsrjdCAjX1GGIv4T9LN8Vukc73Y=; b=Nn+N11Wvl2EKIDJgsRXSsAqVKMgD5CKE3Aw28/Ascc1LC2QM/TMhOUXjqUXy4QmwQr T68swZnpQfd4NPjn7LPklJxzi3G99tTzGv+C8kiraHvWj0VV1AlfyzJEMLyR5xAm+CPD iiDJuRPzIa1GJW8cmS8qAyStXVxLE1YqF2KX/dLDJzQbVxfBMtOTyk/bUaot5DGkVNVf /lg1qJDBeetdpVBGF751yKrgmg1jgYJXLnXpd86r3uh04clK5Qiw/wgAt6W9K/NvMOrX xWCwMHZD4ZSmy4Fkpskc4qSGGqC9BWk1OwlAbfu7bfdiNUxhKmUNfSiYa0cRMXvRoq6J LaNw== X-Gm-Message-State: AFqh2kqadu6UWXTFI8lvF3sthox0FVrcQHSIvgo6iFu1wbRp28pY5cru e1Rcn4FymxF2WB0CcrsmXDcVIQ== X-Google-Smtp-Source: AMrXdXt78EcrCHO17FyVHOV+gQgWXoL2exBvkBWIstUfl0BNIQuPBstljwxZrmYkM2CDqNkqhXEnnA== X-Received: by 2002:a05:600c:c05:b0:3db:2252:e50e with SMTP id fm5-20020a05600c0c0500b003db2252e50emr32563617wmb.24.1674832092081; Fri, 27 Jan 2023 07:08:12 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id bi5-20020a05600c3d8500b003db0bb81b6asm4890048wmb.1.2023.01.27.07.08.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 27 Jan 2023 07:08:11 -0800 (PST) Message-ID: <33c2038b-5e06-4eb2-82b8-007bb735bfb1@linaro.org> Date: Fri, 27 Jan 2023 16:08:09 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH 07/15] dt-bindings: clock: Add Ambarella clock bindings Content-Language: en-US To: Li Chen Cc: li chen , michael turquette , stephen boyd , rob herring , krzysztof kozlowski , "moderated list:arm/ambarella soc support" , "open list:common clk framework" , "open list:open firmware and flattened device tree bindings" , open list , arnd bergmann References: <20230123073305.149940-1-lchen@ambarella.com> <20230123073305.149940-8-lchen@ambarella.com> <0c19efb4-3bca-f500-ca24-14b9d24369ef@linaro.org> <87y1prgdyu.wl-me@linux.beauty> <87tu0ehl88.wl-me@linux.beauty> <87sffyhgvw.wl-me@linux.beauty> <185f3b3a330.11c135c37327076.6300919877819761183@linux.beauty> From: Krzysztof Kozlowski In-Reply-To: <185f3b3a330.11c135c37327076.6300919877819761183@linux.beauty> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230127_070816_117324_33FE067B X-CRM114-Status: GOOD ( 13.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 27/01/2023 15:48, Li Chen wrote: > > > > but what you are saying is that there is no separate clock controller > > device with its own IO address but these clocks are part of rct_syscon. > > Then model it that way in DTS. The rct_syscon is then your clock > > controller and all these fake gclk-core and gclk-ddr nodes should be gone. > > Ok, I will remove these fake nodes, and model the hardware as: > > rct_syscon node > | clock node(pll, div, mux, composite clocks live in the same driver) > | other periphal nodes You need clock node if it takes any resources. If it doesn't, you do not need it. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel