Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Kumar, Udit" <u-kumar1@ti.com>
To: <a-christidis@ti.com>, Nishanth Menon <nm@ti.com>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Tero Kristo <kristo@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>
Cc: <linux-arm-kernel@lists.infradead.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	Michael Walle <mwalle@kernel.org>, <u-kumar1@ti.com>
Subject: Re: [PATCH v2] arm64: dts: ti: add am62p/j722s GPU node
Date: Fri, 4 Sep 2026 19:57:21 +0530	[thread overview]
Message-ID: <33c6717c-5c24-488f-bd85-d0cfaacaf13e@ti.com> (raw)
In-Reply-To: <20260831-am62p-gpu-node-v2-1-69945a2db2af@ti.com>

Thanks for patch Antonios,

On 8/31/2026 11:39 PM, a-christidis@ti.com wrote:
> From: Michael Walle <mwalle@kernel.org>
> 
> Add BXS-4 GPU node for J722s/AM62P.
> 
> Signed-off-by: Michael Walle <mwalle@kernel.org>
> Signed-off-by: Antonios Christidis <a-christidis@ti.com>
> ---
> v2:
>   - Reword commit message and title for clarity
>   - Resend patch, missed merge window previously
> ---

Link of v1 missing, In case you are doing v3, please include change log
history.

>  arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi
> index f130c7cb998d..e36205eccfc9 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi
> @@ -1111,6 +1111,17 @@ dphy0: phy@30110000 {
>  		status = "disabled";
>  	};
>  
> +	gpu: gpu@fd80000 {
> +		compatible = "ti,am62p-gpu", "img,img-bxs-4-64", "img,img-rogue";
> +		reg = <0x00 0x0fd80000 0x00 0x80000>;
> +		clocks = <&k3_clks 237 3>;
> +		clock-names = "core";
> +		interrupts = <GIC_SPI 241 IRQ_TYPE_LEVEL_HIGH>;
> +		power-domains = <&k3_pds 237 TI_SCI_PD_EXCLUSIVE>,
> +				<&k3_pds 242 TI_SCI_PD_EXCLUSIVE>;
> +		power-domain-names = "a", "b";
> +	};

Could you check once, if you don't need some assigned-clock-freq.
and good with default freq ?

> +
>  	vpu: video-codec@30210000 {
>  		compatible = "ti,j721s2-wave521c", "cnm,wave521c";
>  		reg = <0x00 0x30210000 0x00 0x10000>;
> 
> ---
> base-commit: e30626823a406725ce29bc75cb8ec467d3e1e326
> change-id: 20260831-am62p-gpu-node-f041d03b5159
> 
> Best regards,



  parent reply	other threads:[~2026-09-04 14:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-31 18:09 [PATCH v2] arm64: dts: ti: add am62p/j722s GPU node a-christidis
2026-09-03 13:06 ` Bryan Brattlof
2026-09-04 14:27 ` Kumar, Udit [this message]
2026-09-04 14:41   ` Michael Walle
2026-09-04 17:01     ` Kumar, Udit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=33c6717c-5c24-488f-bd85-d0cfaacaf13e@ti.com \
    --to=u-kumar1@ti.com \
    --cc=a-christidis@ti.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kristo@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mwalle@kernel.org \
    --cc=nm@ti.com \
    --cc=robh@kernel.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox