From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F127AE7718D for ; Sun, 22 Dec 2024 14:26:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ruhJTF6iQdm0kceB0Ge3qC8mvmQcst/EDVsco6aY9Jw=; b=KBJHwQ/b/Hy/ZBbs+76QVA+dGb RK4joMkzvOglTE1OHEnAkfjdTpEGybA7MgkP0u5NpmTTjtqyGHP4xv+D7klLteBBvr6dRFefoDRLF J0qCpG66J8rFO9iVJ7kBrb5dY1Wevai++4KM/2yfgnPebOz6ztWhaTAclth1YkMQeMB6J42lxb4sJ LowyGAtEChvuL2PFZ9f/d0PGiDGzOgrY7TDxOxMPcL4QVg/P/SHKaIOqBI7ecEZ+/di2XgF2gUBB+ jOESy2RgTtmGnG/zwjDXZmQe0X0j8Ts1Ejn6RTpvKYkbs+fvVaKBIEow2KK9xImU46UvvbA1/wulr g2plRuyg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tPMuS-00000008NWC-0BM0; Sun, 22 Dec 2024 14:26:20 +0000 Received: from nyc.source.kernel.org ([2604:1380:45d1:ec00::3]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tPMs7-00000008N2b-3BJQ for linux-arm-kernel@lists.infradead.org; Sun, 22 Dec 2024 14:23:57 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id BEA89A40857; Sun, 22 Dec 2024 14:22:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7BC76C4CEDD; Sun, 22 Dec 2024 14:23:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1734877434; bh=XCzSl+ocFbqkYmTdaxwTjeVvptnU95IqRr1cm0vNuyY=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Duk9cMKEM6UVxlquoMxdUEq//SzoOjud1aLhenDQQoLFksqV6aSl04QoYf3WuQocK ZGzvSLYzxV0K6Aw7RThVOEISrYIihY/wMaCUzmyB5/7TYUKYqSJUCu6Qx3Am3Y++co 8sCppVjvnA+td3GBskCgwIxO1P3vr+JjQkv73KxLGrC6fHimvzdNN6rKbr6pDaWB2T 29dY17zybD9FhWAk2wyYvTJVLyOtVfBw2Ni0IgA3T1EzCAsOfi95avNrUx+mOcBGd9 cvwvUM7k1UF25QzL/mMrJm0VGP7TxEE6bnlhqIdWIz71f/xy/oU47us/F1Ehl/+o6H Rq/hb91Q5skbw== Message-ID: <33c7a520-dda9-4d3c-aa27-2f48786996a9@kernel.org> Date: Sun, 22 Dec 2024 12:42:23 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/3] arm64: dts: exynos: gs101-pixel: add generic gs101-based Pixel support To: =?UTF-8?Q?Andr=C3=A9_Draszik?= , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Peter Griffin , Tudor Ambarus , Alim Akhtar Cc: Will McVicker , kernel-team@android.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org References: <20241220-gs101-simplefb-v2-0-c10a8f9e490b@linaro.org> <20241220-gs101-simplefb-v2-2-c10a8f9e490b@linaro.org> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: <20241220-gs101-simplefb-v2-2-c10a8f9e490b@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241222_062355_929293_A5A86765 X-CRM114-Status: GOOD ( 29.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 20/12/2024 12:27, André Draszik wrote: > In order to support Pixel 6 (Oriole), Pixel 6 Pro (Raven), and Pixel 6a > (Bluejay) correctly, we have to be able to distinguish them properly as > we add support for more features. > > For example, Raven has a larger display. There are other differences, > like battery design capacity, etc. > > To facilitate this, we create a generic gs101-based Pixel DT that can > work on any such gs101-based device. At the same time, we move the No, whatever insanity Android has there, please don't populate it to upstream. There is no such thing as "generic board" thus cannot be a "generic DTS". > Oriole specific parts that we have at the moment (display) into an > overlay, making it easy to add support for Raven and Bluejay in a > similar way. > > Note1: > Despite being an overlay, we instruct kbuild to create a merged > gs101-oriole.dtb and a gs101-oriole.dtbo. This way existing scripts can > keep working, but it also gives the option to just apply the overlay > before boot (e.g. by the bootloader). > > Note2: > I've changed the simple-framebuffer node to specify the memory via > memory-region instead of reg, as that avoids unnecessary duplication > (of the size), and it avoids having to specify #address-cells > and #size-cells in the chosen node (and duplicating this in the DTSO), > which is otherwise necessary to keep dt_binding_check happy and DT > validation working in general. > > Signed-off-by: André Draszik > --- > Note: MAINTAINERS doesn't need updating, it covers this whole directory > --- > arch/arm64/boot/dts/exynos/google/Makefile | 6 ++-- > .../arm64/boot/dts/exynos/google/gs101-oriole.dtso | 33 ++++++++++++++++++++++ > .../{gs101-oriole.dts => gs101-pixel-generic.dts} | 24 +++++++--------- > 3 files changed, 47 insertions(+), 16 deletions(-) > > diff --git a/arch/arm64/boot/dts/exynos/google/Makefile b/arch/arm64/boot/dts/exynos/google/Makefile > index 0a6d5e1fe4ee..6e6b5319212a 100644 > --- a/arch/arm64/boot/dts/exynos/google/Makefile > +++ b/arch/arm64/boot/dts/exynos/google/Makefile > @@ -1,4 +1,6 @@ > # SPDX-License-Identifier: GPL-2.0 > > -dtb-$(CONFIG_ARCH_EXYNOS) += \ > - gs101-oriole.dtb \ > +dtb-$(CONFIG_ARCH_EXYNOS) += gs101-pixel-generic.dtb > + > +gs101-oriole-dtbs := gs101-pixel-generic.dtb gs101-oriole.dtbo > +dtb-$(CONFIG_ARCH_EXYNOS) += gs101-oriole.dtb > diff --git a/arch/arm64/boot/dts/exynos/google/gs101-oriole.dtso b/arch/arm64/boot/dts/exynos/google/gs101-oriole.dtso > new file mode 100644 > index 000000000000..43572039cd07 > --- /dev/null > +++ b/arch/arm64/boot/dts/exynos/google/gs101-oriole.dtso > @@ -0,0 +1,33 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * Oriole Device Tree > + * > + * Copyright 2021-2023 Google LLC > + * Copyright 2023-2024 Linaro Ltd > + */ > + > +/dts-v1/; > +/plugin/; > + > +&{/} { > + model = "Oriole"; > + compatible = "google,gs101-oriole", "google,gs101-pixel", "google,gs101"; Boards are not overlays. Board equals DTB. > + > + reserved-memory { > + #address-cells = <2>; > + #size-cells = <1>; > + > + splash@fac00000 { > + reg = <0x0 0xfac00000 (1080 * 2400 * 4)>; > + status = "okay"; > + }; > + }; > +}; > + > +&framebuffer0 { > + width = <1080>; > + height = <2400>; > + stride = <(1080 * 4)>; > + format = "a8r8g8b8"; > + status = "okay"; > +}; > diff --git a/arch/arm64/boot/dts/exynos/google/gs101-oriole.dts b/arch/arm64/boot/dts/exynos/google/gs101-pixel-generic.dts > similarity index 93% > rename from arch/arm64/boot/dts/exynos/google/gs101-oriole.dts > rename to arch/arm64/boot/dts/exynos/google/gs101-pixel-generic.dts > index 4e1625e3fbb4..48dc37afcb86 100644 > --- a/arch/arm64/boot/dts/exynos/google/gs101-oriole.dts > +++ b/arch/arm64/boot/dts/exynos/google/gs101-pixel-generic.dts > @@ -1,6 +1,6 @@ > // SPDX-License-Identifier: GPL-2.0-only > /* > - * Oriole Device Tree > + * generic gs101-based Pixel Device Tree > * > * Copyright 2021-2023 Google LLC > * Copyright 2023 Linaro Ltd - > @@ -15,30 +15,24 @@ > #include "gs101.dtsi" > > / { > - model = "Oriole"; > - compatible = "google,gs101-oriole", "google,gs101"; > + model = "GS101-based Pixel or derivative"; > + compatible = "google,gs101-pixel", "google,gs101"; > > aliases { > serial0 = &serial_0; > }; > > chosen { > - #address-cells = <2>; > - #size-cells = <1>; > - ranges; > - > /* Bootloader expects bootargs specified otherwise it crashes */ > bootargs = ""; > stdout-path = &serial_0; > > /* Use display framebuffer as setup by bootloader */ > - framebuffer0: framebuffer@fac00000 { I don't think this exists in current source. It does exist in thing I was applying, but then this does not make much sense: add a framebuffer which has to be changed, because it is not correct. I'll drop the framebuffer patch. Best regards, Krzysztof