From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B11C5C05027 for ; Tue, 14 Mar 2023 20:14:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=cWVLuX9O+lY7l2c8hRVrKxVsVn5pgKUtk2HW1eWVsTo=; b=43NKvzWszLpcOi osh8Bjx1K6Wgd+Dc6l2Vl8xzG7/fQwiMBMJIYdHKcIB1cwOSe7OPbkIgN28FooQiIjpP7V5SWqFCZ gX2XiRStkjACD4jnagEDp0AAj0uhOXAkq8cB1WzbTluLVdCq8zGqyo9WgKg7i/Mza9CWIbKF4zzOG ClqkFdBzvwUEzvptS+YMRaMhtmpKFvj98blCiBRosZcz0lTnkOG9GI+fDpjdo0QcTR/Qdm1VZzreA t+3zeKEP3CeaYk4GwcJ1L3/CZHB5664rt0VE879ejbgTAekUpR5hcvUgI8JMUOryV0b6qjFi3RoXj c+pQy6KPf+Pq0aSIhzMw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pcB1K-00BSC6-2S; Tue, 14 Mar 2023 20:13:18 +0000 Received: from mail-ed1-x531.google.com ([2a00:1450:4864:20::531]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pcB1G-00BSAz-0a for linux-arm-kernel@lists.infradead.org; Tue, 14 Mar 2023 20:13:15 +0000 Received: by mail-ed1-x531.google.com with SMTP id o12so66935911edb.9 for ; Tue, 14 Mar 2023 13:13:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678824792; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lfF6fwnjck3bhnls8IFYDauZUKUbRQs1EOuea+gCMoY=; b=FGonTE7MrEBng0ymfjw1CZ8IWnRCYQS1AtHQYa7q9i90KRfOgSTG2BPJKu4JlD1wBu tODSCQGSRWg4iDawk5wvG84mW5iuHP1k6ogt4zUS3EKsFCzc01Ks64JGmGNfASMrkTcA qfdlwVArBX8fCzBTSsbSY4IohrDfoS+ezNANqjj0GZmhBOIkSnjartU7TvASnDia0kp1 Pbldqrhw+4XuqVyBpUeg8NHij2yXl3lScKSBIkInj5ClkC+Lee6jzDoRFhrCoOBUX4Ce 7fjR4ugMIDSetOHcJ2ZuU2IrtyUi3ej1E6zT/DnOq9W2rGXdCCl3kklsvNkRkuTMlMkZ EYAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678824792; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lfF6fwnjck3bhnls8IFYDauZUKUbRQs1EOuea+gCMoY=; b=4+3CJ1yHE9upCBcKwzkzV/P7shceeyXFlxO9zOJtwtUilFXS3hMMu+1U3GAnSsbf4M /M8DMdUQRSodomDmzqQCjBOG08N4ODhPk5JDk83/Rh4KNx1oZyAVC75xWSW5K6HE3z0Y ghgf347qHUJ99Ppzap7H3hyW9eVUZaTLG0qpyJu+3YGm3R9Jg8Qf1imG31SAfRFRmTV+ AUquY9u3d3CjoAu2hrcTzqWDYuyLphief2Y9BALCzM3b+VtSXyjtFeXXur6lvco/WQZt WqYOy28h/FPlSdv5zsRlW0CIo8bm1McKvDQ/O9oCDm5y4YbJsaotsU2wOZha1K0fvlBF pYnQ== X-Gm-Message-State: AO0yUKXUNRKPT/cNYuSunOxtnWSLlO7xsugfG8Hl5kMsgm8/lJjzTNn6 qZzJ+qyM0DL4XVLbqsZfHbI= X-Google-Smtp-Source: AK7set8XuSrK8wcL8DFD17yUF75lwZLc+CDnrELGJXtkqu0YMqyHM3+YxMpDRgST+fx1qcmnGAP5AA== X-Received: by 2002:a17:906:380d:b0:878:54e3:e3e1 with SMTP id v13-20020a170906380d00b0087854e3e3e1mr3520090ejc.73.1678824792668; Tue, 14 Mar 2023 13:13:12 -0700 (PDT) Received: from jernej-laptop.localnet (82-149-1-233.dynamic.telemach.net. [82.149.1.233]) by smtp.gmail.com with ESMTPSA id c11-20020a50d64b000000b004fa19f5ba99sm1507227edj.79.2023.03.14.13.13.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Mar 2023 13:13:12 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Thierry Reding , Chen-Yu Tsai , Samuel Holland , Uwe =?ISO-8859-1?Q?Kleine=2DK=F6nig?= Cc: kernel@pengutronix.de, linux-pwm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev Subject: Re: [PATCH 25/30] pwm: sun4i: Convert to platform remove callback returning void Date: Tue, 14 Mar 2023 21:13:11 +0100 Message-ID: <3407592.QJadu78ljV@jernej-laptop> In-Reply-To: <20230303185445.2112695-26-u.kleine-koenig@pengutronix.de> References: <20230303185445.2112695-1-u.kleine-koenig@pengutronix.de> <20230303185445.2112695-26-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230314_131314_234289_7950714F X-CRM114-Status: GOOD ( 21.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Dne petek, 03. marec 2023 ob 19:54:40 CET je Uwe Kleine-K=F6nig napisal(a): > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is (mostly) ignored > and this typically results in resource leaks. To improve here there is a > quest to make the remove callback return void. In the first step of this > quest all drivers are converted to .remove_new() which already returns > void. > = > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > = > Signed-off-by: Uwe Kleine-K=F6nig > --- Acked-by: Jernej Skrabec Best regards, Jernej > drivers/pwm/pwm-sun4i.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > = > diff --git a/drivers/pwm/pwm-sun4i.c b/drivers/pwm/pwm-sun4i.c > index b973da73e9ab..a8790a8fc53e 100644 > --- a/drivers/pwm/pwm-sun4i.c > +++ b/drivers/pwm/pwm-sun4i.c > @@ -477,7 +477,7 @@ static int sun4i_pwm_probe(struct platform_device *pd= ev) > return ret; > } > = > -static int sun4i_pwm_remove(struct platform_device *pdev) > +static void sun4i_pwm_remove(struct platform_device *pdev) > { > struct sun4i_pwm_chip *sun4ichip =3D platform_get_drvdata(pdev); > = > @@ -485,8 +485,6 @@ static int sun4i_pwm_remove(struct platform_device > *pdev) > = > clk_disable_unprepare(sun4ichip->bus_clk); > reset_control_assert(sun4ichip->rst); > - > - return 0; > } > = > static struct platform_driver sun4i_pwm_driver =3D { > @@ -495,7 +493,7 @@ static struct platform_driver sun4i_pwm_driver =3D { > .of_match_table =3D sun4i_pwm_dt_ids, > }, > .probe =3D sun4i_pwm_probe, > - .remove =3D sun4i_pwm_remove, > + .remove_new =3D sun4i_pwm_remove, > }; > module_platform_driver(sun4i_pwm_driver); _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel