From: heiko@sntech.de (Heiko Stuebner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: rockchip: Add dmac_bus rx and tx for uart2
Date: Tue, 16 Jun 2015 13:37:33 +0200 [thread overview]
Message-ID: <34159914.9nlETdacuk@phil> (raw)
In-Reply-To: <1434390468-27296-1-git-send-email-romain.perier@gmail.com>
Hi,
Am Montag, 15. Juni 2015, 17:47:48 schrieb Romain Perier:
> This removes warning "ttyS2 - Failed to request dma" from kernel logs
>
> Signed-off-by: Romain Perier <romain.perier@gmail.com>
> ---
> arch/arm/boot/dts/rk3288.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
> index 22316d0..816f40a 100644
> --- a/arch/arm/boot/dts/rk3288.dtsi
> +++ b/arch/arm/boot/dts/rk3288.dtsi
> @@ -385,6 +385,8 @@
> clock-names = "baudclk", "apb_pclk";
> pinctrl-names = "default";
> pinctrl-0 = <&uart2_xfer>;
> + dmas = <&dmac_bus_s 4>, <&dmac_bus_s 5>;
> + dma-names = "tx", "rx";
> status = "disabled";
> };
The dma channels are a property of the hardware, so we probably should add
them for all uarts in one go, instead of everytime something complains :-)
in dmac_peri
uart0: tx 1, rx 2
uart1: tx 3, rx 4
uart3: tx 7, rx 8
uart4: tx 9, rx 10
Just for the record and if anybody is interested to work in this, we have an
issue with the dma implementation [0] that is not yet solved upstream. From
what I've remember, that mostly got triggered on higher speeds, like higher
spi-speeds or i2s audio stuff (poping).
Heiko
[0]
https://chromium.googlesource.com/chromiumos/third_party/kernel/+/93c3b192dca7e8c773c4d28873114c325382b63e%5E%21/#F0
next prev parent reply other threads:[~2015-06-16 11:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-15 17:47 [PATCH] ARM: dts: rockchip: Add dmac_bus rx and tx for uart2 Romain Perier
2015-06-16 11:37 ` Heiko Stuebner [this message]
2015-06-17 17:01 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=34159914.9nlETdacuk@phil \
--to=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).