From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RFC 1/2] drivers: pci: fix window allocation order wrt bus_range filtering
Date: Fri, 24 Oct 2014 12:55:33 +0200 [thread overview]
Message-ID: <3428924.HDrlijkpFb@wuerfel> (raw)
In-Reply-To: <20141024090409.GR25302@e106497-lin.cambridge.arm.com>
On Friday 24 October 2014 10:04:09 Liviu Dudau wrote:
> On Thu, Oct 23, 2014 at 11:27:07PM +0100, Bjorn Helgaas wrote:
> > On Thu, Oct 23, 2014 at 04:23:06PM +0100, Lorenzo Pieralisi wrote:
> > > The number of windows allocated for the host bridge depends on the
> > > bus resource. Instead of first allocating the windows and then
> > > limit the bus resource, this patch reshuffles the code so that if any
> > > limitation is applied to the bus resource it is taken into account in
> > > the windows allocation.
> > >
> > > Cc: Will Deacon <will.deacon@arm.com>
> > > Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
> >
> > Hi Lorenzo,
> >
> > I can *read* your patches just fine, but when I save them using mutt to
> > apply them, they look like this:
> >
> > --- a/drivers/pci/host/pci-host-generic.c
> > +++ b/drivers/pci/host/pci-host-generic.c
> > @@ -276,17 +276,17 @@ static int gen_pci_parse_map_cfg_windows(struct gen_p=
> > ci *pci)
> > =09=09return err;
> > =09}
> > =20
> > -=09pci->cfg.win =3D devm_kcalloc(dev,
> > resource_size(&pci->cfg.bus_range),
> >
> > I can work around this by downloading them another way, but it is a
> > bit of a hassle. I *think* this is because your email has
> >
> > Content-Type: text/plain; charset=WINDOWS-1252
> >
> > which apparently confuses mutt. Any idea why this is? Anybody know how I
> > can fix mutt to deal with this?
>
> I use decode-save (<Esc>s on my setup) to save the attachment(s). Sometimes
> it works well enough, although more often than not tabs get lost.
I just tried applying the patches locally here. The patch looks the same way
for me, but 'git am' actually works while 'patch' does not.
Maybe Bjorn is using an outdated git version. While the patch clearly shouldn't
have been sent that way, I think git has been changed now to work around that.
I'm using a git-2.1 snapshot here.
Arnd
next prev parent reply other threads:[~2014-10-24 10:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-23 15:23 [PATCH RFC 1/2] drivers: pci: fix window allocation order wrt bus_range filtering Lorenzo Pieralisi
2014-10-23 15:23 ` [PATCH RFC 2/2] drivers: pci: convert generic host controller to DT resource parsing API Lorenzo Pieralisi
2014-10-27 12:03 ` Will Deacon
2014-10-27 15:44 ` Lorenzo Pieralisi
2014-10-23 22:27 ` [PATCH RFC 1/2] drivers: pci: fix window allocation order wrt bus_range filtering Bjorn Helgaas
2014-10-24 8:53 ` Lorenzo Pieralisi
2014-10-24 9:04 ` Liviu Dudau
2014-10-24 10:55 ` Arnd Bergmann [this message]
2014-10-27 12:01 ` Will Deacon
2014-11-06 0:05 ` Bjorn Helgaas
2014-11-06 9:58 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3428924.HDrlijkpFb@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox