From: tomasz.figa@gmail.com (Tomasz Figa)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] ARM: EXYNOS: pm_domain: Fix power domain name initialization
Date: Sat, 08 Sep 2012 10:24:33 +0200 [thread overview]
Message-ID: <3430339.QiHB9nIcXj@flatron> (raw)
In-Reply-To: <CAJuYYwQWEN3FiNwQdugeKRV53cA65WdW79trcmP2kqqOPbz+sg@mail.gmail.com>
Hi Thomas,
On Saturday 08 of September 2012 13:37:59 Thomas Abraham wrote:
> > - pd->name = np->name;
> > + pd->pd.name = kstrdup(np->name, GFP_KERNEL);
> > + pd->name = pd->pd.name;
>
> Since device tree blob is always resident, why not just use np->name
> instead of copying it to a new place?
The problem is that np->name is const, while pd->pd.name is not.
--
Best regards,
Tomasz Figa
next prev parent reply other threads:[~2012-09-08 8:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-06 9:38 [PATCH 0/3] ARM: EXYNOS: Power domain DT support extension Tomasz Figa
2012-09-06 9:38 ` [PATCH 1/3] ARM: EXYNOS: pm_domain: Detect domain state on registration from DT Tomasz Figa
2012-09-08 8:06 ` Thomas Abraham
2012-09-06 9:38 ` [PATCH 2/3] ARM: EXYNOS: pm_domain: Fix power domain name initialization Tomasz Figa
2012-09-08 8:07 ` Thomas Abraham
2012-09-08 8:24 ` Tomasz Figa [this message]
2012-09-06 9:38 ` [PATCH 3/3] ARM: EXYNOS: pm_domain: Bind devices to power domains using DT Tomasz Figa
2012-09-08 8:18 ` Thomas Abraham
2012-09-08 8:35 ` Tomasz Figa
2012-09-19 13:28 ` [PATCH 0/3] ARM: EXYNOS: Power domain DT support extension Tomasz Figa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3430339.QiHB9nIcXj@flatron \
--to=tomasz.figa@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox