From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 492E8CA1008 for ; Tue, 5 Sep 2023 20:34:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7Bj2rOfghXZFa12ALXGch5fq0NSGlv0TSHap5UOfd1w=; b=vqcgw2YiC/Pbj2 +Aj2s9DonoC6RbTrpZ7dere4fmmh3Ufe+I9+hG4AsKElR6kEduHG3XDlwchIq7Mb949X+J0hamPQk FZWzRdnydOiMLln1UKMyjXbB/R6/W4CT+vtnwrlNUtNFrtctivN7Bmp2EJlU7Z75DUsqxN90cwTjt Pz8f61EzqQA/zQgZngHsayP4Dbd8t7D24kpoTBQ51mvOOY7sNnfLMhKJvR87+JP6DLGN1PMd4XwfF qLL5RSUieHdY+/j974JQ5w2cAG/q9mv8YDEge6JSi+sKJnNBDFX6/u5Bs4x279UsJRhFNkfft9Egq XveXvHFSR04spcNkknjw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qdck2-006h8K-0l; Tue, 05 Sep 2023 20:33:42 +0000 Received: from mail-ej1-x62d.google.com ([2a00:1450:4864:20::62d]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qdcjz-006h7g-1S for linux-arm-kernel@lists.infradead.org; Tue, 05 Sep 2023 20:33:40 +0000 Received: by mail-ej1-x62d.google.com with SMTP id a640c23a62f3a-99bdcade7fbso424218766b.1 for ; Tue, 05 Sep 2023 13:33:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693946018; x=1694550818; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+Y/qz5Q/D4Xh82fml9lf+22Tut8ew4AzgdNATkCb0mg=; b=qTaj+Lw+OVMAINVPL4nTIFZY9hBsyNuqjvM2Slj3RuUklAVojUMQnyde7Gku0ZbrdT 1vSzMUoijGpsi1+6visVaJDS7C3nTOqWNmTj962vLUIkMwpOnVsW2EX/g+yIq5TsfaIR 4cZ8fHSnbkCuBpNRIXDmcH7m7G79zJi1wkPbWevIuNow8xtJBKgC8fDA0zhfNqguxy+O aoZUTecrEBrRkoZh9gfg9D5eNni4oH5x4XGs8qFc1aCuiaqqImqD1TTiazYq4LEfi2w5 3B3xWK6WpHFlSQpq49d6YoANP9tpNTae+9yrQ4Z2/rDuqz1o5iNGak1v+eAnxWxyTh98 F3pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693946018; x=1694550818; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+Y/qz5Q/D4Xh82fml9lf+22Tut8ew4AzgdNATkCb0mg=; b=jH296+uIYt6Vz+nKk+LfKi5uvGfKDXDiS/65dyB7ged3WfLuoYydZX7CMEUWgGg9xd EJKV8KYhoAQyi3gN55LRHk271qS7wa0ygeYX0l/Ldi6D1Hy8ZrGm6qryHhXhaYU8D0v6 d9F+3Sf5DGII71m3MI4N2orwE24e4DSTjnxDz1qiVtuo2yy+2bOToMGQtRX0V6A/yU46 9jst2mDCzLkU0Lls4wNO4fehEOFKdUkaCmZIA1VwBjiPR0IZPKSRTfhOgqwDG2lT6R57 sz96cWdqq7529GBihBOZJICBzCdIFJxyPm3vZSTJJEAeWvxYJ6j1sXt1J9Ch44Y+j/8L j7eA== X-Gm-Message-State: AOJu0YzPKssO4J+2C6e29SZFbWC6Si3tmlpPWCpi+MZXj7u90DB6Swrd mZwmozvUji1ZZ3SGwzw4+V/oHnMT4Wr7f3A1 X-Google-Smtp-Source: AGHT+IF7LbRquDkm6YhWhL50x9Jtu4g7EmvWSZoEBIMpq9IJRoIB/RdOfSm3q6foUsGnO/tlDPbmiQ== X-Received: by 2002:a17:906:5a6c:b0:99d:dd43:d427 with SMTP id my44-20020a1709065a6c00b0099ddd43d427mr711749ejc.10.1693946017963; Tue, 05 Sep 2023 13:33:37 -0700 (PDT) Received: from archlinux.localnet (82-149-12-148.dynamic.telemach.net. [82.149.12.148]) by smtp.gmail.com with ESMTPSA id s23-20020a170906c31700b009934b1eb577sm8035258ejz.77.2023.09.05.13.33.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Sep 2023 13:33:37 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, Daniel Lezcano , Thomas Gleixner , Chen-Yu Tsai , Samuel Holland , Mans Rullgard , Maxime Ripard , Jinjie Ruan Cc: ruanjinjie@huawei.com Subject: Re: [PATCH -next] clocksource/drivers/sun5i: Remove redundant dev_err() for platform_get_irq() Date: Tue, 05 Sep 2023 22:33:36 +0200 Message-ID: <3440176.QJadu78ljV@archlinux> In-Reply-To: <20230901071328.1322235-1-ruanjinjie@huawei.com> References: <20230901071328.1322235-1-ruanjinjie@huawei.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230905_133339_495318_45EBAC91 X-CRM114-Status: GOOD ( 19.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Friday, September 1, 2023 9:13:28 AM CEST Jinjie Ruan wrote: > Since commit 7723f4c5ecdb ("driver core: platform: Add an error message > to platform_get_irq*()") and commit 2043727c2882 ("driver core: > platform: Make use of the helper function dev_err_probe()"), there is > no need to call the dev_err() function directly to print a custom > message when handling an error from platform_get_irq() function as it is > going to display an appropriate error message in case of a failure. > > Fixes: 7e5bac610d2f ("clocksource/drivers/sun5i: Convert to platform device > driver") Signed-off-by: Jinjie Ruan This was already submitted one day earlier: https://lore.kernel.org/all/20230831041414.66434-1-yang.lee@linux.alibaba.com/ Best regards, Jernej > --- > drivers/clocksource/timer-sun5i.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/clocksource/timer-sun5i.c > b/drivers/clocksource/timer-sun5i.c index 69fee3540d37..0d229a9058da 100644 > --- a/drivers/clocksource/timer-sun5i.c > +++ b/drivers/clocksource/timer-sun5i.c > @@ -256,10 +256,8 @@ static int sun5i_timer_probe(struct platform_device > *pdev) } > > irq = platform_get_irq(pdev, 0); > - if (irq < 0) { > - dev_err(dev, "Can't get IRQ\n"); > + if (irq < 0) > return irq; > - } > > clk = devm_clk_get_enabled(dev, NULL); > if (IS_ERR(clk)) { _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel