linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Luca Weiss <luca@z3ntu.xyz>
To: Rob Herring <robh@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree <devicetree@vger.kernel.org>,
	Johan Hedberg <johan.hedberg@gmail.com>,
	Maxime Ripard <maxime.ripard@bootlin.com>,
	netdev@vger.kernel.org, Marcel Holtmann <marcel@holtmann.org>,
	"open list:BLUETOOTH DRIVERS" <linux-bluetooth@vger.kernel.org>,
	Chen-Yu Tsai <wens@csie.org>,
	"David S. Miller" <davem@davemloft.net>,
	arm-linux <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 3/8] dt-bindings: net: bluetooth: Add rtl8723bs-bluetooth
Date: Sun, 02 Jun 2019 11:33:19 +0200	[thread overview]
Message-ID: <3444508.DTbMFtmaYk@g550jk> (raw)
In-Reply-To: <CAL_Jsq+kqFrY3DoHG_TJCCSxVHRkin4OwM+F9qm6W0w5YfjPQQ@mail.gmail.com>


[-- Attachment #1.1: Type: text/plain, Size: 1377 bytes --]

On Dienstag, 19. Februar 2019 15:14:01 CEST Rob Herring wrote:
> > > How is this used?
> > 
> > rtl8723bs-bt needs 2 firmware binaries -- one is actual firmware,
> > another is firmware config which is specific to the board. If
> > firmware-postfix is specified, driver appends it to the name of config
> > and requests board-specific config while loading firmware. I.e. if
> > 'pine64' is specified as firmware-postfix driver will load
> > rtl8723bs_config-pine64.bin.
> 
> We already have 'firmware-name' defined and I'd prefer not to have
> another way to do things. The difference is just you have to give the
> full filename.
> 

Hi Rob,

I'm working on a v2 for this patchset and I've looked on how using "firmware-
name" with the full filename would be possible but as David Summers has already 
written [1], the existing code [2] takes this "postfix" as parameter and 
basically fills it into a filename template ("${CFG_NAME}-${POSTFIX}.bin"). So 
either we stay with the "firmware-postfix" property or the existing code would 
have to be modified to accomodate the full filename; but if using firmware-postfix 
is unacceptable, I can rework the existing code.

Luca

[1] https://lore.kernel.org/netdev/d06e3c30-a34a-bd84-9cdf-535f253843e3@davidjohnsummers.uk/
[2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/
drivers/bluetooth/btrtl.c#n566

[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2019-06-02  9:33 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-18 17:02 [PATCH 0/8] Add support for rtl8723bs/rtl8723cs bluetooth Vasily Khoruzhick
2019-01-18 17:02 ` [PATCH 1/8] Bluetooth: Add new quirk for broken local ext features max_page Vasily Khoruzhick
2019-01-18 17:02 ` [PATCH 2/8] Bluetooth: hci_h5: Add support for reset GPIO Vasily Khoruzhick
2019-01-18 17:13   ` Chen-Yu Tsai
2019-01-18 17:02 ` [PATCH 3/8] dt-bindings: net: bluetooth: Add rtl8723bs-bluetooth Vasily Khoruzhick
2019-02-18 21:10   ` Rob Herring
2019-02-18 21:24     ` Vasily Khoruzhick
2019-02-18 22:08       ` Stefan Wahren
2019-02-18 22:10         ` Stefan Wahren
2019-02-18 22:28         ` Vasily Khoruzhick
2019-02-19 14:17           ` Rob Herring
2019-02-19 21:09             ` David Summers
2019-02-20  2:59               ` Chen-Yu Tsai
2019-02-22 19:14           ` David Summers
2019-02-22 19:21             ` Vasily Khoruzhick
2019-02-23 20:16               ` David Summers
2019-03-01 20:15               ` Martin Blumenstingl
2019-03-02  9:28                 ` 答复: " 陆朱伟
2019-03-02 16:43                   ` Martin Blumenstingl
2019-03-04  5:17                     ` 答复: " 陆朱伟
2019-02-19  8:56       ` Stefan Wahren
2019-02-19 14:14       ` Rob Herring
2019-02-19 21:25         ` Vasily Khoruzhick
2019-06-02  9:33         ` Luca Weiss [this message]
2019-01-18 17:02 ` [PATCH 4/8] Bluetooth: hci_h5: Add support for binding RTL8723BS with device tree Vasily Khoruzhick
2019-01-21 14:44   ` kbuild test robot
2019-01-21 15:09   ` kbuild test robot
2019-01-18 17:02 ` [PATCH 5/8] Bluetooth: btrtl: add support for the RTL8723CS Vasily Khoruzhick
2019-01-21 14:31   ` kbuild test robot
2019-01-18 17:02 ` [PATCH 6/8] arm64: allwinner: a64: enable Bluetooth On Pinebook Vasily Khoruzhick
2019-01-18 17:02 ` [PATCH 7/8] DO-NOT-MERGE: arm64: allwinner: a64: enable Bluetooth On Pine64 Vasily Khoruzhick
2019-01-18 17:02 ` [PATCH 8/8] DO-NOT-MERGE: arm64: allwinner: a64: enable Bluetooth On SoPine baseboard Vasily Khoruzhick

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3444508.DTbMFtmaYk@g550jk \
    --to=luca@z3ntu.xyz \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=johan.hedberg@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=marcel@holtmann.org \
    --cc=mark.rutland@arm.com \
    --cc=maxime.ripard@bootlin.com \
    --cc=netdev@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).