From: Krzysztof Kozlowski <krzk@kernel.org>
To: "André Draszik" <andre.draszik@linaro.org>,
"Lee Jones" <lee@kernel.org>, "Rob Herring" <robh@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Sylwester Nawrocki" <s.nawrocki@samsung.com>,
"Chanwoo Choi" <cw00.choi@samsung.com>,
"Alim Akhtar" <alim.akhtar@samsung.com>,
"Michael Turquette" <mturquette@baylibre.com>,
"Stephen Boyd" <sboyd@kernel.org>,
"Russell King" <linux@armlinux.org.uk>,
"Catalin Marinas" <catalin.marinas@arm.com>,
"Will Deacon" <will@kernel.org>,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>
Cc: Peter Griffin <peter.griffin@linaro.org>,
Tudor Ambarus <tudor.ambarus@linaro.org>,
Will McVicker <willmcvicker@google.com>,
kernel-team@android.com, linux-kernel@vger.kernel.org,
linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rtc@vger.kernel.org
Subject: Re: [PATCH v3 14/32] mfd: sec: s2dos05/s2mpu05: use explicit regmap config and drop default
Date: Sun, 6 Apr 2025 20:19:03 +0200 [thread overview]
Message-ID: <346760fe-0595-4821-a5b4-0acfe4fc86cb@kernel.org> (raw)
In-Reply-To: <20250403-s2mpg10-v3-14-b542b3505e68@linaro.org>
On 03/04/2025 10:59, André Draszik wrote:
> When support for PMICs without compatibles was removed in
> commit f736d2c0caa8 ("mfd: sec: Remove PMICs without compatibles"),
> sec_regmap_config effectively became an orphan, because S5M8763X was
> the only user left of it before removal, using the default: case of the
> switch statement.
>
> When s2dos05 and s2mpu05 support was added in commit bf231e5febcf
> ("mfd: sec-core: Add support for the Samsung s2dos05") and commit
> ed33479b7beb ("mfd: sec: Add support for S2MPU05 PMIC"), they ended up
> using that orphaned regmap_config in a non-obvious way due to the
> default: case of the device type switch matching statement taking
> effect again.
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-04-06 18:23 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-03 8:58 [PATCH v3 00/32] Samsung S2MPG10 PMIC MFD-based drivers André Draszik
2025-04-03 8:58 ` [PATCH v3 01/32] dt-bindings: mfd: samsung,s2mps11: add s2mpg10 André Draszik
2025-04-04 12:08 ` Krzysztof Kozlowski
2025-04-03 8:58 ` [PATCH v3 02/32] dt-bindings: clock: " André Draszik
2025-04-03 8:58 ` [PATCH v3 03/32] dt-bindings: firmware: google,gs101-acpm-ipc: add PMIC child node André Draszik
2025-04-04 12:09 ` Krzysztof Kozlowski
2025-04-03 8:58 ` [PATCH v3 04/32] mfd: sec: drop non-existing forward declarations André Draszik
2025-04-03 8:58 ` [PATCH v3 05/32] mfd: sec: sort includes alphabetically André Draszik
2025-04-06 18:14 ` Krzysztof Kozlowski
2025-04-03 8:58 ` [PATCH v3 06/32] mfd: sec: update includes to add missing and remove superfluous ones André Draszik
2025-04-06 18:15 ` Krzysztof Kozlowski
2025-04-03 8:58 ` [PATCH v3 07/32] mfd: sec: move private internal API to internal header André Draszik
2025-04-03 8:59 ` [PATCH v3 08/32] mfd: sec: split into core and transport (i2c) drivers André Draszik
2025-04-06 18:16 ` Krzysztof Kozlowski
2025-04-03 8:59 ` [PATCH v3 09/32] mfd: sec: add support for S2MPG10 PMIC André Draszik
2025-04-04 9:18 ` Lee Jones
2025-04-07 8:55 ` André Draszik
2025-04-03 8:59 ` [PATCH v3 10/32] mfd: sec: merge separate core and irq modules André Draszik
2025-04-04 9:21 ` Lee Jones
2025-04-05 13:45 ` André Draszik
2025-04-03 8:59 ` [PATCH v3 11/32] mfd: sec: fix open parenthesis alignment (multiple) André Draszik
2025-04-04 9:27 ` Lee Jones
2025-04-03 8:59 ` [PATCH v3 12/32] mfd: sec: sort struct of_device_id entries and the device type switch André Draszik
2025-04-03 8:59 ` [PATCH v3 13/32] mfd: sec: use dev_err_probe() where appropriate André Draszik
2025-04-03 8:59 ` [PATCH v3 14/32] mfd: sec: s2dos05/s2mpu05: use explicit regmap config and drop default André Draszik
2025-04-06 18:19 ` Krzysztof Kozlowski [this message]
2025-04-03 8:59 ` [PATCH v3 15/32] mfd: sec: s2dos05: doesn't support interrupts (it seems) André Draszik
2025-04-04 9:34 ` Lee Jones
2025-04-03 8:59 ` [PATCH v3 16/32] mfd: sec: don't ignore errors from sec_irq_init() André Draszik
2025-04-03 8:59 ` [PATCH v3 17/32] mfd: sec: rework platform data and regmap instantiating André Draszik
2025-04-06 18:22 ` Krzysztof Kozlowski
2025-04-03 8:59 ` [PATCH v3 18/32] mfd: sec: change device_type to int André Draszik
2025-04-03 8:59 ` [PATCH v3 19/32] mfd: sec: don't compare against NULL / 0 for errors, use ! André Draszik
2025-04-03 8:59 ` [PATCH v3 20/32] mfd: sec: use sizeof(*var), not sizeof(struct type_of_var) André Draszik
2025-04-03 8:59 ` [PATCH v3 21/32] mfd: sec: convert to using MFD_CELL macros André Draszik
2025-04-03 8:59 ` [PATCH v3 22/32] mfd: sec: convert to using REGMAP_IRQ_REG() macros André Draszik
2025-04-03 8:59 ` [PATCH v3 23/32] mfd: sec: add myself as module author André Draszik
2025-04-04 9:42 ` Lee Jones
2025-04-05 13:49 ` André Draszik
2025-04-03 8:59 ` [PATCH v3 24/32] clk: s2mps11: add support for S2MPG10 PMIC clock André Draszik
2025-04-06 18:28 ` Krzysztof Kozlowski
2025-04-03 8:59 ` [PATCH v3 25/32] rtc: s5m: cache value of platform_get_device_id() during probe André Draszik
2025-04-06 18:29 ` Krzysztof Kozlowski
2025-04-07 11:04 ` André Draszik
2025-04-03 8:59 ` [PATCH v3 26/32] rtc: s5m: prepare for external regmap André Draszik
2025-04-06 18:30 ` Krzysztof Kozlowski
2025-04-03 8:59 ` [PATCH v3 27/32] rtc: s5m: add support for S2MPG10 RTC André Draszik
2025-04-06 18:33 ` Krzysztof Kozlowski
2025-04-07 9:34 ` André Draszik
2025-04-03 8:59 ` [PATCH v3 28/32] rtc: s5m: fix a typo: peding -> pending André Draszik
2025-04-06 18:33 ` Krzysztof Kozlowski
2025-04-03 8:59 ` [PATCH v3 29/32] rtc: s5m: switch to devm_device_init_wakeup André Draszik
2025-04-06 18:34 ` Krzysztof Kozlowski
2025-04-03 8:59 ` [PATCH v3 30/32] rtc: s5m: replace regmap_update_bits with regmap_clear/set_bits André Draszik
2025-04-06 18:35 ` Krzysztof Kozlowski
2025-04-03 8:59 ` [PATCH v3 31/32] rtc: s5m: replace open-coded read/modify/write registers with regmap helpers André Draszik
2025-04-03 8:59 ` [PATCH v3 32/32] MAINTAINERS: add myself as reviewer for Samsung S2M MFD André Draszik
2025-04-03 9:13 ` [PATCH v3 00/32] Samsung S2MPG10 PMIC MFD-based drivers Krzysztof Kozlowski
2025-04-04 9:30 ` Lee Jones
2025-04-05 14:29 ` André Draszik
2025-04-04 9:43 ` Lee Jones
2025-04-05 13:51 ` André Draszik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=346760fe-0595-4821-a5b4-0acfe4fc86cb@kernel.org \
--to=krzk@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=alim.akhtar@samsung.com \
--cc=andre.draszik@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=conor+dt@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=kernel-team@android.com \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mturquette@baylibre.com \
--cc=peter.griffin@linaro.org \
--cc=robh@kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=sboyd@kernel.org \
--cc=tudor.ambarus@linaro.org \
--cc=will@kernel.org \
--cc=willmcvicker@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).