From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5697C433DF for ; Mon, 29 Jun 2020 16:46:59 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B165B2559E for ; Mon, 29 Jun 2020 16:46:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="1DNk5w+e"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RXfK6rQ+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B165B2559E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=zCvpEi2DziDjkM63mBYp9k31Wky15vHbQMB1tQ2mIlw=; b=1DNk5w+eLLVWUYkCee04nBtoU /041Xyt/tWcBBXaNY5LqMdyudy9hi35Rq1rAWrf8tM/Lxd0cJjJnDTHWUfCc3CEHXPnBXUxxUvZSY /Bh2NKMBbDrxj5HkiCI6lg1467xpbcWX+K0mY5g+QKD1SusseBHWHaviL5i0BSUp6iR07PqOE1Riw bBqqBMOLmX1E9RarwskfWcYt8ZP1VzxMnoMB+/zYiJ8H0CyOOTfWw6F2p09aVlmgQ4w+F39iIJ8l1 Pcd6XGRG/cTQ+xmbFowMSKHyn2t4AM5OE5VTNOdSRDUPdPWNj+qc/DmamWboww9SBbmPWxcCO5yxD Z6b+6bT2g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jpwuN-0006Ng-PU; Mon, 29 Jun 2020 16:45:28 +0000 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jpwuI-0006MW-V4 for linux-arm-kernel@lists.infradead.org; Mon, 29 Jun 2020 16:45:24 +0000 Received: by mail-wr1-x441.google.com with SMTP id g18so17249749wrm.2 for ; Mon, 29 Jun 2020 09:45:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=u9fUuABIS2EcFjNrVGvmrkgcrL3UypNwy9u+b06+fm8=; b=RXfK6rQ+SzRHAAVPuZgSCcwjrzUnceasBHQrhHMlYQ5I1SwpWIBR7DK1d9z7HkvSKk MEVg1EeIlqmjYTk5OsFBriXDewcGgPjdcNafq5kaZpPfePyEgRPZ9KR/zL8lyFUCczsQ fiExr9g3JvIkRHCN4gf/kV7o6tI1lGDyqRUhkanPryvVXw1bR3kmf0rsFUEju8am7/2o acuoJOCiMPtfkQ7D4wkqcUG6x3gCNCcsrnehQs1HTEiitZpPTqeKgDEHzc4SsrmYh7qT V8kuot39HNtGZAe2xXp6kdzpSV1Fyy0OAUiP6MDKv4mmLUHNtkngmP/upBmbE0yXLUev PKRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=u9fUuABIS2EcFjNrVGvmrkgcrL3UypNwy9u+b06+fm8=; b=anViMtCBRsShpLIWy6io6/tGcw2LNXmwKdnBJpWEh6ds8e4KqgrfUGWL7HIPEcYw9u 6QL8bsmexMqeWqziWmt7V8bCG30LN24VnOacjU3jYZjyjKZllNUr0q8cyFIOYQsSCTtY LjmiMiiClCsjgUpe8D+xKrpDZ16D1t0wfjVBbjz1e6yIdUkGdhLK1pBgWPwFNRrmI5K3 aRROT7WETAq15AkT7/1AzCsErS02vDKKN4+N4VlrXUc6g3E4qKoKofWG0BjwxDvBXtPx CMiXgCHI34hY5hvepXMkdHZaG6e1JhvJ2GhKXlrEKfXaQZTv1DrFLt3sZ1YPRfHtso8N t1gQ== X-Gm-Message-State: AOAM530VcpEQ13gd3tIr9idxNS4rT9rjOAMocBRnLeUKND7unjPs9thR fFVtQ1CVT9n9Sng7Ej3KHMM= X-Google-Smtp-Source: ABdhPJwgDtmaZGJrtNa0zEf2BklM+msP3P7Rk7sYX4yUbVAN3Av14f+0EZj5nhMLZ6sMh6IJblncLA== X-Received: by 2002:adf:f608:: with SMTP id t8mr18108260wrp.308.1593449121909; Mon, 29 Jun 2020 09:45:21 -0700 (PDT) Received: from [10.230.30.107] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id p29sm438013wmi.43.2020.06.29.09.45.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 Jun 2020 09:45:21 -0700 (PDT) Subject: Re: [PATCH 1/4] pwm: bcm-iproc: Remove impossible comparison when validating duty cycle To: Lee Jones , thierry.reding@gmail.com, u.kleine-koenig@pengutronix.de, linux-pwm@vger.kernel.org References: <20200629124752.1018358-1-lee.jones@linaro.org> <20200629124752.1018358-2-lee.jones@linaro.org> From: Florian Fainelli Message-ID: <3470e941-aa86-11a8-674b-5258a08fedb1@gmail.com> Date: Mon, 29 Jun 2020 09:45:17 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Firefox/68.0 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <20200629124752.1018358-2-lee.jones@linaro.org> Content-Language: en-US X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Scott Branden , Ray Jui , linux-kernel@vger.kernel.org, Yendapally Reddy Dhananjaya Reddy , bcm-kernel-feedback-list@broadcom.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 6/29/2020 5:47 AM, Lee Jones wrote: > 'duty' here is an unsigned int, thus checking for <0 will always > evaluate to false. > > Fixes the following W=1 warning: > > drivers/pwm/pwm-bcm-iproc.c:147:12: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits] > > Cc: Ray Jui > Cc: Scott Branden > Cc: Yendapally Reddy Dhananjaya Reddy > Cc: bcm-kernel-feedback-list@broadcom.com > Cc: linux-pwm@vger.kernel.org > Signed-off-by: Lee Jones And IPROC_PWM_DUTY_CYCLE_MIN is unused after remove this single use of the define, if you also remove it you can add: Reviewed-by: Florian Fainelli -- Florian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel