From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC][PATCH 7/7] USB: OHCI: make ohci-s3c2410 a separate driver
Date: Fri, 07 Jun 2013 15:56:08 +0200 [thread overview]
Message-ID: <3472823.JjiFtr34DX@wuerfel> (raw)
In-Reply-To: <1370585013-12809-8-git-send-email-manjunath.goudar@linaro.org>
On Friday 07 June 2013 11:33:33 Manjunath Goudar wrote:
>
> + ohci_setup(hcd);
> s3c2410_start_hc(dev, hcd);
>
> - ohci_hcd_init(hcd_to_ohci(hcd));
> -
I'm not sure about this part: s3c2410_start_hc is where the clock gets
enabled, presumable we are not supposed to touch the ohci registers
before it gets called, so ohci_init() being called implicitly
by ohci_setup() seems like a bad idea.
Arnd
next prev parent reply other threads:[~2013-06-07 13:56 UTC|newest]
Thread overview: 110+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-07 6:03 [RFC][PATCH 0/7] USB: OHCI: more bus glues as separate modules Manjunath Goudar
2013-06-07 6:03 ` [RFC][PATCH 1/7] USB: OHCI: make ohci-exynos a separate driver Manjunath Goudar
2013-06-07 13:49 ` Arnd Bergmann
2013-06-07 17:20 ` Alan Stern
2013-06-07 6:03 ` [RFC][PATCH 2/7] USB: OHCI: make ohci-omap " Manjunath Goudar
2013-06-07 17:37 ` Alan Stern
2013-06-07 6:03 ` [RFC][PATCH 3/7] USB: OHCI: make ohci-omap3 " Manjunath Goudar
2013-06-07 13:51 ` Arnd Bergmann
2013-06-07 17:49 ` Alan Stern
2013-06-07 6:03 ` [RFC][PATCH 4/7] USB: OHCI: make ohci-spear " Manjunath Goudar
2013-06-07 10:30 ` Viresh Kumar
2013-06-07 18:34 ` Alan Stern
2013-06-07 6:03 ` [RFC][PATCH 5/7] USB: OHCI: export ohci_hub_control and ohci_hub_status_data Manjunath Goudar
2013-06-07 18:42 ` Alan Stern
2013-06-07 6:03 ` [RFC][PATCH 6/7] USB: OHCI: make ohci-at91 a separate driver Manjunath Goudar
2013-06-07 18:52 ` Alan Stern
2013-06-07 6:03 ` [RFC][PATCH 7/7] USB: OHCI: make ohci-s3c2410 " Manjunath Goudar
2013-06-07 13:56 ` Arnd Bergmann [this message]
2013-06-07 18:54 ` Alan Stern
2013-06-12 15:53 ` [PATCH V2 0/6] USB: OHCI: more bus glues as separate modules Manjunath Goudar
2013-06-12 15:53 ` [PATCH V2 1/6] USB: OHCI: make ohci-exynos a separate driver Manjunath Goudar
2013-06-18 17:30 ` Alan Stern
2013-06-20 4:10 ` Jingoo Han
2013-06-12 15:53 ` [PATCH V2 2/6] USB: OHCI: make ohci-omap " Manjunath Goudar
2013-06-18 17:47 ` Alan Stern
2013-06-18 18:13 ` Alan Stern
2013-06-12 15:53 ` [PATCH V2 3/6] USB: OHCI: make ohci-omap3 " Manjunath Goudar
2013-06-18 18:16 ` Alan Stern
2013-06-12 15:54 ` [PATCH V2 4/6] USB: OHCI: make ohci-spear " Manjunath Goudar
2013-06-18 18:23 ` Alan Stern
2013-06-12 15:54 ` [PATCH V2 5/6] USB: OHCI: make ohci-at91 " Manjunath Goudar
2013-06-19 20:16 ` Alan Stern
2013-06-12 15:54 ` [PATCH V2 6/6] USB: OHCI: make ohci-s3c2410 " Manjunath Goudar
2013-06-19 20:38 ` Alan Stern
2013-06-25 6:23 ` [PATCH V3 0/6] USB: OHCI: more bus glues as separate modules Manjunath Goudar
2013-06-25 6:23 ` [PATCH V3 1/6] USB: OHCI: make ohci-exynos a separate driver Manjunath Goudar
2013-06-25 6:23 ` [PATCH V3 2/6] USB: OHCI: make ohci-omap " Manjunath Goudar
2013-07-18 15:50 ` Alan Stern
2013-06-25 6:23 ` [PATCH V3 3/6] USB: OHCI: make ohci-omap3 " Manjunath Goudar
2013-06-25 18:14 ` Alan Stern
2013-06-25 6:23 ` [PATCH V3 4/6] USB: OHCI: make ohci-spear " Manjunath Goudar
2013-06-25 6:23 ` [PATCH V3 5/6] USB: OHCI: make ohci-at91 " Manjunath Goudar
2013-07-18 20:51 ` Alan Stern
2013-06-25 6:23 ` [PATCH V3 6/6] USB: OHCI: make ohci-s3c2410 " Manjunath Goudar
2013-07-18 20:38 ` Alan Stern
2013-07-22 9:19 ` [PATCH 0/6] USB: OHCI: more bus glues as separate modules Manjunath Goudar
2013-07-22 9:19 ` [PATCH 1/6] USB: OHCI: make ohci-exynos a separate driver Manjunath Goudar
2013-07-22 9:19 ` [PATCH 2/6] USB: OHCI: make ohci-omap " Manjunath Goudar
2013-07-23 18:39 ` Alan Stern
2013-07-22 9:19 ` [PATCH 3/6] USB: OHCI: make ohci-omap3 " Manjunath Goudar
2013-07-23 18:43 ` Alan Stern
2013-07-22 9:19 ` [PATCH 4/6] USB: OHCI: make ohci-spear " Manjunath Goudar
2013-07-22 9:19 ` [PATCH 5/6] USB: OHCI: make ohci-at91 " Manjunath Goudar
2013-07-23 18:45 ` Alan Stern
2013-07-22 9:19 ` [PATCH 6/6] USB: OHCI: make ohci-s3c2410 " Manjunath Goudar
2013-07-23 8:23 ` Tomasz Figa
2013-07-22 9:41 ` [PATCH V4 0/6] USB: OHCI: more bus glues as separate modules manjunath
2013-07-31 6:07 ` Manjunath Goudar
2013-07-31 6:07 ` [PATCH V4 1/6] USB: OHCI: make ohci-exynos a separate driver Manjunath Goudar
2013-07-31 6:08 ` [PATCH V4 2/6] USB: OHCI: make ohci-omap " Manjunath Goudar
2013-07-31 6:08 ` [PATCH V4 3/6] USB: OHCI: make ohci-omap3 " Manjunath Goudar
2013-07-31 6:08 ` [PATCH V4 4/6] USB: OHCI: make ohci-spear " Manjunath Goudar
2013-07-31 6:08 ` [PATCH V4 5/6] USB: OHCI: make ohci-at91 " Manjunath Goudar
2013-07-31 6:08 ` [PATCH V4 6/6] USB: OHCI: make ohci-s3c2410 " Manjunath Goudar
2013-08-10 7:37 ` [PATCH V4 0/6] USB: OHCI: more bus glues as separate modules Manjunath Goudar
2013-08-10 7:37 ` [PATCH V4 1/6] USB: OHCI: make ohci-exynos a separate driver Manjunath Goudar
2013-08-10 7:37 ` [PATCH V4 2/6] USB: OHCI: make ohci-omap " Manjunath Goudar
2013-08-10 7:37 ` [PATCH V4 3/6] USB: OHCI: make ohci-omap3 " Manjunath Goudar
2013-08-10 7:37 ` [PATCH V4 4/6] USB: OHCI: make ohci-spear " Manjunath Goudar
2013-08-10 7:37 ` [PATCH V4 5/6] USB: OHCI: make ohci-at91 " Manjunath Goudar
2013-08-10 7:37 ` [PATCH V4 6/6] USB: OHCI: make ohci-s3c2410 " Manjunath Goudar
2013-08-10 10:53 ` Tomasz Figa
2013-08-12 6:46 ` [PATCH V5 0/6]USB: OHCI: more bus glues as separate modules Manjunath Goudar
2013-08-12 6:46 ` [PATCH V5 1/6] USB: OHCI: make ohci-exynos a separate driver Manjunath Goudar
2013-08-12 6:46 ` [PATCH V5 2/6] USB: OHCI: make ohci-omap " Manjunath Goudar
2013-08-12 6:46 ` [PATCH V5 3/6] USB: OHCI: make ohci-omap3 " Manjunath Goudar
2013-08-12 6:46 ` [PATCH V5 4/6] USB: OHCI: make ohci-spear " Manjunath Goudar
2013-08-12 6:56 ` Viresh Kumar
2013-08-12 20:20 ` Greg KH
2013-08-12 6:46 ` [PATCH V5 5/6] USB: OHCI: make ohci-at91 " Manjunath Goudar
2013-08-12 6:47 ` [PATCH V5 6/6] USB: OHCI: make ohci-s3c2410 " Manjunath Goudar
2013-08-17 13:21 ` Tomasz Figa
2013-08-12 6:54 ` [PATCH V5 0/6]USB: OHCI: more bus glues as separate modules Viresh Kumar
2013-09-16 10:10 ` [PATCH V5 0/9] USB: " Manjunath Goudar
2013-09-16 10:10 ` [PATCH V5 1/9] USB: OHCI: make ohci-exynos a separate driver Manjunath Goudar
2013-09-16 10:10 ` [PATCH V5 2/9] USB: OHCI: make ohci-omap " Manjunath Goudar
2013-09-16 10:10 ` [PATCH V5 3/9] USB: OHCI: make ohci-omap3 " Manjunath Goudar
2013-09-16 10:10 ` [PATCH V5 4/9] USB: OHCI: make ohci-spear " Manjunath Goudar
2013-09-16 10:10 ` [PATCH V5 5/9] USB: OHCI: make ohci-at91 " Manjunath Goudar
2013-09-16 10:10 ` [PATCH V5 6/9] USB: OHCI: make ohci-s3c2410 " Manjunath Goudar
2013-09-16 10:10 ` [PATCH V5 7/9] USB: OHCI: make ohci-nxp " Manjunath Goudar
2013-09-16 10:10 ` [PATCH V5 8/9] USB: OHCI: make ohci-ep93xx " Manjunath Goudar
2013-09-16 10:10 ` [PATCH V5 9/9] USB: OHCI: make ohci-pxa27x " Manjunath Goudar
2013-09-21 11:08 ` [PATCH V5 0/9] USB: OHCI: more bus glues as separate modules Manjunath Goudar
2013-09-21 11:08 ` [PATCH V5 1/9] USB: OHCI: make ohci-exynos a separate driver Manjunath Goudar
2013-09-26 16:50 ` Greg KH
2013-09-21 11:08 ` [PATCH V5 2/9] USB: OHCI: make ohci-omap " Manjunath Goudar
2013-09-21 11:08 ` [PATCH V5 3/9] USB: OHCI: make ohci-omap3 " Manjunath Goudar
2013-09-21 11:08 ` [PATCH V5 4/9] USB: OHCI: make ohci-spear " Manjunath Goudar
2013-09-21 11:08 ` [PATCH V5 5/9] USB: OHCI: make ohci-at91 " Manjunath Goudar
2013-09-23 12:22 ` Nicolas Ferre
2013-09-27 15:10 ` Kevin Hilman
2013-09-27 15:25 ` Greg KH
2013-09-27 15:37 ` Alan Stern
2013-09-27 15:40 ` Greg KH
2013-09-27 15:38 ` Alan Stern
2013-09-21 11:08 ` [PATCH V5 6/9] USB: OHCI: make ohci-s3c2410 " Manjunath Goudar
2013-09-21 11:08 ` [PATCH V5 7/9] USB: OHCI: make ohci-nxp " Manjunath Goudar
2013-09-21 11:08 ` [PATCH V5 8/9] USB: OHCI: make ohci-ep93xx " Manjunath Goudar
2013-09-21 11:08 ` [PATCH V5 9/9] USB: OHCI: make ohci-pxa27x " Manjunath Goudar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3472823.JjiFtr34DX@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox