From: Nicolas Frattaroli <frattaroli.nicolas@gmail.com>
To: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>, Heiko Stuebner <heiko@sntech.de>,
Nicolas Frattaroli <frattaroli.nicolas@gmail.com>
Cc: linux-rockchip@lists.infradead.org, alsa-devel@alsa-project.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] ASoC: rockchip: i2s_tdm: Add support for RK3588
Date: Tue, 25 Oct 2022 14:43:45 +0200 [thread overview]
Message-ID: <3478206.uukdV1xfrs@archbook> (raw)
In-Reply-To: <20221025124132.399729-5-frattaroli.nicolas@gmail.com>
On Dienstag, 25. Oktober 2022 14:41:32 CEST Nicolas Frattaroli wrote:
> This adds support for the RK3588 SoC to the I2S/TDM driver.
> ---
> sound/soc/rockchip/rockchip_i2s_tdm.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/sound/soc/rockchip/rockchip_i2s_tdm.c b/sound/soc/rockchip/rockchip_i2s_tdm.c
> index 917f17107891..08b90ec5cc80 100644
> --- a/sound/soc/rockchip/rockchip_i2s_tdm.c
> +++ b/sound/soc/rockchip/rockchip_i2s_tdm.c
> @@ -1318,6 +1318,7 @@ static const struct of_device_id rockchip_i2s_tdm_match[] = {
> { .compatible = "rockchip,rk1808-i2s-tdm", .data = &rk1808_i2s_soc_data },
> { .compatible = "rockchip,rk3308-i2s-tdm", .data = &rk3308_i2s_soc_data },
> { .compatible = "rockchip,rk3568-i2s-tdm", .data = &rk3568_i2s_soc_data },
> + { .compatible = "rockchip,rk3588-i2s-tdm" },
> { .compatible = "rockchip,rv1126-i2s-tdm", .data = &rv1126_i2s_soc_data },
> {},
> };
> @@ -1556,7 +1557,7 @@ static int rockchip_i2s_tdm_probe(struct platform_device *pdev)
> i2s_tdm->dev = &pdev->dev;
>
> of_id = of_match_device(rockchip_i2s_tdm_match, &pdev->dev);
> - if (!of_id || !of_id->data)
> + if (!of_id)
> return -EINVAL;
>
> spin_lock_init(&i2s_tdm->lock);
>
Oops, forgot the signoff on this one.
For this purpose:
Signed-off-by: Nicolas Frattaroli <frattaroli.nicolas@gmail.com>
My apologies.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-10-25 12:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-25 12:41 [PATCH 0/4] RK3588 Audio Support Nicolas Frattaroli
2022-10-25 12:41 ` [PATCH 1/4] ASoC: dt-bindings: rockchip: i2s-tdm: Make grf property optional Nicolas Frattaroli
2022-10-26 14:52 ` Krzysztof Kozlowski
2022-10-25 12:41 ` [PATCH 2/4] ASoC: rockchip: i2s_tdm: Make the " Nicolas Frattaroli
2022-10-25 12:41 ` [PATCH 3/4] ASoC: dt-bindings: rockchip: i2s-tdm: Add RK3588 compatible Nicolas Frattaroli
2022-10-26 14:52 ` Krzysztof Kozlowski
2022-10-25 12:41 ` [PATCH 4/4] ASoC: rockchip: i2s_tdm: Add support for RK3588 Nicolas Frattaroli
2022-10-25 12:43 ` Nicolas Frattaroli [this message]
2022-11-25 21:40 ` [PATCH 0/4] RK3588 Audio Support Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3478206.uukdV1xfrs@archbook \
--to=frattaroli.nicolas@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=heiko@sntech.de \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox