From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0129EC433ED for ; Thu, 13 May 2021 13:13:19 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9814E613AF for ; Thu, 13 May 2021 13:13:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9814E613AF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=H9Cpue1rM9xWjhNX1OsJVT+46rxsz3gpVnTHq7kDioQ=; b=lCe5PnvrTw3cmzysbdEKEnD2r 8vuW0DnpwETQ/G1y/auoJ1nYgjRi+p1PYcsPtClx79AzhW2LnnmzTqZFgf/W65w1s/suGSvvZ3k7k jR9Akk1Uj4uCEQ6JNwtWKtIoyP2jBWrqzZFgWPqwkVJR37tC2NaaPb58qV9CHWKrRAgiN0m3DKdvB N/wM5g0OuHAMVq3WpHPjlzx5LaeaB4D8TilrwnGq02MJ1D4M52P+fb1HAu/azN9YQhSqJ65YHE43l HqJz6kcVNjkCQqpu4NfaBcTdBq7kMVLjSHcFztLg27WlLL2laAXZDbjMd64/fYsKwbRvlTTogujeu +hkCWrY9A==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lhB7G-005aLu-Gf; Thu, 13 May 2021 13:11:02 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lhB7D-005aLk-G8 for linux-arm-kernel@desiato.infradead.org; Thu, 13 May 2021 13:10:59 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To: Subject:Sender:Reply-To:Content-ID:Content-Description; bh=3IBhZVHAXUzuFvnpGw077P1zLwaQVpGtbgDQ96r1yc0=; b=DADz9YLCyLOpijYkb4CLWrvAB8 KcB/+dxRGs/4eKxK+aokx3ZvKSDJOf9nFfB6REO+6fjBQGUEH26yRDUdIoyQibFTF8hpAyKySvXu9 ujaEpXAyC6QVH4xxrIoOKBOohy+Qs499ezsKESMymyWLSGA+SNLk7WP2Ws6XnAGkEkQ+VZ+HPtWnM O4/mPd2Ttym/D9VsCktgC6sflwSTuGSx84xx9S6w6MSOcuVpC1Dim7xt9IM8wKrqAlwU8w1iEPO1g pHfbEbdi7Np6bPM7mFqT53iQLWb2d+/FeAuwQBk8T6WcMjrufKxM5ldCByoeFNVxwEA1202OtHyhP JIOeigFA==; Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lhB7A-00BGEs-Qs for linux-arm-kernel@lists.infradead.org; Thu, 13 May 2021 13:10:58 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id ED629ED1; Thu, 13 May 2021 06:10:50 -0700 (PDT) Received: from [10.57.81.122] (unknown [10.57.81.122]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 665753F73B; Thu, 13 May 2021 06:10:48 -0700 (PDT) Subject: Re: [RFC PATCH] perf cs-etm: Handle valid-but-zero timestamps To: Leo Yan Cc: coresight@lists.linaro.org, mathieu.poirier@linaro.org, al.grant@arm.com, branislav.rankov@arm.com, denik@chromium.org, suzuki.poulose@arm.com, anshuman.khandual@arm.com, Mike Leach , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , John Garry , Will Deacon , linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210507095814.17933-1-james.clark@arm.com> <3926c523-3fdb-66de-8b9c-b68290a5053e@arm.com> <20210510053904.GB4835@leoy-ThinkPad-X240s> <20210512020826.GC249068@leoy-ThinkPad-X240s> From: James Clark Message-ID: <347cb510-0057-4687-5b29-22568d228b7a@arm.com> Date: Thu, 13 May 2021 16:10:47 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210512020826.GC249068@leoy-ThinkPad-X240s> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210513_061056_950109_EC744F9E X-CRM114-Status: GOOD ( 15.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 12/05/2021 05:08, Leo Yan wrote: > On Tue, May 11, 2021 at 04:53:35PM +0300, James Clark wrote: > > [...] > >> /* First get the packet queue for this traceID */ >> packet_queue = cs_etm__etmq_get_packet_queue(etmq, trace_chan_id); >> @@ -320,7 +323,20 @@ cs_etm_decoder__do_hard_timestamp(struct cs_etm_queue *etmq, >> * which instructions started by subtracting the number of instructions >> * executed to the timestamp. >> */ >> - packet_queue->timestamp = elem->timestamp - packet_queue->instr_count; >> + if (!elem->timestamp) { >> + packet_queue->timestamp = 0; >> + if (!warned_timestamp_zero) { >> + pr_err("Zero Coresight timestamp found at Idx:%" OCSD_TRC_IDX_STR >> + ". Decoding may be improved with --itrace=Z...\n", indx); >> + warned_timestamp_zero = true; >> + } >> + } >> + else if (packet_queue->instr_count >= elem->timestamp) { > > Nitpick: I personally think should use the condition ">" rather than ">=". Yes, good catch. I actually changed this because I realised that if they are equal it shouldn't print an error. > >> + packet_queue->timestamp = 0; >> + pr_err("Timestamp calculation underflow at Idx:%" OCSD_TRC_IDX_STR "\n", indx); >> + } >> + else >> + packet_queue->timestamp = elem->timestamp - packet_queue->instr_count; > > Nitpick for coding style, as described in > Documentation/process/coding-style.rst, section "3) Placing Braces and > Spaces", so here should use braces with the format: Ok I will update and run it through checkpatch.pl before posting. [...] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel