From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BF2D3C74A5B for ; Sun, 26 Mar 2023 18:18:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zhR8qFSD9FK4UcxGPBZMI8xHkqxApLouOGHl9F7oesk=; b=ZBBuCfGxGBKP42 RGu8tJSMsNcUn+xtockozSA2U3mAldhcAfze8MegO/P6YD89j2n3if4ALzfVI0vSUIfDvgQ947q0u acbyTNng6K9WX7VoHRBm7Xkka7y/2xGCpaNjB/09MLGc30+CmnkzTxO2mLP9Zpj6ooReyqpEn3dDK XZ5SlAsif20c4vIPPsDUIlDaF28J3M+UnnJ/4oSGo3Rn20nXLQJYNkdC9KmUYMYkVi7fPZZvVJxOD UzZiIlqnvFd5YZSiEyWgRYkxIfZbgjgCnjtvYfEtiVL4+C0JpyQ3wkvT6WU2K+79sDv8gX+mr0xvg dYhkgA8H31Y2e/eXFTuw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pgUwI-008y7H-0p; Sun, 26 Mar 2023 18:17:58 +0000 Received: from mail-ed1-x52d.google.com ([2a00:1450:4864:20::52d]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pgUwF-008y5R-0c for linux-arm-kernel@lists.infradead.org; Sun, 26 Mar 2023 18:17:56 +0000 Received: by mail-ed1-x52d.google.com with SMTP id t10so26963772edd.12 for ; Sun, 26 Mar 2023 11:17:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679854671; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FnTsQUm6HhjATm02ksR3wp/Ety48QzTJBZ9lksbtOVs=; b=Hw4H00UoiUrwTuhkIy4J+TCrs2QhEwUE7rii1JKt13al9XnNSOvNrX3bQayx1liDbE eheNALQBp83JQS/e9mxrLYAwh+Tv4/rLHPWdJ47tZfc4rMdlHyqpmyCx8lu0zYcmYqk4 Qbg581Ljc8pPoe79vk2wHR8x8TJJoOWkG6A3+kzDbl4WG5Yx6pjUnAPOOySNm1sBZfQe drOG5wWrgVaFt+J/0btk/BKu+AGxJIlmMzztYSgU6zbn34YRnN7/UbZVZ1FWpoxWEe6C fqvLeQBnnhsbA1Itl5m2n7DVfL2e/OHinXzN073EO4YJLITmDgfB2rH7vv4b1EFwP62j EIEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679854671; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FnTsQUm6HhjATm02ksR3wp/Ety48QzTJBZ9lksbtOVs=; b=fbaVSRbC8dUzveZtKkThi3IaLFX74lNDFUA6JuzWdmEhUhSVRaq9+Vp1P49tqGwd0T MPrGL5ejBd5REisLjm753HjX+Mn2IdF7OD/9vHmxyxhSy88jutt9Umn2eOeRLM/ZbpGl 6MywcXSDJ+23aB9B417fy/I06xCWAzRq12OZuA3OvN5X4eFgQ8WIRq6JVthadAODXLRU BT8CcFDc5DYANp+QzpDOpbmcc8Tc0v5D8OLUq5bq+RXRL/p2yf2GZ8CJrPrcEvnWvhTN tvnLdauDpsAub26DonpfSynKngnzIQq/I0KNBZqOrbuQ/v5uhfG8RihJV/+QVlnpLzuL lPUA== X-Gm-Message-State: AAQBX9dJ8kP/7Xzume+L/74tu8QCC175r2LWD8YgQ28MzYmuc+8jhgzS +7aYSQts6dx3SOonIgchTU4= X-Google-Smtp-Source: AKy350bzwX2Okw452MLlLN3trK1J0tQJbXMqGx9csXq3pD9R5t41CwxzDxLp3qD2Y0tuUnKfA9LL3A== X-Received: by 2002:a17:906:5a94:b0:933:15c0:6e05 with SMTP id l20-20020a1709065a9400b0093315c06e05mr9470325ejq.7.1679854670654; Sun, 26 Mar 2023 11:17:50 -0700 (PDT) Received: from kista.localnet (82-149-1-233.dynamic.telemach.net. [82.149.1.233]) by smtp.gmail.com with ESMTPSA id q27-20020a50aa9b000000b004af73333d6esm13720731edc.53.2023.03.26.11.17.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Mar 2023 11:17:49 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Mauro Carvalho Chehab , Chen-Yu Tsai , Samuel Holland , Uwe =?ISO-8859-1?Q?Kleine=2DK=F6nig?= Cc: linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, kernel@pengutronix.de Subject: Re: [PATCH 082/117] media: sun8i-di: Convert to platform remove callback returning void Date: Sun, 26 Mar 2023 20:17:48 +0200 Message-ID: <3486523.iIbC2pHGDl@kista> In-Reply-To: <20230326143224.572654-85-u.kleine-koenig@pengutronix.de> References: <20230326143224.572654-1-u.kleine-koenig@pengutronix.de> <20230326143224.572654-85-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230326_111755_247247_AFF4E0C7 X-CRM114-Status: GOOD ( 11.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Dne nedelja, 26. marec 2023 ob 16:31:49 CEST je Uwe Kleine-K=F6nig napisal(= a): > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is (mostly) ignored > and this typically results in resource leaks. To improve here there is a > quest to make the remove callback return void. In the first step of this > quest all drivers are converted to .remove_new() which already returns > void. > = > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > = > Signed-off-by: Uwe Kleine-K=F6nig Acked-by: Jernej Skrabec Best regards, Jernej _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel