From: b.zolnierkie@samsung.com (Bartlomiej Zolnierkiewicz)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/4] ata: add new-style AHCI platform driver for DaVinci DA850 AHCI controller
Date: Thu, 20 Mar 2014 16:07:04 +0100 [thread overview]
Message-ID: <348852006.YgTlFegqas@amdc1032> (raw)
In-Reply-To: <2662651.GJX9HVKij5@amdc1032>
On Thursday, March 20, 2014 01:57:10 PM Bartlomiej Zolnierkiewicz wrote:
> > > +#define DA8XX_SYSCFG1_VIRT(x) (da8xx_syscfg1_base + (x))
> > > +#define DA8XX_PWRDN_REG 0x18
> > > +
> > > +/* SATA PHY Control Register offset from AHCI base */
> > > +#define SATA_P0PHYCR_REG 0x178
> > > +
> > > +#define SATA_PHY_MPY(x) ((x) << 0)
> > > +#define SATA_PHY_LOS(x) ((x) << 6)
> > > +#define SATA_PHY_RXCDR(x) ((x) << 10)
> > > +#define SATA_PHY_RXEQ(x) ((x) << 13)
> > > +#define SATA_PHY_TXSWING(x) ((x) << 19)
> > > +#define SATA_PHY_ENPLL(x) ((x) << 31)
> >
> > These can be replaced with BIT(N)
>
> OK, I'll fix it.
Uh, no, we can't use BIT() here.
BIT(N) does (1UL << (N)) and here we have ((N) << offset).
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
next prev parent reply other threads:[~2014-03-20 15:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-17 18:31 [PATCH 0/4] ata: add remaining new-style AHCI platform drivers Bartlomiej Zolnierkiewicz
2014-03-17 18:31 ` [PATCH 1/4] ata: ahci_platform: fix ahci_platform_data->suspend method handling Bartlomiej Zolnierkiewicz
2014-03-17 18:31 ` [PATCH 2/4] ata: move library code from ahci_platform.c to libahci_platform.c Bartlomiej Zolnierkiewicz
2014-03-17 18:31 ` [PATCH 3/4] ata: add new-style AHCI platform driver for DaVinci DA850 AHCI controller Bartlomiej Zolnierkiewicz
2014-03-20 8:11 ` Sekhar Nori
2014-03-20 12:57 ` Bartlomiej Zolnierkiewicz
2014-03-20 13:23 ` Sekhar Nori
2014-03-20 14:24 ` Bartlomiej Zolnierkiewicz
2014-03-20 15:07 ` Bartlomiej Zolnierkiewicz [this message]
2014-03-17 18:31 ` [PATCH 4/4] ata: add new-style AHCI platform driver for ST SPEAr1340 " Bartlomiej Zolnierkiewicz
2014-03-20 8:57 ` Pratyush Anand
2014-03-20 11:51 ` Bartlomiej Zolnierkiewicz
2014-03-17 18:57 ` [PATCH 0/4] ata: add remaining new-style AHCI platform drivers Tejun Heo
2014-03-17 19:18 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=348852006.YgTlFegqas@amdc1032 \
--to=b.zolnierkie@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox