public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: max.schwarz@online.de (Max Schwarz)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: rockchip: rk3188: enable pull-ups on UART inputs
Date: Sun, 23 Mar 2014 00:03:22 +0100	[thread overview]
Message-ID: <34897065.ss2WWxiNAl@xq-nb> (raw)
In-Reply-To: <2573614.4MaI90U1A8@diego>

Hi Heiko,

> ok, but as we change the default behaviour of the pin - and as we discussed
> above rightfully so, the commit message should reflect this and not describe
> a Radxa-Rock specific change. So would you be ok with something like:
> 
> ---------- 8< --------------------
> Subject: [PATCH] ARM: rockchip: rk3188: enable pull-ups on UART RX pins
> 
> The default behaviour of the uart-rx pins on the rk3188 is to be pulled up
> and a lot of designs use diodes to even prevent them from being raised from
> the outside.
> 
> Therefore change the rx-pin settings accordingly.
> 
> This also fixes a uart receive problem on mass production Radxa Rock boards.
> ---------- 8< --------------------

Yes, that sounds good to me. Thanks!

Cheers,
  Max

      reply	other threads:[~2014-03-22 23:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-09 19:43 [PATCH] ARM: rockchip: rk3188: enable pull-ups on UART inputs Max Schwarz
2014-03-13  0:36 ` Heiko Stübner
2014-03-13 19:25   ` Max Schwarz
2014-03-22 22:20     ` Heiko Stübner
2014-03-22 23:03       ` Max Schwarz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=34897065.ss2WWxiNAl@xq-nb \
    --to=max.schwarz@online.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox