From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AA8DFC433EF for ; Mon, 20 Jun 2022 18:29:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UwbcYzAv9jDsV/NsgoAEFFciuNV0bUENk/DWeHNO+yM=; b=vNNT4q0uA18k9D 8NxGbKyZCW1fMFxh3KUm4vB9Ja26W1x/ESO8+yuVgNurzjsKR/7KniZriNMkJ3d3q5cWmgPh8TcsN nwRsuA0mZTk+4pcM0+SCmfNfwmxI/G3V7A7M5i5vxWuyFEN3hGvVn5oHzDHFRDqtzTO8TdAGSNGQK sKFtFnvdBy+4Q+swGf6hTjj6LeqOE/YCgab51/RRiU4MITgwoDb5zq5l2pa3T60B9g4zt/O3dzTWQ OFNHLTjhtUl/bKD3fPY32h3ps+CLDTcZavvfdlIvA1lwIMvywsAKrrKxMxh0pc5xBm9xzSdQs3eIJ eAnkRJUdf5dMVDk5FzfQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o3M8p-001rYK-Vd; Mon, 20 Jun 2022 18:28:52 +0000 Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o3M8n-001rXj-AM for linux-arm-kernel@lists.infradead.org; Mon, 20 Jun 2022 18:28:50 +0000 Received: by mail-wr1-x42f.google.com with SMTP id g4so15771716wrh.11 for ; Mon, 20 Jun 2022 11:28:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=EbH61xgbcQFZqiKdtF3EiTrlMIA03mVcXgcJh8nFhYw=; b=mSQEmLJ0Fn5QVozsHIogGY5NXi+9CJYGRIz8gpuc1yRs1WXusV7NLcUOAPe/oDHd+p CGfunJlCmJ3FttTozAiBihvuQo80brGH5cxd7esS/dJ8+prrLrD9NYWnUklcB1Wn/L9D 4xSjQZ8Ht1+2KVRUzP+G9tpz8dK5qZdWFtEcKKIo3UWWd5lQCv7rPsKZhCW5toVy38+V HzYrtpJ5nPWn9oymuE5UJnlGqTc5qT4epprO+dTLcXI+5zwNJsTsQNUu7WMD9R9VluLf yzP0plxjqlwIb92S1XFNdmlBBMjgngHOZahcjJtaSnvziwMaVFoUKTmPGRSoHc1Y+Zlh 1dxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=EbH61xgbcQFZqiKdtF3EiTrlMIA03mVcXgcJh8nFhYw=; b=HZXT4Oqxn/IaQ1oDqkHgz75ahLfA7K2XSZVwvXf1jFcY2D45uxJ3SgwKtSnI3/8gNU 4m6Zruhn9CUCJaCScpjP6QurYd8B+podzmVliKgCocIikCPKrxtAZ10AyrQEMrA8XMx6 AlZSk5pztrsZOVVxpwjNv7Nk/S4k8GX3NhY75vy0gOtOwuTj1ywyzex5zrpECtHHw3Ux BnBCo9/3szli//Al029sAAzvbYZ/6jSN2rfnaN4FT5NWwmwaT5kGhd2tQun4lqE+fBEy x0nHEGpBZRX0HwUN976JnKALAyepdzA2jZrKcgIR6PWZWuNgaxI2aceWvs1488sA1WmX wjRQ== X-Gm-Message-State: AJIora98VpSjI4HMUUNd37tXLb6cXgMx0hH8IEIF4dy4v4TwGfYrqxhx wvjQyR7GLbGiRH+oedA9Rsmi+z9EP9s= X-Google-Smtp-Source: AGRyM1t14bVeWv+aaSXZzdp98dSIn+wgQmnAILYuJY07t+yPD4z3EwzouaR/YGr9cTVVtwEooMSWGA== X-Received: by 2002:a5d:584c:0:b0:218:4ee2:38fd with SMTP id i12-20020a5d584c000000b002184ee238fdmr24050138wrf.584.1655749727868; Mon, 20 Jun 2022 11:28:47 -0700 (PDT) Received: from kista.localnet (213-161-3-76.dynamic.telemach.net. [213.161.3.76]) by smtp.gmail.com with ESMTPSA id l8-20020a1ced08000000b0039744bd664esm19254682wmh.13.2022.06.20.11.28.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jun 2022 11:28:47 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Chen-Yu Tsai , Vinod Koul , Samuel Holland Cc: Samuel Holland , dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev Subject: Re: [PATCH] dmaengine: sun6i: Set the maximum segment size Date: Mon, 20 Jun 2022 20:28:46 +0200 Message-ID: <3494277.R56niFO833@kista> In-Reply-To: <20220617034209.57337-1-samuel@sholland.org> References: <20220617034209.57337-1-samuel@sholland.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220620_112849_428229_581348CD X-CRM114-Status: GOOD ( 17.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Dne petek, 17. junij 2022 ob 05:42:09 CEST je Samuel Holland napisal(a): > The sun6i DMA engine supports segment sizes up to 2^25-1 bytes. This is > explicitly stated in newer SoC documentation (H6, D1), and it is implied > in older documentation by the 25-bit width of the "bytes left in the > current segment" register field. At least A10 user manual says 128k max in description for Byte Counter register (0x100+N*0x20+0xC), although field size is defined as 23:0, but that's still less than 2^25-1. A20 supports only 128k too according to manual. New quirk should be introduced for this. Best regards, Jernej > > Exposing the real segment size limit (instead of the 64k default) > reduces the number of SG list segments needed for a transaction. > > Signed-off-by: Samuel Holland > --- > Tested on A64, verified that the maximum ALSA PCM period increased, and > that audio playback still worked. > > drivers/dma/sun6i-dma.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/dma/sun6i-dma.c b/drivers/dma/sun6i-dma.c > index b7557f437936..1425f87d97b7 100644 > --- a/drivers/dma/sun6i-dma.c > +++ b/drivers/dma/sun6i-dma.c > @@ -9,6 +9,7 @@ > > #include > #include > +#include > #include > #include > #include > @@ -1334,6 +1335,8 @@ static int sun6i_dma_probe(struct platform_device *pdev) > INIT_LIST_HEAD(&sdc->pending); > spin_lock_init(&sdc->lock); > > + dma_set_max_seg_size(&pdev->dev, DMA_BIT_MASK(25)); > + > dma_cap_set(DMA_PRIVATE, sdc->slave.cap_mask); > dma_cap_set(DMA_MEMCPY, sdc->slave.cap_mask); > dma_cap_set(DMA_SLAVE, sdc->slave.cap_mask); > -- > 2.35.1 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel