From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D6C88C05027 for ; Fri, 20 Jan 2023 12:10:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=G7vDHmPrmEzxM/W5IRLDeeEBuoRZXEnsMN2SBv0tk4o=; b=PE/BACYPNizQB2 QP32EeimM1YmrrQuTnzJdfyGghPARyTGSKKcC1y8WvxAY4uPJFze9QX3GfOGWjHhAgZDtpvh525aI 8ZiXXN2nB1bNW5E25cD6g3LgklPM4jl3e/tQjRcMhXOIhpATB6XVw9bfD2jw27c9XRR9h7VFPsaG3 1IjdOS8C9ppXQQ5Vs3JkTHOKjszS2xzj29cn2hjXeRpDo0MZhM7sDZgyxY8eInvUrJigPf77zgv5Z D7JT8wRuhDFXH8w8eAyCIgqVE0+nNuhj0q+hA4DXN/0Nb8N9qLHdvHKGEoxzYJ/R9kc4juetOXdup WwEmpZ7C6rjPUltDTNZw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pIqCe-00ABG4-R5; Fri, 20 Jan 2023 12:09:05 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pIqCa-00ABDz-PR for linux-arm-kernel@lists.infradead.org; Fri, 20 Jan 2023 12:09:02 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 62851106F; Fri, 20 Jan 2023 04:09:38 -0800 (PST) Received: from [10.163.48.185] (unknown [10.163.48.185]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 733353F71A; Fri, 20 Jan 2023 04:08:55 -0800 (PST) Message-ID: <34b65af4-0775-09a1-0f67-1c8c74caac1b@arm.com> Date: Fri, 20 Jan 2023 17:38:51 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH] KVM: arm64: Pass the actual page address to mte_clear_page_tags() Content-Language: en-US To: Catalin Marinas , Marc Zyngier Cc: linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev References: <20230119170902.1574756-1-catalin.marinas@arm.com> From: Anshuman Khandual In-Reply-To: <20230119170902.1574756-1-catalin.marinas@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230120_040900_934191_39E21CEE X-CRM114-Status: GOOD ( 16.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 1/19/23 22:39, Catalin Marinas wrote: > Commit d77e59a8fccd ("arm64: mte: Lock a page for MTE tag > initialisation") added a call to mte_clear_page_tags() in case a > prior mte_copy_tags_from_user() failed in order to avoid stale tags in > the guest page (it should have really been a separate commit). > Unfortunately, the argument passed to this function was the address of > the struct page rather than the actual page address. Fix this function > call. > > Fixes: d77e59a8fccd ("arm64: mte: Lock a page for MTE tag initialisation") > Signed-off-by: Catalin Marinas > Cc: Marc Zyngier Reviewed-by: Anshuman Khandual > --- > arch/arm64/kvm/guest.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/kvm/guest.c b/arch/arm64/kvm/guest.c > index 5626ddb540ce..cf4c495a4321 100644 > --- a/arch/arm64/kvm/guest.c > +++ b/arch/arm64/kvm/guest.c > @@ -1079,7 +1079,7 @@ long kvm_vm_ioctl_mte_copy_tags(struct kvm *kvm, > > /* uaccess failed, don't leave stale tags */ > if (num_tags != MTE_GRANULES_PER_PAGE) > - mte_clear_page_tags(page); > + mte_clear_page_tags(maddr); > set_page_mte_tagged(page); > > kvm_release_pfn_dirty(pfn); > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel