From: Markus Elfring <Markus.Elfring@web.de>
To: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>,
linux-sound@vger.kernel.org, devicetree@vger.kernel.org,
dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
Conor Dooley <conor+dt@kernel.org>,
Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@gmail.com>,
Jaroslav Kysela <perex@perex.cz>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Mark Brown <broonie@kernel.org>,
Maxime Ripard <mripard@kernel.org>,
Michal Simek <michal.simek@amd.com>,
Rob Herring <robh+dt@kernel.org>, Takashi Iwai <tiwai@suse.com>,
Thomas Zimmermann <tzimmermann@suse.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
"Anatoliy Klymenko" <anatoliy.klymenko@amd.com>,
"Péter Ujfalusi" <peter.ujfalusi@gmail.com>,
"Vishal Sagar" <vishal.sagar@amd.com>
Subject: Re: [PATCH v3 3/3] drm: xlnx: zynqmp_dpsub: Add DP audio support
Date: Tue, 10 Sep 2024 17:30:30 +0200 [thread overview]
Message-ID: <34e1ae43-0b81-46bd-8fa8-a5fcf48def3e@web.de> (raw)
In-Reply-To: <20240910-xilinx-dp-audio-v3-3-75560793f4d0@ideasonboard.com>
…
> +++ b/drivers/gpu/drm/xlnx/zynqmp_dp_audio.c
> @@ -0,0 +1,461 @@
…
> +static int dp_dai_hw_free(struct snd_pcm_substream *substream,
> + struct snd_soc_dai *socdai)
> +{
…
> + struct zynqmp_dpsub_audio *audio = dpsub->audio;
> +
> + mutex_lock(&audio->enable_lock);
…
> + audio->enabled_streams--;
> +
> + mutex_unlock(&audio->enable_lock);
> +
> + return 0;
> +}
…
Under which circumstances would you become interested to apply a statement
like “guard(mutex)(&audio->enable_lock);”?
https://elixir.bootlin.com/linux/v6.11-rc7/source/include/linux/mutex.h#L196
Regards,
Markus
next prev parent reply other threads:[~2024-09-10 15:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-10 11:19 [PATCH v3 0/3] drm: xlnx: zynqmp: Add DP audio support Tomi Valkeinen
2024-09-10 11:19 ` [PATCH v3 1/3] dt-bindings: display/xlnx/zynqmp-dpsub: Add audio DMAs Tomi Valkeinen
2024-09-11 15:19 ` Rob Herring (Arm)
2024-09-10 11:19 ` [PATCH v3 2/3] arm64: dts: zynqmp: Add DMA for DP audio Tomi Valkeinen
2024-10-08 8:22 ` Michal Simek
2024-10-23 12:00 ` Tomi Valkeinen
2024-10-23 12:50 ` Michal Simek
2024-09-10 11:19 ` [PATCH v3 3/3] drm: xlnx: zynqmp_dpsub: Add DP audio support Tomi Valkeinen
2024-09-10 15:30 ` Markus Elfring [this message]
2024-09-10 15:55 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=34e1ae43-0b81-46bd-8fa8-a5fcf48def3e@web.de \
--to=markus.elfring@web.de \
--cc=airlied@gmail.com \
--cc=anatoliy.klymenko@amd.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=laurent.pinchart@ideasonboard.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=michal.simek@amd.com \
--cc=mripard@kernel.org \
--cc=perex@perex.cz \
--cc=peter.ujfalusi@gmail.com \
--cc=robh+dt@kernel.org \
--cc=tiwai@suse.com \
--cc=tomi.valkeinen@ideasonboard.com \
--cc=tzimmermann@suse.de \
--cc=vishal.sagar@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).