From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A90DAC43334 for ; Sun, 5 Jun 2022 14:56:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3GfnH0Zx5GIQ4D/M0weqN6Ccv2jSSA+mxTnvXAdgXOU=; b=ckbvJrT45bNwSG kVD10kcrDl7gn+OixJt8lDVVhXZSP6OukTjau6vg0kBp+GVYU1uTQnRORmHJKxEca5EL/NeB3t3ME GxRUNrxoZgmLYBmkIStHI8epi3iRZh5Cx2+yLGwtA6AJdC8HT9TNl9fN4R9LAYPonbYaTfupUc4J8 BUn0g6/aCHaKAmBZHNzVbxOXy3FWz8irm488b6UX3Ws2J2TL1HoI0W1pk/kss8gulxasg/RzhA4dU e86dzIbxIEJuzRNJy3XSsn58gO2gv8dZoIwz8yhb8SfLLEaJi7+QQPSqnMBeXl8/Cw/LVSVkQQ/YO oE0hfyvj63ATnjJFgLow==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nxreY-00Eg7s-Pi; Sun, 05 Jun 2022 14:54:54 +0000 Received: from mail-ej1-x633.google.com ([2a00:1450:4864:20::633]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nxreS-00Eg5u-0a for linux-arm-kernel@lists.infradead.org; Sun, 05 Jun 2022 14:54:50 +0000 Received: by mail-ej1-x633.google.com with SMTP id kq6so11506695ejb.11 for ; Sun, 05 Jun 2022 07:54:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=nr9goO6JCR6ynsOrkzdJyNSIrUg9yZwLsbH12VXCnv0=; b=nrithu8KVe+0Ef6h0ePei9GiCMv2WDKM8GSaIfn0Ar6bNX8ASc1AN2K35a49/JrU3Y j7k1YP5G4ugVlQjqD7hAuCd2aeuhbtK5rX6bFyzvxtHlkP8M/y5F145phmQbiR4J3Jvl R85UOsOC9MPCyuuEjTYVXzl71SqvDMby/ip4U7POqd0Bra5XOdQ20YGXgH53LrsGPh59 gaeHsgWIzTUjQj+iouDOtdS6cR7/jwTbqvSsWJPR03Wh9u0yKHTDO7v4BwhVD5myoo4K i17inQ2rz0Q/j8o8eagXaXgmEB/kFnFtQJ2FfBE+qb1ojXv8ba+1MEVFeWTTPR7YewC8 d02g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=nr9goO6JCR6ynsOrkzdJyNSIrUg9yZwLsbH12VXCnv0=; b=3g2bK5IKrGdggsupHQkAF3/gfmJW9P9V1aActCa+6q655uLVIXrb9UsqU47apRRO82 eVaQcl9CRAPiiCU9vyUkPCmCHPCmbCp/g/CDBrBzlVtjHgdxrhCXsevepOOdsr6GVAw0 2JghFa1yaDnSQrNx/JlSnxJP61PoQvLN8fUqSIUTXzBXLl7dYW629hWeUZrdJ7EZdby3 ZOwOKerpCasmxkBQ6mZ5sqY3WNYZ4czCiv59nXcsvYeqAup731+RtBi5Ah6xpN76wFMP 6T0G0NHeh46w/KLciZV4I0bV2mXu8eDbkXTOL+8Xy549Zm3/Oz42sSaMglT8d+X83yAE 4VNA== X-Gm-Message-State: AOAM531HNt/z1eTDR1oaAc9WWk5EfgaB82X8JRs0Nt/wx617L8R1r40p 0oTsrchfDcWvgU0VXfz5dOBLfw== X-Google-Smtp-Source: ABdhPJzJldMnVHXS3QDl/dM42X4k0XAaCUYXOZ4XIGmGG7wyaMi/VlfLe5nM4rkal6LkB6xfrPpcNQ== X-Received: by 2002:a17:907:3f9f:b0:6fe:f9e2:9c6a with SMTP id hr31-20020a1709073f9f00b006fef9e29c6amr18158922ejc.479.1654440885697; Sun, 05 Jun 2022 07:54:45 -0700 (PDT) Received: from [192.168.0.181] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id a23-20020aa7cf17000000b0042dc882c823sm7009190edy.70.2022.06.05.07.54.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 05 Jun 2022 07:54:45 -0700 (PDT) Message-ID: <34e6715e-795c-3d64-1341-31da9bd27563@linaro.org> Date: Sun, 5 Jun 2022 16:54:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [RFC v2 1/2] clk: hisilicon: add CRG driver Hi3521a SoC Content-Language: en-US To: "Marty E. Plummer" Cc: arnd@arndb.de, cai.huoqing@linux.dev, christian.koenig@amd.com, devicetree@vger.kernel.org, gengdongjiu@huawei.com, krzysztof.kozlowski+dt@linaro.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, linux@armlinux.org.uk, michael@walle.cc, miquel.raynal@bootlin.com, mturquette@baylibre.com, novikov@ispras.ru, olof@lixom.net, p.yadav@ti.com, rdunlap@infradead.org, richard@nod.at, robh+dt@kernel.org, sboyd@kernel.org, soc@kernel.org, sumit.semwal@linaro.org, tudor.ambarus@microchip.com, vigneshr@ti.com, xuwei5@hisilicon.com References: <20220501054440.2434247-1-hanetzer@startmail.com> <20220501173423.2473093-1-hanetzer@startmail.com> <20220501173423.2473093-2-hanetzer@startmail.com> <20220601105846.7hriawg3stxb657f@proprietary-killer> <630b0d13-6778-2508-6a34-9daa0358047d@linaro.org> <20220601110616.xmxih663kxgupszv@proprietary-killer> <20220601182418.okoofgannw6vbcxo@proprietary-killer> <20220603112227.hmzwy7xxl6ddezqh@proprietary-killer> From: Krzysztof Kozlowski In-Reply-To: <20220603112227.hmzwy7xxl6ddezqh@proprietary-killer> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220605_075448_086012_B17CEA68 X-CRM114-Status: GOOD ( 15.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 03/06/2022 13:22, Marty E. Plummer wrote: > On Thu, Jun 02, 2022 at 08:37:43AM +0200, Krzysztof Kozlowski wrote: >> On 01/06/2022 20:24, Marty E. Plummer wrote: >> >>>>> Either or. Whatever makes the workload easier is what I'm looking for. >>>> >>>> Sorry, you need to be more specific. Apply is not a job for you, for the >>>> patch submitter. >>>> >>>> Then you miss here important piece - which is the first patch. DTS goes >>>> always via separate branch (or even tree) from driver changes. That's >>>> why bindings are always separate first patches. >>>> >>> So, add a 4: arch/arm/boot/dts/soc.dtsi and 5: arch/arm/boot/dts/board.dts >>> to the above list, or should those be the same patch as well? >> >> For me does not matter, sub architecture maintainer might have preference. >> > Fair enough. That being said, for the dt-bindings patch, is it > permissible to include #define CLOCK_FOO 1337 and so on for clocks which > haven't been wired up in the driver yet? As in, you know they're there, > and are important enough to model, but you haven't gotten to that point > yet? What would be the benefit to include them now? I imagine that if you plan to add such clocks to the driver in next week or something, and you need to use them in DTS, then it's fine. If that's not the case, probably there is little sense in defining them upfront... Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel