From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E2522C3DA6F for ; Thu, 24 Aug 2023 18:39:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=m/HiU2bH66znmuyFocQaeE7ZHh0cIkslVD7xv5Bx+zQ=; b=Rnvrd1GEcr+m89 TatzCcg7B5z2igCE0lHS9jlPQCNIiOcw+Ip9CZvaCTNJD5a2Ki0MAEgqcP5vvUym5VKh0CoECaC7V mSoVvitk+j9izof/B/+IHT34AW30XO8dw+BUVP9ODPjGJv/Tlm/U/PiZyLcm5H78pQiraGZwSxkdp rkh5pEwlQb2LorqcNlQHopVoIs/AExw7YG//HVz5RTlc1foep9KYczhtWnXUQjN/13Pa6sBiEA3ag wzgL9W2Z2ULqmt5YMh7Ons1QSjGB+lq0GSqqr/KVY0DOkhIsCmDeIpdZvh6ZNo0eDaZO4DoqNnNBs TIN5nqEIvgc5nTnldIIA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qZFE8-003bxp-2A; Thu, 24 Aug 2023 18:38:40 +0000 Received: from mail-lj1-x234.google.com ([2a00:1450:4864:20::234]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qZFE5-003bxV-2x for linux-arm-kernel@lists.infradead.org; Thu, 24 Aug 2023 18:38:39 +0000 Received: by mail-lj1-x234.google.com with SMTP id 38308e7fff4ca-2ba1e9b1fa9so1237731fa.3 for ; Thu, 24 Aug 2023 11:38:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1692902316; x=1693507116; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=En2iu839EqQpNqcAkzG5XBjEYnMGVZow4zgnldYb4JA=; b=sHx5bDpEepHLNUc0mEvKIgpaaI6oYKVExdB8uv5CQtZ+yi9KA/waolgk6D5ityUOdD R6663YJYXBqdkE2Dhxeijkf0J1rnIeAYYncTLpCKjOt4c8xpNMYiTOk2eL0A9Gd76/Ml b5foVrLUynpxJj0bdP6EX3yiou3gmhpThjk9OxOFQY56KzRS7awwquwUL1yysKg31o+2 ipjVNTLio6dR8rdrh30SKQ3HzTRrN3/fSV1Su7KOFfJXtJd9Gbt0qiqCYhzbd2CBMPTf 5MXsEKf78TQV+yMiLlJmXa4lccrygtKKDMn3gCqU5p/v3214Av5Mfo/DuwLcTyTH8OVa l8kA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692902316; x=1693507116; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=En2iu839EqQpNqcAkzG5XBjEYnMGVZow4zgnldYb4JA=; b=a6RZ64u1Ts06XOvE1+920l8UPbc3A324ql/SOun/pAqUg7wB9mvUP2BO+aZ6vEgZqk 4F5dnhWOtQWHoII5wiTyx7oZN0suV9q0UYbHo1II8zxz5sPA3erUwdp1ocPYEdqgmzkV pSlZSNZv98/NeSrwzfxeD3P231LJGnJSLaqFduos6B56QW1OUekOgA2oFkPLkMc2hT0x pfNyi4oVbNjAavBW9zmXAtRBVWVhDsLy4zNKsdLKCcWzbRKaYSfxYxi67knwHxoIPAq5 V3YCbWMMO/u8THEROtPh8bdnLVA7ZjSvwsQmrMqpyWBcAC65/WmIMXZmFU7e4SBVOHoK 2OVQ== X-Gm-Message-State: AOJu0YxAHchfukXhHO7W6bbomAcp8vkClKwoXWgaGHo0mKln7rk2svkZ qrANZtMuCtYSq2DxvIqttSZa/w== X-Google-Smtp-Source: AGHT+IEOWz8tiDwTWaanqHibok2oHyVgujQoY13FqBxm19IRl/RLbvgqU6TodBnf7BQzSGb8N7dELQ== X-Received: by 2002:a2e:9d96:0:b0:2bc:ce85:2de2 with SMTP id c22-20020a2e9d96000000b002bcce852de2mr7286418ljj.37.1692902316406; Thu, 24 Aug 2023 11:38:36 -0700 (PDT) Received: from [192.168.0.22] ([77.252.47.198]) by smtp.gmail.com with ESMTPSA id k6-20020a1709062a4600b0099bcbaa242asm11117747eje.9.2023.08.24.11.38.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Aug 2023 11:38:36 -0700 (PDT) Message-ID: <350def85-276e-0514-a5f4-24f95bedb375@linaro.org> Date: Thu, 24 Aug 2023 20:38:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH v5 10/11] firmware: imx: enclave api to read-common-fuses Content-Language: en-US To: Pankaj Gupta , shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, clin@suse.com, conor+dt@kernel.org, pierre.gondois@arm.com, ping.bai@nxp.com, xiaoning.wang@nxp.com, wei.fang@nxp.com, peng.fan@nxp.com, haibo.chen@nxp.com, festevam@gmail.com, linux-imx@nxp.com, davem@davemloft.net, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, gaurav.jain@nxp.com, alexander.stein@ew.tq-group.com, sahil.malhotra@nxp.com, aisheng.dong@nxp.com, V.Sethi@nxp.com References: <20230823073330.1712721-1-pankaj.gupta@nxp.com> <20230823073330.1712721-11-pankaj.gupta@nxp.com> From: Krzysztof Kozlowski In-Reply-To: <20230823073330.1712721-11-pankaj.gupta@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230824_113837_973941_57D56EFE X-CRM114-Status: GOOD ( 12.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 23/08/2023 09:33, Pankaj Gupta wrote: > Added an API to read the common fuses only accessible to > enclave-firmware. > > Signed-off-by: Pankaj Gupta ... > +int read_common_fuse(struct device *dev, > + uint16_t fuse_id, u32 *value) > +{ > + struct ele_mu_priv *priv = dev_get_drvdata(dev); > + int err; > + > + err = plat_fill_cmd_msg_hdr(priv, > + (struct mu_hdr *)&priv->tx_msg.header, > + ELE_READ_FUSE_REQ, 8); > + if (err) { > + pr_err("Error: plat_fill_cmd_msg_hdr failed.\n"); > + return err; > + } > + > + priv->tx_msg.data[0] = fuse_id; > + err = imx_ele_msg_send_rcv(priv); > + if (err < 0) > + return err; > + > + switch (fuse_id) { > + case OTP_UNIQ_ID: > + err = read_otp_uniq_id(priv, value); > + break; > + default: > + err = read_fuse_word(priv, value); > + break; > + } > + > + return err; > +} > +EXPORT_SYMBOL_GPL(read_common_fuse); Missing kerneldoc, missing user. Sorry, this cannot be accepted. Don't add such dead code. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel